From: Aman Karmani <ffmpeg@tmm1.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/videotoolboxenc: use the correct types for options
Date: Sun, 19 Dec 2021 08:37:20 -0800
Message-ID: <CAK=uwuzZXPtnacY+bQ8OuE7as+VYFfvG=qMopV-RBA+4sHBLsg@mail.gmail.com> (raw)
In-Reply-To: <20211218215319.84070-1-rcombs@rcombs.me>
On Sat, Dec 18, 2021 at 1:53 PM rcombs <rcombs@rcombs.me> wrote:
> These are all set by AV_OPT_TYPE_INT or AV_OPT_TYPE_BOOL; the only reason
> they worked before was that this is only used on little-endian.
> ---
> libavcodec/videotoolboxenc.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index 8237bd0ec5..5f1e3a9b9c 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -227,14 +227,14 @@ typedef struct VTEncContext {
> int64_t dts_delta;
>
> int64_t profile;
> - int64_t level;
> - int64_t entropy;
> - int64_t realtime;
> - int64_t frames_before;
> - int64_t frames_after;
> -
> - int64_t allow_sw;
> - int64_t require_sw;
> + int level;
> + int entropy;
> + int realtime;
> + int frames_before;
> + int frames_after;
> +
> + int allow_sw;
> + int require_sw;
LGTM
> double alpha_quality;
>
> bool flushing;
> --
> 2.33.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2021-12-19 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 21:53 rcombs
2021-12-18 21:53 ` [FFmpeg-devel] [PATCH 2/2] lavc/videotoolboxenc: explicitly set realtime=false rcombs
2021-12-19 16:37 ` Aman Karmani
2021-12-19 16:37 ` Aman Karmani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=uwuzZXPtnacY+bQ8OuE7as+VYFfvG=qMopV-RBA+4sHBLsg@mail.gmail.com' \
--to=ffmpeg@tmm1.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git