From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 470854500F for ; Sat, 21 Jan 2023 01:26:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 71A0C68BD64; Sat, 21 Jan 2023 03:26:14 +0200 (EET) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2917F68BD2C for ; Sat, 21 Jan 2023 03:26:08 +0200 (EET) Received: by mail-qk1-f178.google.com with SMTP id x26so3795175qkj.4 for ; Fri, 20 Jan 2023 17:26:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8d7ShZDPCiLRJilPPIUNHCE8lpcGqibyXNNwJeZjutc=; b=Uuwg3nuBVez0bJnHKRfkIWeQ15FUZNA2Roe91d+RDPCFXZ52vzTO2105QMG/SUKg9T 72mmSIy8+Z63wW0XvVo1dUEV6DEX4hPOWy8uoHsyGSGg/N3XjUQizHwDp0rC+zfl8Yho KjKKsyg+QCsALMZ+Fxuu0i+OESlQrWZulXcXSYS/m+LGSGYAI8IPX+ufICGyEI8N4X0N Mfc6cZ/+8vOYdFrGMLn28qnuM+/q4nLLqkB/yks4w6Uh4tpaBPYQmfCA+BMkiSvkaSvT gPzPi0cT+4B5FccQGDWMhlbbxtHXY2snTyumIETW8FmfvyeciLc8jmWlmmujA3xN00kj OJVw== X-Gm-Message-State: AFqh2kqn3EUyBkDMJfVJLX9wJal1BK+7u3q2mlax7aQpvOxzSAu4PtSV y6CFZsZWOz+ySLciuHCDySjJH5EP/1RU3oPIOrW005re X-Google-Smtp-Source: AMrXdXvVN2QM0eEa0gHOvIa6983poXyA2Fm43k7guoQxJH863JYGGCaIrMBIGcDuym5gNjnIUeJ7jna01UwkKLudsDM= X-Received: by 2002:a05:620a:36f2:b0:6ff:8586:d7bf with SMTP id cz50-20020a05620a36f200b006ff8586d7bfmr894871qkb.395.1674264366436; Fri, 20 Jan 2023 17:26:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aman Karmani Date: Fri, 20 Jan 2023 17:25:55 -0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] configure: check for sysctl.h explicitly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jan 17, 2023 at 3:23 AM Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Aman Karmani: > > From: Aman Karmani > > > > HAVE_SYSCTL is used to guard #include , so make sure > > we only define it when that header is present. > > > > In recent glibc, the header was removed: > > https://sourceware.org/pipermail/glibc-cvs/2020q2/069366.html > > > > Signed-off-by: Aman Karmani > > --- > > configure: check for sysctl.h explicitly > > > > HAVE_SYSCTL is used to guard #include , so make sure we > > only define it when that header is present. > > > > In recent glibc, the header was removed: > > https://sourceware.org/pipermail/glibc-cvs/2020q2/069366.html > > > > Signed-off-by: Aman Karmani aman@tmm1.net > > > > Published-As: > https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-49%2Ftmm1%2Fsysctl-chk-v1 > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg > pr-ffstaging-49/tmm1/sysctl-chk-v1 > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/49 > > > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index df69d39669..d2e0ec402d 100755 > > --- a/configure > > +++ b/configure > > @@ -6282,7 +6282,7 @@ check_func setrlimit > > check_struct "sys/stat.h" "struct stat" st_mtim.tv_nsec -D_BSD_SOURCE > > check_func strerror_r > > check_func sysconf > > -check_func sysctl > > +check_func_headers sys/sysctl.h sysctl > > check_func usleep > > > > check_func_headers conio.h kbhit > > > > base-commit: 01f46f18dbcdf323ceb4fdff7358cf3ca71366e6 > > What exactly do we need from said header? You intend to include it if it > available, but we should only include it if it needed. Seems like sysctl.h defines sysctl() on various BSD. See https://www.freebsd.org/cgi/man.cgi?sysctl(3) It is used by libavutil/cpu.c as follows: #if HAVE_SYSCTL #if HAVE_SYS_PARAM_H #include #endif #include #include #endif > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".