From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AA07445531 for ; Thu, 31 Aug 2023 14:38:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B4A7A68C736; Thu, 31 Aug 2023 17:38:28 +0300 (EEST) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6227968C684 for ; Thu, 31 Aug 2023 17:38:22 +0300 (EEST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1c4cf775a14so476622fac.3 for ; Thu, 31 Aug 2023 07:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20230601.gappssmtp.com; s=20230601; t=1693492700; x=1694097500; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IqFZinIPRo/B5DPYlHsqhHMqSMHBD8PRl/90SRVOQSU=; b=Gbxc3Rp9NAl+9/OK309rBellFvC3//4xjCxkjQR5U2XWDf9Ayhk3+UynAEbN5l+DHZ 9qJAORaOeAlScYqC74U8IKl+OyWDShc3YNwTfzHprYorGYwNBOjUSYqC4SxdXSnlv7mY j802khXV/mHmRaj+0D8FZe/7xYxVnZois+AAnkXaQNEiS7V0+sP+Vx0UkZW9t2CZxPTx l020VFNlMYBUsgXG94opuo59stsCYa1+oBK2ysHKR/xLLH1+NV2vc/GIuDv0f8dvKrJU 1Hnwcl6mHkteNzsLMlegGMciXx5RCalgPtTjENjWlSx38cHwQzGCFEX9EwAriKVTqiWD zTBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693492700; x=1694097500; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IqFZinIPRo/B5DPYlHsqhHMqSMHBD8PRl/90SRVOQSU=; b=KYBSxRlidssskI0tvovAuDaPKc5dkfESlFhAB0xGdQzHghx6qTwgxQe7TLM9yA+bcV F/hXdQ7UcCnQ554Ve7b0OG2Mgx9UronAchC0VpoYrrESWgWMZNk3IOxZ1Kj9Tmc02Cxt wXqADGAHDjW2ejSmnfVxIUll07wyQ3bAgD+Bo0LrzMQZbes4MR03tMXJiDPHOW9r0tYj rOJL9LUQEbEHbaFEOXjQT/h2eSzYKJd+LfvfamytkobMoYGVcCzEiJY7WnMtZlGGEpuo UD1we9PXso2X+UdZ6Z0cGDHPEbGwwzK+guI1P4KWa63UlkTb7XrViCZDyPBqU39WgwiZ 2ufg== X-Gm-Message-State: AOJu0Yx2Dn1SuGxdV2rfQ2Ovu+DMuViZwJfnA7UZNvr3EpJscbXzwK2g bobwmAIAd3QX5Ft2u0K0p/FrxJQVc0MOzECdmlQ1dg== X-Google-Smtp-Source: AGHT+IEIm7NSYs5GENOBQN9UlNd7gVSsXBlqQAeYKHjUIjolko+LXGdRYpiBd9RIys9ooNtco76YJ6Yb1W7HPvpKZDI= X-Received: by 2002:a05:6870:c69d:b0:1be:c7e2:fe1 with SMTP id cv29-20020a056870c69d00b001bec7e20fe1mr5902619oab.41.1693492700689; Thu, 31 Aug 2023 07:38:20 -0700 (PDT) MIME-Version: 1.0 References: <20230825100115.393960-1-stefasab@gmail.com> <05e6607364bd43c2a1c2480d216443bc@amazon.it> In-Reply-To: From: Kieran Kunhya Date: Thu, 31 Aug 2023 15:38:09 +0100 Message-ID: To: Kieran Kunhya X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Carotti, Elias" , FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 31 Aug 2023 at 15:30, Kieran Kunhya wrote: > > > On Thu, 31 Aug 2023 at 15:12, Carotti, Elias via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > >> Hi >> >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> Stefano Sabatini >> Sent: Friday, August 25, 2023 12:01 PM >> To: FFmpeg development discussions and patches >> Cc: Stefano Sabatini >> Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable >> x4->params.analyse.b_fast_pskip if mb_info is set >> >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you can confirm the sender and know >> the content is safe. >> >> >> >> x4->params.analyse.b_fast_pskip should only be forced in case mb_info >> is set. >> >> Fix output change introduced in 418c954e318. >> --- >> libavcodec/libx264.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index >> 1a7dc7bdd5..a2877d7f75 100644 >> --- a/libavcodec/libx264.c >> +++ b/libavcodec/libx264.c >> @@ -1190,7 +1190,9 @@ FF_ENABLE_DEPRECATION_WARNINGS >> } >> >> x4->params.analyse.b_mb_info = x4->mb_info; >> - x4->params.analyse.b_fast_pskip = 1; >> + if (x4->mb_info) { >> + x4->params.analyse.b_fast_pskip = x4->mb_info; >> + } >> >> // update AVCodecContext with x264 parameters >> avctx->has_b_frames = x4->params.i_bframe ? >> -- >> 2.25.1 >> >> >> Sorry for the delay. I agree, this was missing in the patch. >> Best >> Elias >> > > What does this patch actually do? > > Kieran > In particular why are you turning on fast_pskip silently based on a completely different setting? Kieran _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".