From: Kieran Kunhya <kierank@obe.tv>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: Remove spec-incompliant inverse quantisation
Date: Mon, 30 Oct 2023 18:40:58 +0000
Message-ID: <CAK+ULv7SHOLYdU2eqjTzYrwEp+X3hi0iU78S8aEiog4Y7nQs=g@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB07442A1CD0C5A69943DF4DA78FA1A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On Mon, 30 Oct 2023 at 13:10, Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:
> Section 7.4.4 of the MPEG-2 specifications requires that the
> last bit of the last coefficient be toggled so that the sum
> of all coefficients is odd; both our decoder and encoder
> did this only if the bitexact flag has been set (although
> stuff like this should be behind AV_CODEC_FLAG2_FAST).
> This patch changes this by removing the spec-incompliant
> functions.
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-30 18:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 13:11 Andreas Rheinhardt
2023-10-30 18:40 ` Kieran Kunhya [this message]
2023-10-31 8:40 ` Michael Niedermayer
2023-11-08 11:40 ` Anton Khirnov
2023-11-08 20:55 ` Alexander Strasser
2023-11-08 22:58 ` Vittorio Giovara
2023-11-09 20:55 ` Alexander Strasser
2023-11-09 10:13 ` Anton Khirnov
2023-11-09 20:45 ` Alexander Strasser
2023-11-09 20:52 ` Rémi Denis-Courmont
2023-11-09 22:16 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK+ULv7SHOLYdU2eqjTzYrwEp+X3hi0iU78S8aEiog4Y7nQs=g@mail.gmail.com' \
--to=kierank@obe.tv \
--cc=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git