From: Kieran Kunhya <kierank@obe.tv>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/frame: flag A53_CC side data type as allowing multiple entries
Date: Thu, 11 Apr 2024 21:17:49 +0100
Message-ID: <CAK+ULv6rzPhP=2HSF30XrxppH+eyrbFfJQfkmmTU3F1iJytjLA@mail.gmail.com> (raw)
In-Reply-To: <20240411154223.61774-1-jamrial@gmail.com>
On Thu, 11 Apr 2024, 16:42 James Almer, <jamrial@gmail.com> wrote:
> Some interlaced h264 samples may export one caption per field.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavutil/frame.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index 0775e2abd9..fdac6f8ee2 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -30,7 +30,6 @@
>
> static const AVSideDataDescriptor sd_props[] = {
> [AV_FRAME_DATA_PANSCAN] = { "AVPanScan" },
> - [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4
> Closed Captions" },
> [AV_FRAME_DATA_MATRIXENCODING] = { "AVMatrixEncoding" },
> [AV_FRAME_DATA_DOWNMIX_INFO] = { "Metadata relevant to
> a downmix procedure" },
> [AV_FRAME_DATA_AFD] = { "Active format
> description" },
> @@ -55,6 +54,7 @@ static const AVSideDataDescriptor sd_props[] = {
> [AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT] = { "Ambient viewing
> environment", AV_SIDE_DATA_PROP_GLOBAL },
> [AV_FRAME_DATA_SPHERICAL] = { "Spherical Mapping",
> AV_SIDE_DATA_PROP_GLOBAL },
> [AV_FRAME_DATA_ICC_PROFILE] = { "ICC profile",
> AV_SIDE_DATA_PROP_GLOBAL },
> + [AV_FRAME_DATA_A53_CC] = { "ATSC A53 Part 4
> Closed Captions", AV_SIDE_DATA_PROP_MULTI },
> [AV_FRAME_DATA_SEI_UNREGISTERED] = { "H.26[45] User Data
> Unregistered SEI message", AV_SIDE_DATA_PROP_MULTI },
> };
>
> --
> 2.44.0
>
But we merge the captions into a single side data element, no?
Kieran
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-11 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 15:42 James Almer
2024-04-11 20:17 ` Kieran Kunhya [this message]
2024-04-11 21:07 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK+ULv6rzPhP=2HSF30XrxppH+eyrbFfJQfkmmTU3F1iJytjLA@mail.gmail.com' \
--to=kierank@obe.tv \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git