From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 668C640679 for ; Thu, 27 Jan 2022 10:13:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 963FD68B21C; Thu, 27 Jan 2022 12:13:23 +0200 (EET) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8618468B215 for ; Thu, 27 Jan 2022 12:13:16 +0200 (EET) Received: by mail-yb1-f172.google.com with SMTP id k31so7129285ybj.4 for ; Thu, 27 Jan 2022 02:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kaPRXHr/EyoJyv0CEzZM7z5IuBo/qbGn/Yyhy9KNjCY=; b=GqDsxnS+PlHc57SyI2EgBO4rPe5mGuH3OqBlA+MAUQCNZUo3ZDcLbuYsCIZOC0/mKJ MB93q1i9CitQqrPECK9Ngn3HocskyvYJFfqX9ZHUZ9pNAScal0e44U/WN1tb58hHgOj3 cgdjhLR3XtsEndaGwlYYUXhQiq3btLgP1tkmQelkNi0RzygTyA6//AWDqQpFJt4lIshl cyxvkweT/jp+26FUGdkFngE9jLKFuCTg87K0h8HTjEpZ/81GtC/7N9gUfCzPFFktn6GT xunOFaAwwbYhF+8Y72CLVnpw3RGCSkTAhgtk72qAyCdiWLrudKqnPvsTNWscvMHzH6Az 3Xmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kaPRXHr/EyoJyv0CEzZM7z5IuBo/qbGn/Yyhy9KNjCY=; b=nNcMP+HTNSXuWz0dlrBJrN+p2uc7QTjVuRmSev+C+eyIJdNwalVo/8VTHUTJhzKL6+ ZUyuI+p5ZZbdSv6QexM8GrOFCQxQtp+F9fQ9hNK+8AaGkKRaPScP4OJaFm5J2ErhRFGj 7S6KVTbTex0dwCaUezX3TfhuW6sRIK2t/dS6Hc8+lcfKHAH6uvqrJUo691H+KGk6FSiS 7uFXMOMAa14ClpoRyUvdKoaQ5ZsRAmEDtRGcAy+YHB4yBRYy/JxFK+wJ77ImVTC8FTWi aifXcfRmtCT666hgnpBJluvNYy99Db3o9GOQGkB1ycLnlLJK/Be3Ng8MCDHB9IHaRsWa +wQA== X-Gm-Message-State: AOAM531IW1KhblwcB0er8YMz8uj3T4n+FrBLVcajmNgcXf1Z/mkez6FE +zUn/UCgT3jhMglbP0Ha79I22UZz9LDah2zV623c1E0PwCE= X-Google-Smtp-Source: ABdhPJxEh62kkABwQwVfRV+UdONH3FRi1j//KrmCh3RNz/sqBxpSaYJ0s92b2Yo08imKyVleIvitiAJm7MpvHva3dB4= X-Received: by 2002:a25:acdb:: with SMTP id x27mr4351260ybd.727.1643278394835; Thu, 27 Jan 2022 02:13:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kieran Kunhya Date: Thu, 27 Jan 2022 10:13:05 +0000 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 24/33] avcodec/mpegvideo: Fix off-by-one error when decoding >8 bit MPEG-4 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 26 Jan 2022 at 21:35, Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Fixes visual corruptions on two macroblocks from two frames from > > https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index e9f2fb212a..47603c2991 100644 > --- a/libavcodec/mpegvideo.c > +++ b/libavcodec/mpegvideo.c > @@ -1648,8 +1648,8 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, > int16_t block[12][64], > int vsub = i ? s->chroma_y_shift : 0; > int hsub = i ? s->chroma_x_shift : 0; > dest_pcm[i] += (linesize[i] / 2) * ((16 >> vsub) > - 1); > - for(h = (16 >> vsub)-1; h >= 1; h--){ > - for(w = (16 >> hsub)-1; w >= 1; w--) > + for (h = (16 >> vsub) - 1; h >= 0; h--) { > + for (w = (16 >> hsub) - 1; w >= 0; w--) > dest_pcm[i][w] = > (*s->dpcm_macroblock)[i][idx++]; > dest_pcm[i] -= linesize[i] / 2; > } > -- > 2.32.0 > Seems fine Kieran _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".