From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3001446A1F for ; Sun, 1 Oct 2023 18:26:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8756F68CCCA; Sun, 1 Oct 2023 21:26:50 +0300 (EEST) Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 99A6E68CBAB for ; Sun, 1 Oct 2023 21:26:43 +0300 (EEST) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1dd4eed487dso5215511fac.3 for ; Sun, 01 Oct 2023 11:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ob-encoder-com.20230601.gappssmtp.com; s=20230601; t=1696184801; x=1696789601; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ZcKEnwJzxJSeBzV3jhKMjDQr285LsE4CSaeZ3WNAl5A=; b=bOFjxLyaYzZqGGi+FjMLfU0Msl0nxw3XdEdH/g373az2Og9mqzdgLl/flC+k6AokTk dM/wVQxdEtBOXp2XeA3p/Ax85StXWbm5p2V3i7nAV1ZXa+gxTQUKV1iVEQ6P6+hWzXFj DrBDJD+L4+wV5cg1gQy63+vyjhyxaOUdgYuAUuIe3mPwtHMNsAXEZyxk3Rqdg/9IBmtR 0JTQEYvLL69nrTOlz2srpllivdd2g7HhsN8fLPtxy5a+GlQQ/shIEkFWRKNnOqjsrUvz 5I88tNVSLBWWPNDFNAZR3lutl/ZmfRdL2bkcIQbg+OdF8dELgnerYc0l+UygswRtB+FE dieA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696184801; x=1696789601; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZcKEnwJzxJSeBzV3jhKMjDQr285LsE4CSaeZ3WNAl5A=; b=czBmw1U4gQs/7ZdL/qgYvuHZPWB1sA7zGdLmvK7KuiNk3HTlgArW71fhXEq/0ejHKg CtU6QmVVHQxWp7o7Fp9RjOv5DAFgRx8/y4y723U1/Q27QaF1+It3cHrcg5b8QpJLPeWl IHrKkTKxxCA/UzBlMKuyFyhwN4GOhTjzda278tce5Lsk8QwTa/p8pj+BN6nQWcE2EZdL oeeGnHOo1Qtvbbt/bHoInPq2vujjfms3Ui3gbttzgNqgU81JDiUku0OB+6DrCm4LEDSg uf24vFdMa16E9yfvPvuPxm5FGNmJl4+62RQp/DHV82lyUcMlwQM36WdZNl/KYWF+jFdI c5SA== X-Gm-Message-State: AOJu0YxHGe/Dnk4SerO5MPi+VJD4wg9Vn1cx/PzwlKsPxbq5JyHN1nz3 W8q/hXnuLW+C6pIma9wafufC3ZpYKouq+5BXwp6NMF89YVnmgANcGmQ= X-Google-Smtp-Source: AGHT+IHSnivGs/Fig3Ur0tRizBB2C0V//UUNDeSlhBOKNceTjpkbWZCdXn9EICUwF4Ztx/ADtM76cbO/y/9xooFdO/A= X-Received: by 2002:a05:6870:2385:b0:1d0:d9e2:985f with SMTP id e5-20020a056870238500b001d0d9e2985fmr11075633oap.57.1696184801288; Sun, 01 Oct 2023 11:26:41 -0700 (PDT) MIME-Version: 1.0 References: <20231001180106.27631-1-michael@niedermayer.cc> In-Reply-To: <20231001180106.27631-1-michael@niedermayer.cc> From: Kieran Kunhya Date: Sun, 1 Oct 2023 20:24:57 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: Avoid EAGAIN X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Sent from my mobile device On Sun, 1 Oct 2023, 20:01 Michael Niedermayer, wrote: > EAGAIN causes an assertion failure when it is returned from the decoder > > Fixes: Assertion consumed != (-(11)) failed at libavcodec/decode.c:462 > Fixes: assertion_IOT_instruction_decode_c_462/poc > > Found-by: Hardik Shah of Vehere (Dawn Treaders team) > Signed-off-by: Michael Niedermayer > --- > libavcodec/h2645_parse.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h > index 787ce971ee4..128dea09efb 100644 > --- a/libavcodec/h2645_parse.h > +++ b/libavcodec/h2645_parse.h > @@ -123,7 +123,7 @@ static inline int get_nalsize(int nal_length_size, > const uint8_t *buf, > > if (*buf_index >= buf_size - nal_length_size) { > // the end of the buffer is reached, refill it > - return AVERROR(EAGAIN); > + return AVERROR_INVALIDDATA; > } > > for (i = 0; i < nal_length_size; i++) > -- > 2.17.1 > But these are not the same for an API user? Kieran > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".