From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C381240AE1 for ; Thu, 31 Aug 2023 14:31:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ED7DD68C78A; Thu, 31 Aug 2023 17:31:02 +0300 (EEST) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D66768C6DB for ; Thu, 31 Aug 2023 17:30:56 +0300 (EEST) Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-76f0807acb6so52071285a.1 for ; Thu, 31 Aug 2023 07:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20230601.gappssmtp.com; s=20230601; t=1693492254; x=1694097054; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2N70rJ5Ei0uhTOa8x7W+8kfxr5YEmX7UEDDRb/DU+q8=; b=MqkfhfjjUs1XVB2C25yk/pHTMNfFwF9sdhP6yl6ajvgl36NcrUva0tNonZVaBZtt31 ntY1zPW8GXDHd0aEUy/SOTOzNewdjaMS0he4V8NLafqmGdEKxhRI3jss9lHOl1G+9t8a Cxuv9bKwfGA+BGBa7mfJxMizP2oOGnbOx46ethCpy/3qdX98a7XIOclkGhsiy52Ju072 dqpjQlTtZD43dm9y2sCI6I2K9rddFyQwRKT5D/WZUc4OO2Nw2pW2FxWr+wpivGypMjQc CDD13qpL6Cf47lyHZ1RaofpYzuxVe/iEK8vByEKEGwLR68O3d2CY5o9zrmk3S9JHFhlp q/gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693492254; x=1694097054; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2N70rJ5Ei0uhTOa8x7W+8kfxr5YEmX7UEDDRb/DU+q8=; b=db0nlYLHFbn0wyY0DTwKTYyXkVyR384pMshAAe7qPxNl3NPnWwJMQtVjKehrzupaWg +zrzCe1u4+YrqtRNXRmTUi1gmXztwXqghIvuI71dHsP8BbFiApso9vJDmj10HFEyOPZZ rM1iHFWZxFfl1NsC61LhvwSivtdfBhsEZ9EGrViP3Vq+5fsEJehEraL4pMud+/W36cgT WGbXxrXsKeirx10c0o8dxF5bk5r473/xCAFqQhYtqdbI4QyGkdTRXi2JM7XclYsybXN+ beZPl9e1Amew8yfMpaIUZab50er4Q9dSqYl1NSLYllsBxdOJKV/lb5OWA10JHDS9B/WT 8OQw== X-Gm-Message-State: AOJu0YyswxhHRXC68KZ2ak2lVluvjDyXLpf39kkhW2sX+3OjVg7Duzys nKSDJpqEx32bKyQXXYn2ypgU0IGt03DO6A0mLr/BEEwonKtLT4IltGA= X-Google-Smtp-Source: AGHT+IFoaxkIidsutd6erylDvZ04zqqQkMy3ylYOE93UgnRsd7hh0MOGnOF8k0341IUfwFN2d3MVwNFp86dO+AHr7cE= X-Received: by 2002:a05:6214:19cb:b0:651:8f39:910d with SMTP id j11-20020a05621419cb00b006518f39910dmr4038148qvc.58.1693492254601; Thu, 31 Aug 2023 07:30:54 -0700 (PDT) MIME-Version: 1.0 References: <20230825100115.393960-1-stefasab@gmail.com> <05e6607364bd43c2a1c2480d216443bc@amazon.it> In-Reply-To: <05e6607364bd43c2a1c2480d216443bc@amazon.it> From: Kieran Kunhya Date: Thu, 31 Aug 2023 15:30:43 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Carotti, Elias" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 31 Aug 2023 at 15:12, Carotti, Elias via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > Hi > > -----Original Message----- > From: ffmpeg-devel On Behalf Of Stefano > Sabatini > Sent: Friday, August 25, 2023 12:01 PM > To: FFmpeg development discussions and patches > Cc: Stefano Sabatini > Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable > x4->params.analyse.b_fast_pskip if mb_info is set > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > x4->params.analyse.b_fast_pskip should only be forced in case mb_info > is set. > > Fix output change introduced in 418c954e318. > --- > libavcodec/libx264.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index > 1a7dc7bdd5..a2877d7f75 100644 > --- a/libavcodec/libx264.c > +++ b/libavcodec/libx264.c > @@ -1190,7 +1190,9 @@ FF_ENABLE_DEPRECATION_WARNINGS > } > > x4->params.analyse.b_mb_info = x4->mb_info; > - x4->params.analyse.b_fast_pskip = 1; > + if (x4->mb_info) { > + x4->params.analyse.b_fast_pskip = x4->mb_info; > + } > > // update AVCodecContext with x264 parameters > avctx->has_b_frames = x4->params.i_bframe ? > -- > 2.25.1 > > > Sorry for the delay. I agree, this was missing in the patch. > Best > Elias > What does this patch actually do? Kieran _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".