From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E2818405EB for ; Fri, 27 May 2022 15:16:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B506C68B5AE; Fri, 27 May 2022 18:16:38 +0300 (EEST) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 86AB168B4CA for ; Fri, 27 May 2022 18:16:32 +0300 (EEST) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-300beab2b76so50192297b3.13 for ; Fri, 27 May 2022 08:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obe-tv.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=wRA2AZz210Q0yblYm7n+9hpyWxqDRcbnod+qxELZnks=; b=NHXKuTzK93zmhevcbMg18vMDROBiVFd4hdf7wWnZt/TQvqBH1Qil2bjQdP9njpVTqT eIvDQb/YHATE5lnCoqI8P2n0W7IIsVrMcXIVBm+VDJRggX+Nrrbv4hVLT+8TMzC4xLrL FKnkVSEim0I8+Z4xe3CQrJa1gG9jCrPtBqTkqvHndG1RNy/H/0CSfc18uS5n+aOBTS2H jErZsJHX5jun4W3C7R/7w1OSrnJ3mxOfM8r34gwrJUXP4i/NtpRT6T0hNU5NVdFr4972 +I+9QRYNF2LDvz13q4qvFSyf1rIjZbxAaHbFJIjIqHoldcFAbsNOJ9WEpcDcrkSs2PgX BcfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=wRA2AZz210Q0yblYm7n+9hpyWxqDRcbnod+qxELZnks=; b=TkfIOowDeM5CrS9kUa/Xu0Ap5XiiBQ42hZ7Uokj654fchO6XeWyZZv7B9kQ/xg0qxS k/Y6nIUm+y8cfKLkU0h/UcHR9J60usTbJKDSj6oJbu+TuqHpFM+EBIOHVXC9JJDQnXm2 7eT90NywdT2ajRDUSbW7WTORgtTM4d5B65A2fphkiTFv6orfTXb4fsHTwVjH6/er5c2C m+KTw/mVZzhqspZ3iw/2XRecFqNf0vjE3GOjUgZiKfT8Iol1rqwXydzC7017tLD9rcu2 6HCXl4qQ+78twjvgBMosqk0VBZbGMMb+U5BwPvjo5NqWLD+uqC5Xgi3f0Fk2JOjL1z6K pbzA== X-Gm-Message-State: AOAM530jHA01vO0GouicsmEky3l2LBeAt3xKpPIjH1Z9f/r5qJEY8EZ9 LKcCbJDxR4riDNg5HUb7Mihpzk3Pr+RBzGjDoeuLoHL+pAJxLQ== X-Google-Smtp-Source: ABdhPJzIIxTjazvfcAQXCKrQtyKcAMruqAqRGxA2ytGorPBr13PY/IujAZWR0PVAg8GsLIID6dyTpbGhalvL086ctOM= X-Received: by 2002:a81:c54a:0:b0:2d6:435a:5875 with SMTP id o10-20020a81c54a000000b002d6435a5875mr43020519ywj.181.1653664590288; Fri, 27 May 2022 08:16:30 -0700 (PDT) MIME-Version: 1.0 References: <20220527082922.994-1-ffmpeg@gyani.pro> In-Reply-To: <20220527082922.994-1-ffmpeg@gyani.pro> From: Kieran Kunhya Date: Fri, 27 May 2022 16:16:36 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove support for x262 MPEG-2 encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 27 May 2022 at 09:30, Gyan Doshi wrote: > Support for 'libx262' was added in e56f14659f by merging > Libav e1319aa1c1. > > The Libav commit author believed that "x262 is a subfeature of x264" > but this is not the case. Kieran Kuhnya added support for MPEG-2 > encoding in *his fork* of x264. > See https://github.com/kierank/x262/commit/6851000e27 > x262 is a VideoLAN project: https://git.videolan.org/?p=x262.git;a=summary > So there are two issues: > 1) Our configure enables libx262 implicitly if libx264 is enabled > and a x262 constant is defined in x264.h; this will never be fulfilled > with native x264. Users would have to build x262 and use the libx264 > generated there. Which brings us to the 2nd issue. > Yes, there was some reason that I forget that meant we couldn't have a single binary doing both. And mainline x264 will never merge x262. > 2) Development on the x262 repo stopped in 2015. So, it's likely API > and ABI incompatible with native x264 and thus our current wrapper. > x262 works fine irrespective of lack of development. MPEG-2 came out in 1993 after all. Kieran _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".