Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Kieran Kunhya <kierank@obe.tv>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove support for x262 MPEG-2 encoder
Date: Fri, 27 May 2022 16:16:36 +0100
Message-ID: <CAK+ULv5EJhKcPgP2v-C==40dKU1Jm-nJDS09d6UvTFjfSgK+bw@mail.gmail.com> (raw)
In-Reply-To: <20220527082922.994-1-ffmpeg@gyani.pro>

On Fri, 27 May 2022 at 09:30, Gyan Doshi <ffmpeg@gyani.pro> wrote:

> Support for 'libx262' was added in e56f14659f by merging
> Libav e1319aa1c1.
>
> The Libav commit author believed that "x262 is a subfeature of x264"
> but this is not the case. Kieran Kuhnya added support for MPEG-2
> encoding in *his fork* of x264.
> See https://github.com/kierank/x262/commit/6851000e27
>

x262 is a VideoLAN project: https://git.videolan.org/?p=x262.git;a=summary


> So there are two issues:
> 1) Our configure enables libx262 implicitly if libx264 is enabled
> and a x262 constant is defined in x264.h; this will never be fulfilled
> with native x264. Users would have to build x262 and use the libx264
> generated there. Which brings us to the 2nd issue.
>

Yes, there was some reason that I forget that meant we couldn't have a
single binary doing both.
And mainline x264 will never merge x262.


> 2) Development on the x262 repo stopped in 2015. So, it's likely API
> and ABI incompatible with native x264 and thus our current wrapper.
>

x262 works fine irrespective of lack of development. MPEG-2 came out in
1993 after all.

Kieran
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-05-27 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  8:29 Gyan Doshi
2022-05-27 15:16 ` Kieran Kunhya [this message]
2022-05-28  4:05   ` Gyan Doshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK+ULv5EJhKcPgP2v-C==40dKU1Jm-nJDS09d6UvTFjfSgK+bw@mail.gmail.com' \
    --to=kierank@obe.tv \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git