From: Kieran Kunhya <kierank@obe.tv>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/flvenc: Avoid avio_write(pb, "", 0)
Date: Thu, 21 Mar 2024 13:17:31 +0000
Message-ID: <CAK+ULv50G3_+CJBRbVyFzJ=1jvepv7eefb=oUJYzoCELzMZqZw@mail.gmail.com> (raw)
In-Reply-To: <DU0P250MB0747F7F090F7FC7E6B962CE38F322@DU0P250MB0747.EURP250.PROD.OUTLOOK.COM>
On Thu, 21 Mar 2024 at 13:13, Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:
> Andreas Rheinhardt:
> > When the compiler chooses to inline put_amf_string(pb, ""),
> > the avio_write(pb, "", 0) can be avoided. Happens with
> > Clang-17 with -O1 and higher and GCC 13 with -O2 and higher
> > here.
>
Are you able to add a comment in the code? It's not 100% clear what you are
doing.
Kieran
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-21 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 3:29 Andreas Rheinhardt
2024-03-21 13:12 ` Andreas Rheinhardt
2024-03-21 13:17 ` Kieran Kunhya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK+ULv50G3_+CJBRbVyFzJ=1jvepv7eefb=oUJYzoCELzMZqZw@mail.gmail.com' \
--to=kierank@obe.tv \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git