From: Pavel Koshevoy <pkoshevoy@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/mfenc: set output packet duration
Date: Wed, 13 Aug 2025 17:39:12 -0600
Message-ID: <CAJgjuozsgOtXk6hBVQ57Yhk+BhjTeqKgZak5JEghy-i7awrD0g@mail.gmail.com> (raw)
In-Reply-To: <2aa01f13-6636-489d-8faf-ac51675822e7@gmail.com>
On Tue, Aug 12, 2025 at 7:59 AM James Almer <jamrial@gmail.com> wrote:
> On 8/4/2025 4:50 PM, Pavel Koshevoy wrote:
> > ---
> > libavcodec/mfenc.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
> > index 30531fe3e8..942c75cb9d 100644
> > --- a/libavcodec/mfenc.c
> > +++ b/libavcodec/mfenc.c
> > @@ -148,6 +148,15 @@ static int64_t mf_sample_get_pts(AVCodecContext
> *avctx, IMFSample *sample)
> > return mf_from_mf_time(avctx, pts);
> > }
> >
> > +static int64_t mf_sample_get_duration(AVCodecContext *avctx, IMFSample
> *sample)
> > +{
> > + LONGLONG duration;
> > + HRESULT hr = IMFSample_GetSampleDuration(sample, &duration);
> > + if (FAILED(hr))
> > + return 0;
> > + return mf_from_mf_time(avctx, duration);
> > +}
> > +
> > static int mf_enca_output_type_get(AVCodecContext *avctx, IMFMediaType
> *type)
> > {
> > MFContext *c = avctx->priv_data;
> > @@ -275,6 +284,7 @@ static int mf_sample_to_avpacket(AVCodecContext
> *avctx, IMFSample *sample, AVPac
> > IMFMediaBuffer_Release(buffer);
> >
> > avpkt->pts = avpkt->dts = mf_sample_get_pts(avctx, sample);
> > + avpkt->duration = mf_sample_get_duration(avctx, sample);
> >
> > hr = IMFAttributes_GetUINT32(sample,
> &MFSampleExtension_CleanPoint, &t32);
> > if (c->is_audio || (!FAILED(hr) && t32 != 0))
>
> Will apply.
>
I just checked, and it's not applied. Any idea when it will be applied?
Thank you,
Pavel.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-08-13 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 19:50 Pavel Koshevoy
2025-08-07 12:14 ` Pavel Koshevoy
2025-08-12 13:56 ` Pavel Koshevoy
2025-08-12 13:58 ` James Almer
2025-08-13 23:39 ` Pavel Koshevoy [this message]
2025-08-14 14:14 ` James Almer via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJgjuozsgOtXk6hBVQ57Yhk+BhjTeqKgZak5JEghy-i7awrD0g@mail.gmail.com \
--to=pkoshevoy@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git