Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Pavel Koshevoy <pkoshevoy@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] fftools: Avoid build failure on OSX 10.6 with gcc 4.2.1
Date: Tue, 18 Jul 2023 08:49:33 -0600
Message-ID: <CAJgjuoxMnhfDWqh7MdPzNnbbF=pa-mriWsDwApGgkMV-XenSbQ@mail.gmail.com> (raw)
In-Reply-To: <20230715183336.8052-1-pkoshevoy@gmail.com>

ping ... could someone review this please

On Sat, Jul 15, 2023 at 12:33 PM Pavel Koshevoy <pkoshevoy@gmail.com> wrote:

> ... and make code more readable / human friendly.
> ---
>  fftools/ffmpeg_mux_init.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> index 6458414b5f..bade35896f 100644
> --- a/fftools/ffmpeg_mux_init.c
> +++ b/fftools/ffmpeg_mux_init.c
> @@ -1648,7 +1648,8 @@ read_fail:
>
>  static int create_streams(Muxer *mux, const OptionsContext *o)
>  {
> -    static const int (*map_func[])(Muxer *mux, const OptionsContext *o) =
> {
> +    typedef int(*TMapFunc)(Muxer *, const OptionsContext *);
> +    static const TMapFunc map_func[] = {
>          [AVMEDIA_TYPE_VIDEO]    = map_auto_video,
>          [AVMEDIA_TYPE_AUDIO]    = map_auto_audio,
>          [AVMEDIA_TYPE_SUBTITLE] = map_auto_subtitle,
> --
> 2.35.3
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-07-18 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15 18:33 Pavel Koshevoy
2023-07-18 14:49 ` Pavel Koshevoy [this message]
2023-07-18 22:00   ` Andreas Rheinhardt
2023-07-18 23:46     ` Pavel Koshevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJgjuoxMnhfDWqh7MdPzNnbbF=pa-mriWsDwApGgkMV-XenSbQ@mail.gmail.com' \
    --to=pkoshevoy@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git