From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2288E48AEB for ; Mon, 1 Apr 2024 14:38:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3917668CE36; Mon, 1 Apr 2024 17:38:03 +0300 (EEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF12F68CBF2 for ; Mon, 1 Apr 2024 17:37:57 +0300 (EEST) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-29df0ca87d1so3371687a91.2 for ; Mon, 01 Apr 2024 07:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711982275; x=1712587075; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ODfU5z+exifZe8UglRvribWzZYfLZAOhVp0af44giAM=; b=gkZQngOpSkv4V/Kh5qpXq7uf+SIWDBVBf8e3lU3oDlo5zOg8/su5wJDEa/uDdObID8 5jEFsHDkSMTMrhofwSGtswPhb4P/2cGOQIg68KRNlfcoPeuip7ZeiDe3TaD+OXBi4tuX zgClTCq3s3WmCikeBzejJdNE4kp9nE7sjNDO3Ye+5jX1IbFk95iaWkOmxzyu7kx1ah98 XMwh/x1UJRwRcBOoEkT4lIqaz3YyaLXKAbd8znZro3qKpckAI4/Iheg67bf7oQ4gynFK MRfgQedHPnaxOcRFA08DVtledp2ooATsr8a5uV427vi+uLBxpruaqfJS/z+L7edwu3MZ Q/fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711982275; x=1712587075; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ODfU5z+exifZe8UglRvribWzZYfLZAOhVp0af44giAM=; b=HwhqdKfGP7Jc2s/v3IQWZzCDmGpuZEByJf8bNOzFPn7NU7QX7rl7ratZ+KSHppKlkY Z66qokfdJsBTFzuQHxH8jh/nGaSwHadF3FXLc3oRLeltsKqDE5FObqLPmCvPnnoFlelN jQpoxN2P0o+HzgvGi5m+TbNfLCU12JVbB5gPINSaffNsYFi+E6X9D8wvRh1TU/CxN0aL OSrkd6rpHaBEMZavdMtJr7q4DpHRvkAOGXngZ/p4M7sMxT0PNgzFiwNHGh7FaIwuW98J +VXSGvz3A7tW1vAz2kPu2xAsNbfYVon+E4TfHu9Oc3YLRVLV2+fSYAAaMrv/HQhD9Mle U0uQ== X-Gm-Message-State: AOJu0Yznc/86GEqdcLiAnTOfXPmBtUW/083AQ1X7cMrb6Kqn6VRdq++k agFKRgMLOovmMCHvIH4wQI6ByW/WCaUBv+X8wuXUguQLrImWNs9y5RefAHmPrq4nnay2l79SKkO bASg0Plil7lJyTvo5cSGK/q71JtE5ZDhqWkU= X-Google-Smtp-Source: AGHT+IGGDTt7i1KVdPGqhwDBk+BRXmePyXMHo/rXs5evuFytb7AmDPPmUVSVN4njZ+FEAFwU+/gMLtXNOMiQYj9t+lA= X-Received: by 2002:a17:90a:428c:b0:29c:7690:2724 with SMTP id p12-20020a17090a428c00b0029c76902724mr7791492pjg.16.1711982275419; Mon, 01 Apr 2024 07:37:55 -0700 (PDT) MIME-Version: 1.0 References: <79a25348-0193-4acb-8844-cd2dfaa73ac6@gmail.com> In-Reply-To: From: Poorva <2003gaikarpoorva@gmail.com> Date: Mon, 1 Apr 2024 20:07:41 +0530 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="0000000000006376a3061509efcf" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Fixes #10509 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --0000000000006376a3061509efcf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > > On Sun, Mar 31, 2024 at 8:35=E2=80=AFPM Marton Balint wrote= : > > > On Fri, 29 Mar 2024, Poorva wrote: > > >> > > > > On Tue, Mar 26, 2024 at 2:36=E2=80=AFAM Poorva <2003gaikarpoorva@gmail.= com> > wrote: > >>> > >>> > >> > >> > >> Thank you for your feedback on the Git patch I submitted for review. > >> I have rectified the problem by adding the necessary changes . > >> The updated patch file is attached for your review. > >>> > >>> > > I wanted to follow up on the patch titled > > "v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I > > submitted earlier and provide an update based on the feedback > > received. > > > > In response to your suggestion about the switch block, I have > > integrated the changes into the existing switch block for > > AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new > > line that was added at the end of the file. > > > > Despite these modifications, I have not received any further feedback > > or comments on the patch. Therefore, I kindly request the community to > > review the updated patch attached to this email. > > [..] > > > @@ -371,6 +383,7 @@ FF_ENABLE_DEPRECATION_WARNINGS > > break; > > } > > > > + > > select->select =3D res =3D av_expr_eval(select->expr, > select->var_values, NULL); > > av_log(inlink->dst, AV_LOG_DEBUG, > > "n:%f pts:%f t:%f key:%d", > > @@ -545,4 +558,4 @@ const AVFilter ff_vf_select =3D { > > FILTER_QUERY_FUNC(query_formats), > > .flags =3D AVFILTER_FLAG_DYNAMIC_OUTPUTS | > AVFILTER_FLAG_METADATA_ONLY, > > }; > > -#endif /* CONFIG_SELECT_FILTER */ > > +#endif /* CONFIG_SELECT_FILTER */ > > \ No newline at end of file > > -- > > 2.43.0.windows.1 > > > > These two whitespace changes are still unnecessary. Please check your > patch before sending. > > I did remove all the unnecessary whitespaces ,rest which are present are to keep the code style . Patch is attached to this email. Thanks, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > --0000000000006376a3061509efcf Content-Type: application/octet-stream; name="v3-0001-avfilter-f_select.c-add-support-for-iw-and-ih-con.patch" Content-Disposition: attachment; filename="v3-0001-avfilter-f_select.c-add-support-for-iw-and-ih-con.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luh20qfk0 RnJvbSA5NWU4ZjA5ODkwOWQ5OTk3YTE3ZjhmZjBlY2FiNTI0YWMyNTcxM2IyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQb29ydmFHYWlrYXIgPHBiZ2Fpa2FyX2IyMUBlbC52anRpLmFj LmluPgpEYXRlOiBTYXQsIDkgTWFyIDIwMjQgMDA6Mjc6MjUgKzA1MzAKU3ViamVjdDogW1BBVENI IHYzXSBhdmZpbHRlci9mX3NlbGVjdC5jOiBhZGQgc3VwcG9ydCBmb3IgaXcgYW5kIGloIGNvbnN0 YW50cwoKRml4ZXMgIzEwNTA5Ci0tLQogZG9jL2ZpbHRlcnMudGV4aSAgICAgICB8ICA2ICsrKysr KwogbGliYXZmaWx0ZXIvZl9zZWxlY3QuYyB8IDE0ICsrKysrKysrKysrKystCiAyIGZpbGVzIGNo YW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kb2Mv ZmlsdGVycy50ZXhpIGIvZG9jL2ZpbHRlcnMudGV4aQppbmRleCBiZmE4Y2NlYzhiLi40YjgwMzc4 Yzc5IDEwMDY0NAotLS0gYS9kb2MvZmlsdGVycy50ZXhpCisrKyBiL2RvYy9maWx0ZXJzLnRleGkK QEAgLTMwNzUxLDYgKzMwNzUxLDEyIEBAIG1pc3NpbmcuCiBUaGF0IGJhc2ljYWxseSBtZWFucyB0 aGF0IGFuIGlucHV0IGZyYW1lIGlzIHNlbGVjdGVkIGlmIGl0cyBwdHMgaXMgd2l0aGluIHRoZQog aW50ZXJ2YWwgc2V0IGJ5IHRoZSBjb25jYXQgZGVtdXhlci4KIAorQGl0ZW0gaXcgQGVtcGh7KHZp ZGVvIG9ubHkpfQorUmVwcmVzZW50cyB0aGUgd2lkdGggb2YgdGhlIGlucHV0IHZpZGVvIGZyYW1l CisKK0BpdGVtIGloIEBlbXBoeyh2aWRlbyBvbmx5KX0KK1JlcHJlc2VudHMgdGhlIGhlaWdodCBv ZiB0aGUgaW5wdXQgdmlkZW8gZnJhbWUKKwogQGVuZCB0YWJsZQogCiBUaGUgZGVmYXVsdCB2YWx1 ZSBvZiB0aGUgc2VsZWN0IGV4cHJlc3Npb24gaXMgIjEiLgpkaWZmIC0tZ2l0IGEvbGliYXZmaWx0 ZXIvZl9zZWxlY3QuYyBiL2xpYmF2ZmlsdGVyL2Zfc2VsZWN0LmMKaW5kZXggOWIzMzBhMDY3My4u ZTI3MGFkODU2MyAxMDA2NDQKLS0tIGEvbGliYXZmaWx0ZXIvZl9zZWxlY3QuYworKysgYi9saWJh dmZpbHRlci9mX3NlbGVjdC5jCkBAIC05MCw2ICs5MCw5IEBAIHN0YXRpYyBjb25zdCBjaGFyICpj b25zdCB2YXJfbmFtZXNbXSA9IHsKIAogICAgICJjb25jYXRkZWNfc2VsZWN0IiwgIC8vLzwgZnJh bWUgaXMgd2l0aGluIHRoZSBpbnRlcnZhbCBzZXQgYnkgdGhlIGNvbmNhdCBkZW11eGVyCiAKKyAg ICAiaWgiLCAgICAgICAgICAgICAgICAvLy88IGloOiBSZXByZXNlbnRzIHRoZSBoZWlnaHQgb2Yg dGhlIGlucHV0IHZpZGVvIGZyYW1lLgorICAgICJpdyIsICAgICAgICAgICAgICAgIC8vLzwgaXc6 IFJlcHJlc2VudHMgdGhlIHdpZHRoIG9mIHRoZSBpbnB1dCB2aWRlbyBmcmFtZS4KKwogICAgIE5V TEwKIH07CiAKQEAgLTE0NCw2ICsxNDcsOSBAQCBlbnVtIHZhcl9uYW1lIHsKIAogICAgIFZBUl9D T05DQVRERUNfU0VMRUNULAogCisgICAgVkFSX0lILAorICAgIFZBUl9JVywKKwogICAgIFZBUl9W QVJTX05CCiB9OwogCkBAIC0yNjQsNiArMjcwLDkgQEAgc3RhdGljIGludCBjb25maWdfaW5wdXQo QVZGaWx0ZXJMaW5rICppbmxpbmspCiAgICAgc2VsZWN0LT52YXJfdmFsdWVzW1ZBUl9DT05TVU1F RF9TQU1QTEVTX05dID0gTkFOOwogICAgIHNlbGVjdC0+dmFyX3ZhbHVlc1tWQVJfU0FNUExFU19O XSAgICAgICAgICA9IE5BTjsKIAorICAgIHNlbGVjdC0+dmFyX3ZhbHVlc1tWQVJfSUhdID0gTkFO OworICAgIHNlbGVjdC0+dmFyX3ZhbHVlc1tWQVJfSVddID0gTkFOOworCiAgICAgc2VsZWN0LT52 YXJfdmFsdWVzW1ZBUl9TQU1QTEVfUkFURV0gPQogICAgICAgICBpbmxpbmstPnR5cGUgPT0gQVZN RURJQV9UWVBFX0FVRElPID8gaW5saW5rLT5zYW1wbGVfcmF0ZSA6IE5BTjsKIApAQCAtMzU3LDYg KzM2Niw5IEBAIEZGX0VOQUJMRV9ERVBSRUNBVElPTl9XQVJOSU5HUwogICAgICAgICBicmVhazsK IAogICAgIGNhc2UgQVZNRURJQV9UWVBFX1ZJREVPOgorICAgICAgICBzZWxlY3QtPnZhcl92YWx1 ZXNbVkFSX0lIXSA9IGZyYW1lLT5oZWlnaHQ7CisgICAgICAgIHNlbGVjdC0+dmFyX3ZhbHVlc1tW QVJfSVddID0gZnJhbWUtPndpZHRoOworCiAgICAgICAgIHNlbGVjdC0+dmFyX3ZhbHVlc1tWQVJf SU5URVJMQUNFX1RZUEVdID0KICAgICAgICAgICAgICEoZnJhbWUtPmZsYWdzICYgQVZfRlJBTUVf RkxBR19JTlRFUkxBQ0VEKSA/IElOVEVSTEFDRV9UWVBFX1AgOgogICAgICAgICAoZnJhbWUtPmZs YWdzICYgQVZfRlJBTUVfRkxBR19UT1BfRklFTERfRklSU1QpID8gSU5URVJMQUNFX1RZUEVfVCA6 IElOVEVSTEFDRV9UWVBFX0I7CkBAIC01NDUsNCArNTU3LDQgQEAgY29uc3QgQVZGaWx0ZXIgZmZf dmZfc2VsZWN0ID0gewogICAgIEZJTFRFUl9RVUVSWV9GVU5DKHF1ZXJ5X2Zvcm1hdHMpLAogICAg IC5mbGFncyAgICAgICAgID0gQVZGSUxURVJfRkxBR19EWU5BTUlDX09VVFBVVFMgfCBBVkZJTFRF Ul9GTEFHX01FVEFEQVRBX09OTFksCiB9OwotI2VuZGlmIC8qIENPTkZJR19TRUxFQ1RfRklMVEVS ICovCisjZW5kaWYgLyogQ09ORklHX1NFTEVDVF9GSUxURVIgKi8KXCBObyBuZXdsaW5lIGF0IGVu ZCBvZiBmaWxlCi0tIAoyLjQzLjAud2luZG93cy4xCgo= --0000000000006376a3061509efcf Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --0000000000006376a3061509efcf--