[FFmpeg-devel] Fixes #10509

[FFmpeg-devel] Fixes #10509

[Poorva]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

I have attached the git patch containing the changes for your review.

This patch is submitted as part of my qualification task for Google Summer
of Code (GSoC)

[-- Attachment #2: 0001-avfilter-f_select.c-add-support-for-iw-and-ih-consta.patch --]
[-- Type: application/octet-stream, Size: 2069 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Leo Izen]

[-- Attachment #1.1.1: Type: text/plain, Size: 314 bytes --]

On 3/9/24 15:49, Poorva wrote:
> I have attached the git patch containing the changes for your review.
> 
> This patch is submitted as part of my qualification task for Google Summer
> of Code (GSoC)
> 

Your editor appears to have stripped the newline at the end of the file.

- Leo Izen (Traneptora)


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Poorva]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

On Mon, Mar 11, 2024 at 1:10 AM Leo Izen <leo.izen@gmail.com> wrote:
>
> On 3/9/24 15:49, Poorva wrote:
> > I have attached the git patch containing the changes for your review.
> >
> > This patch is submitted as part of my qualification task for Google Summer
> > of Code (GSoC)
> >
>
> Your editor appears to have stripped the newline at the end of the file.
>

Thank you for your feedback on the Git patch I submitted for review. I
apologize for the newline issue; it seems my editor removed it
unintentionally.
I have rectified the problem by adding the necessary newline at the
end of the file. The updated patch file is attached for your review.

[-- Attachment #2: 0001-avfilter-f_select.c-add-support-for-iw-and-ih-consta.patch --]
[-- Type: application/octet-stream, Size: 1839 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Marton Balint]

On Sun, 17 Mar 2024, Poorva wrote:

> On Mon, Mar 11, 2024 at 1:10 AM Leo Izen <leo.izen@gmail.com> wrote:
>>
>> On 3/9/24 15:49, Poorva wrote:
>>> I have attached the git patch containing the changes for your review.
>>>
>>> This patch is submitted as part of my qualification task for Google Summer
>>> of Code (GSoC)
>>>
>>
>> Your editor appears to have stripped the newline at the end of the file.

> diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
> index 9b330a0673..965f5a0b54 100644
> --- a/libavfilter/f_select.c
> +++ b/libavfilter/f_select.c
> @@ -90,6 +90,9 @@ static const char *const var_names[] = {
>
>      "concatdec_select",  ///< frame is within the interval set by the concat demuxer
> 
> +    "ih",                ///< ih: Represents the height of the input video frame.
> +    "iw",                ///< iw: Represents the width of the input video frame.
> +
>      NULL
>  };
> 
> @@ -144,6 +147,9 @@ enum var_name {
>
>      VAR_CONCATDEC_SELECT,
> 
> +    VAR_IH,
> +    VAR_IW,
> +
>      VAR_VARS_NB
>  };
> 
> @@ -264,6 +270,9 @@ static int config_input(AVFilterLink *inlink)
>      select->var_values[VAR_CONSUMED_SAMPLES_N] = NAN;
>      select->var_values[VAR_SAMPLES_N]          = NAN;
> 
> +    select->var_values[VAR_IH] = inlink->h;
> +    select->var_values[VAR_IW] = inlink->w;

Initial valaues should be NAN. This may well be an audio filter, when 
ih/iw is not available.

> +
>      select->var_values[VAR_SAMPLE_RATE] =
>          inlink->type == AVMEDIA_TYPE_AUDIO ? inlink->sample_rate : NAN;
> 
> @@ -371,6 +380,9 @@ FF_ENABLE_DEPRECATION_WARNINGS
>          break;
>      }
> 
> +    select->var_values[VAR_IH] = frame->height;
> +    select->var_values[VAR_IW] = frame->width;

You shold only set these for the VIDEO case.

> +
>      select->select = res = av_expr_eval(select->expr, select->var_values, NULL);
>      av_log(inlink->dst, AV_LOG_DEBUG,
>             "n:%f pts:%f t:%f key:%d",
> @@ -546,3 +558,4 @@ const AVFilter ff_vf_select = {
>      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS | AVFILTER_FLAG_METADATA_ONLY,
>  };
>  #endif /* CONFIG_SELECT_FILTER */
> +

Extra added line.

> -- 
> 2.43.0.windows.1

Documentation update missing.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Poorva]

[-- Attachment #1: Type: text/plain, Size: 3084 bytes --]

>

On Sun, Mar 17, 2024 at 12:26 AM Marton Balint <cus@passwd.hu> wrote:
>
>
>
> On Sun, 17 Mar 2024, Poorva wrote:
>
> > On Mon, Mar 11, 2024 at 1:10 AM Leo Izen <leo.izen@gmail.com> wrote:
> >>
> >> On 3/9/24 15:49, Poorva wrote:
> >>> I have attached the git patch containing the changes for your review.
> >>>
> >>> This patch is submitted as part of my qualification task for Google Summer
> >>> of Code (GSoC)
> >>>
> >>
> >> Your editor appears to have stripped the newline at the end of the file.
>
> > diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
> > index 9b330a0673..965f5a0b54 100644
> > --- a/libavfilter/f_select.c
> > +++ b/libavfilter/f_select.c
> > @@ -90,6 +90,9 @@ static const char *const var_names[] = {
> >
> >      "concatdec_select",  ///< frame is within the interval set by the concat demuxer
> >
> > +    "ih",                ///< ih: Represents the height of the input video frame.
> > +    "iw",                ///< iw: Represents the width of the input video frame.
> > +
> >      NULL
> >  };
> >
> > @@ -144,6 +147,9 @@ enum var_name {
> >
> >      VAR_CONCATDEC_SELECT,
> >
> > +    VAR_IH,
> > +    VAR_IW,
> > +
> >      VAR_VARS_NB
> >  };
> >
> > @@ -264,6 +270,9 @@ static int config_input(AVFilterLink *inlink)
> >      select->var_values[VAR_CONSUMED_SAMPLES_N] = NAN;
> >      select->var_values[VAR_SAMPLES_N]          = NAN;
> >
> > +    select->var_values[VAR_IH] = inlink->h;
> > +    select->var_values[VAR_IW] = inlink->w;
>
> Initial valaues should be NAN. This may well be an audio filter, when
> ih/iw is not available.
>
> > +
> >      select->var_values[VAR_SAMPLE_RATE] =
> >          inlink->type == AVMEDIA_TYPE_AUDIO ? inlink->sample_rate : NAN;
> >
> > @@ -371,6 +380,9 @@ FF_ENABLE_DEPRECATION_WARNINGS
> >          break;
> >      }
> >
> > +    select->var_values[VAR_IH] = frame->height;
> > +    select->var_values[VAR_IW] = frame->width;
>
> You shold only set these for the VIDEO case.
>
> > +
> >      select->select = res = av_expr_eval(select->expr, select->var_values, NULL);
> >      av_log(inlink->dst, AV_LOG_DEBUG,
> >             "n:%f pts:%f t:%f key:%d",
> > @@ -546,3 +558,4 @@ const AVFilter ff_vf_select = {
> >      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS | AVFILTER_FLAG_METADATA_ONLY,
> >  };
> >  #endif /* CONFIG_SELECT_FILTER */
> > +
>
> Extra added line.
>
> > --
> > 2.43.0.windows.1
>
> Documentation update missing.
Sir, I have made the changes as per your suggestions:

1)Initial values are now set to NaN.
2)Values are only set for the VIDEO case.
3)Documentation has been updated to reflect these changes accurately.
I have attached the patch with the updated code for your review.

> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[-- Attachment #2: v2-0001-avfilter-f_select.c-add-support-for-iw-and-ih-con.patch --]
[-- Type: application/octet-stream, Size: 2408 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Poorva]

[-- Attachment #1: Type: text/plain, Size: 3928 bytes --]

>

On Mon, Mar 18, 2024 at 10:34 PM Poorva <2003gaikarpoorva@gmail.com> wrote:
>
> >
>
> On Sun, Mar 17, 2024 at 12:26 AM Marton Balint <cus@passwd.hu> wrote:
> >
> >
> >
> > On Sun, 17 Mar 2024, Poorva wrote:
> >
> > > On Mon, Mar 11, 2024 at 1:10 AM Leo Izen <leo.izen@gmail.com> wrote:
> > >>
> > >> On 3/9/24 15:49, Poorva wrote:
> > >>> I have attached the git patch containing the changes for your review.
> > >>>
> > >>> This patch is submitted as part of my qualification task for Google Summer
> > >>> of Code (GSoC)
> > >>>
> > >>
> > >> Your editor appears to have stripped the newline at the end of the file.
> >
> > > diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
> > > index 9b330a0673..965f5a0b54 100644
> > > --- a/libavfilter/f_select.c
> > > +++ b/libavfilter/f_select.c
> > > @@ -90,6 +90,9 @@ static const char *const var_names[] = {
> > >
> > >      "concatdec_select",  ///< frame is within the interval set by the concat demuxer
> > >
> > > +    "ih",                ///< ih: Represents the height of the input video frame.
> > > +    "iw",                ///< iw: Represents the width of the input video frame.
> > > +
> > >      NULL
> > >  };
> > >
> > > @@ -144,6 +147,9 @@ enum var_name {
> > >
> > >      VAR_CONCATDEC_SELECT,
> > >
> > > +    VAR_IH,
> > > +    VAR_IW,
> > > +
> > >      VAR_VARS_NB
> > >  };
> > >
> > > @@ -264,6 +270,9 @@ static int config_input(AVFilterLink *inlink)
> > >      select->var_values[VAR_CONSUMED_SAMPLES_N] = NAN;
> > >      select->var_values[VAR_SAMPLES_N]          = NAN;
> > >
> > > +    select->var_values[VAR_IH] = inlink->h;
> > > +    select->var_values[VAR_IW] = inlink->w;
> >
> > Initial valaues should be NAN. This may well be an audio filter, when
> > ih/iw is not available.
> >
> > > +
> > >      select->var_values[VAR_SAMPLE_RATE] =
> > >          inlink->type == AVMEDIA_TYPE_AUDIO ? inlink->sample_rate : NAN;
> > >
> > > @@ -371,6 +380,9 @@ FF_ENABLE_DEPRECATION_WARNINGS
> > >          break;
> > >      }
> > >
> > > +    select->var_values[VAR_IH] = frame->height;
> > > +    select->var_values[VAR_IW] = frame->width;
> >
> > You shold only set these for the VIDEO case.
> >
> > > +
> > >      select->select = res = av_expr_eval(select->expr, select->var_values, NULL);
> > >      av_log(inlink->dst, AV_LOG_DEBUG,
> > >             "n:%f pts:%f t:%f key:%d",
> > > @@ -546,3 +558,4 @@ const AVFilter ff_vf_select = {
> > >      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS | AVFILTER_FLAG_METADATA_ONLY,
> > >  };
> > >  #endif /* CONFIG_SELECT_FILTER */
> > > +
> >
> > Extra added line.
> >
> > > --
> > > 2.43.0.windows.1
> >
> > Documentation update missing.
> Sir, I have made the changes as per your suggestions:
>
> 1)Initial values are now set to NaN.
> 2)Values are only set for the VIDEO case.
> 3)Documentation has been updated to reflect these changes accurately.
> I have attached the patch with the updated code for your review.
>
  I wanted to follow up on a patch I submitted earlier and provide an
update based on the feedback received.

Changes made in the update were:

1)Initial values are now set to NaN.
2)Values are only set for the VIDEO case.
3)Documentation has been updated to reflect these changes accurately.
Despite the changes made, I have not received any further feedback or
comments on the patch. Therefore, I kindly request the community to
review the updated patch attached to this email.

Your feedback and suggestions are highly valuable and appreciated.
>
> > Regards,
> > Marton
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[-- Attachment #2: v2-0001-avfilter-f_select.c-add-support-for-iw-and-ih-con.patch --]
[-- Type: application/octet-stream, Size: 2408 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Marton Balint]

On Sun, 24 Mar 2024, Poorva wrote:

> From 0874a55ad33bb4df2789cbafc5247c0ae3d97e6a Mon Sep 17 00:00:00 2001
> From: PoorvaGaikar <pbgaikar_b21@el.vjti.ac.in>
> Date: Sat, 9 Mar 2024 00:27:25 +0530
> Subject: [PATCH v2] avfilter/f_select.c: add support for iw and ih constants

You should mention the fixed ticket number in the commit message.

> 
> ---
>  doc/filters.texi       |  6 ++++++
>  libavfilter/f_select.c | 14 ++++++++++++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 913365671d..e73dc9c1bf 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -30737,6 +30737,12 @@ missing.
>  That basically means that an input frame is selected if its pts is within the
>  interval set by the concat demuxer.
> 
> +@item iw @emph{(video only)}
> +Represents the width of the input video frame
> +
> +@item ih @emph{(video only)}
> +Represents the height of the input video frame
> +
>  @end table
>
>  The default value of the select expression is "1".
> diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
> index 9b330a0673..ccfe915ee1 100644
> --- a/libavfilter/f_select.c
> +++ b/libavfilter/f_select.c
> @@ -90,6 +90,9 @@ static const char *const var_names[] = {
>
>      "concatdec_select",  ///< frame is within the interval set by the concat demuxer
> 
> +    "ih",                ///< ih: Represents the height of the input video frame.
> +    "iw",                ///< iw: Represents the width of the input video frame.
> +
>      NULL
>  };
> 
> @@ -144,6 +147,9 @@ enum var_name {
>
>      VAR_CONCATDEC_SELECT,
> 
> +    VAR_IH,
> +    VAR_IW,
> +
>      VAR_VARS_NB
>  };
> 
> @@ -264,6 +270,9 @@ static int config_input(AVFilterLink *inlink)
>      select->var_values[VAR_CONSUMED_SAMPLES_N] = NAN;
>      select->var_values[VAR_SAMPLES_N]          = NAN;
> 
> +    select->var_values[VAR_IH] = NAN;
> +    select->var_values[VAR_IW] = NAN;
> +
>      select->var_values[VAR_SAMPLE_RATE] =
>          inlink->type == AVMEDIA_TYPE_AUDIO ? inlink->sample_rate : NAN;
> 
> @@ -370,6 +379,10 @@ FF_ENABLE_DEPRECATION_WARNINGS
>          }
>          break;
>      }
> +    if (inlink->type == AVMEDIA_TYPE_VIDEO){
> +        select->var_values[VAR_IH] = frame->height;
> +        select->var_values[VAR_IW] = frame->width;
> +    }

There is a switch(inlink->type) just above this, so you should put these 
there to the corresponding case AVMEDIA_TYPE_VIDEO, and not create a new 
block.

>
>      select->select = res = av_expr_eval(select->expr, select->var_values, NULL);
>      av_log(inlink->dst, AV_LOG_DEBUG,
> @@ -546,3 +559,4 @@ const AVFilter ff_vf_select = {
>      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS | AVFILTER_FLAG_METADATA_ONLY,
>  };
>  #endif /* CONFIG_SELECT_FILTER */
> +

This is still an uneeded newline.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Poorva]

[-- Attachment #1: Type: text/plain, Size: 3673 bytes --]

>
>
>
On Mon, Mar 25, 2024 at 2:04 AM Marton Balint <cus@passwd.hu> wrote:

>
>
> On Sun, 24 Mar 2024, Poorva wrote:
>
> > From 0874a55ad33bb4df2789cbafc5247c0ae3d97e6a Mon Sep 17 00:00:00 2001
> > From: PoorvaGaikar <pbgaikar_b21@el.vjti.ac.in>
> > Date: Sat, 9 Mar 2024 00:27:25 +0530
> > Subject: [PATCH v2] avfilter/f_select.c: add support for iw and ih
> constants
>
> You should mention the fixed ticket number in the commit message.
>
> >
> > ---
> >  doc/filters.texi       |  6 ++++++
> >  libavfilter/f_select.c | 14 ++++++++++++++
> >  2 files changed, 20 insertions(+)
> >
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index 913365671d..e73dc9c1bf 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -30737,6 +30737,12 @@ missing.
> >  That basically means that an input frame is selected if its pts is
> within the
> >  interval set by the concat demuxer.
> >
> > +@item iw @emph{(video only)}
> > +Represents the width of the input video frame
> > +
> > +@item ih @emph{(video only)}
> > +Represents the height of the input video frame
> > +
> >  @end table
> >
> >  The default value of the select expression is "1".
> > diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
> > index 9b330a0673..ccfe915ee1 100644
> > --- a/libavfilter/f_select.c
> > +++ b/libavfilter/f_select.c
> > @@ -90,6 +90,9 @@ static const char *const var_names[] = {
> >
> >      "concatdec_select",  ///< frame is within the interval set by the
> concat demuxer
> >
> > +    "ih",                ///< ih: Represents the height of the input
> video frame.
> > +    "iw",                ///< iw: Represents the width of the input
> video frame.
> > +
> >      NULL
> >  };
> >
> > @@ -144,6 +147,9 @@ enum var_name {
> >
> >      VAR_CONCATDEC_SELECT,
> >
> > +    VAR_IH,
> > +    VAR_IW,
> > +
> >      VAR_VARS_NB
> >  };
> >
> > @@ -264,6 +270,9 @@ static int config_input(AVFilterLink *inlink)
> >      select->var_values[VAR_CONSUMED_SAMPLES_N] = NAN;
> >      select->var_values[VAR_SAMPLES_N]          = NAN;
> >
> > +    select->var_values[VAR_IH] = NAN;
> > +    select->var_values[VAR_IW] = NAN;
> > +
> >      select->var_values[VAR_SAMPLE_RATE] =
> >          inlink->type == AVMEDIA_TYPE_AUDIO ? inlink->sample_rate : NAN;
> >
> > @@ -370,6 +379,10 @@ FF_ENABLE_DEPRECATION_WARNINGS
> >          }
> >          break;
> >      }
> > +    if (inlink->type == AVMEDIA_TYPE_VIDEO){
> > +        select->var_values[VAR_IH] = frame->height;
> > +        select->var_values[VAR_IW] = frame->width;
> > +    }
>
> There is a switch(inlink->type) just above this, so you should put these
> there to the corresponding case AVMEDIA_TYPE_VIDEO, and not create a new
> block.
>
>
> >      select->select = res = av_expr_eval(select->expr,
> select->var_values, NULL);
> >      av_log(inlink->dst, AV_LOG_DEBUG,
> > @@ -546,3 +559,4 @@ const AVFilter ff_vf_select = {
> >      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS |
> AVFILTER_FLAG_METADATA_ONLY,
> >  };
> >  #endif /* CONFIG_SELECT_FILTER */
> > +
>
> This is still an uneeded newline.
>

Thank you for your feedback on the Git patch I submitted for review.
I have rectified the problem by adding the necessary changes .
The updated patch file is attached for your review.
>
>
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>

[-- Attachment #2: v3-0001-avfilter-f_select.c-add-support-for-iw-and-ih-con.patch --]
[-- Type: application/octet-stream, Size: 2836 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Poorva]

>

On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoorva@gmail.com> wrote:
>>
>>
>
> On Mon, Mar 25, 2024 at 2:04 AM Marton Balint <cus@passwd.hu> wrote:
>>
>>
>>
>> On Sun, 24 Mar 2024, Poorva wrote:
>>
>> > From 0874a55ad33bb4df2789cbafc5247c0ae3d97e6a Mon Sep 17 00:00:00 2001
>> > From: PoorvaGaikar <pbgaikar_b21@el.vjti.ac.in>
>> > Date: Sat, 9 Mar 2024 00:27:25 +0530
>> > Subject: [PATCH v2] avfilter/f_select.c: add support for iw and ih constants
>>
>> You should mention the fixed ticket number in the commit message.
>>
>> >
>> > ---
>> >  doc/filters.texi       |  6 ++++++
>> >  libavfilter/f_select.c | 14 ++++++++++++++
>> >  2 files changed, 20 insertions(+)
>> >
>> > diff --git a/doc/filters.texi b/doc/filters.texi
>> > index 913365671d..e73dc9c1bf 100644
>> > --- a/doc/filters.texi
>> > +++ b/doc/filters.texi
>> > @@ -30737,6 +30737,12 @@ missing.
>> >  That basically means that an input frame is selected if its pts is within the
>> >  interval set by the concat demuxer.
>> >
>> > +@item iw @emph{(video only)}
>> > +Represents the width of the input video frame
>> > +
>> > +@item ih @emph{(video only)}
>> > +Represents the height of the input video frame
>> > +
>> >  @end table
>> >
>> >  The default value of the select expression is "1".
>> > diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c
>> > index 9b330a0673..ccfe915ee1 100644
>> > --- a/libavfilter/f_select.c
>> > +++ b/libavfilter/f_select.c
>> > @@ -90,6 +90,9 @@ static const char *const var_names[] = {
>> >
>> >      "concatdec_select",  ///< frame is within the interval set by the concat demuxer
>> >
>> > +    "ih",                ///< ih: Represents the height of the input video frame.
>> > +    "iw",                ///< iw: Represents the width of the input video frame.
>> > +
>> >      NULL
>> >  };
>> >
>> > @@ -144,6 +147,9 @@ enum var_name {
>> >
>> >      VAR_CONCATDEC_SELECT,
>> >
>> > +    VAR_IH,
>> > +    VAR_IW,
>> > +
>> >      VAR_VARS_NB
>> >  };
>> >
>> > @@ -264,6 +270,9 @@ static int config_input(AVFilterLink *inlink)
>> >      select->var_values[VAR_CONSUMED_SAMPLES_N] = NAN;
>> >      select->var_values[VAR_SAMPLES_N]          = NAN;
>> >
>> > +    select->var_values[VAR_IH] = NAN;
>> > +    select->var_values[VAR_IW] = NAN;
>> > +
>> >      select->var_values[VAR_SAMPLE_RATE] =
>> >          inlink->type == AVMEDIA_TYPE_AUDIO ? inlink->sample_rate : NAN;
>> >
>> > @@ -370,6 +379,10 @@ FF_ENABLE_DEPRECATION_WARNINGS
>> >          }
>> >          break;
>> >      }
>> > +    if (inlink->type == AVMEDIA_TYPE_VIDEO){
>> > +        select->var_values[VAR_IH] = frame->height;
>> > +        select->var_values[VAR_IW] = frame->width;
>> > +    }
>>
>> There is a switch(inlink->type) just above this, so you should put these
>> there to the corresponding case AVMEDIA_TYPE_VIDEO, and not create a new
>> block.
>>
>> >
>> >      select->select = res = av_expr_eval(select->expr, select->var_values, NULL);
>> >      av_log(inlink->dst, AV_LOG_DEBUG,
>> > @@ -546,3 +559,4 @@ const AVFilter ff_vf_select = {
>> >      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS | AVFILTER_FLAG_METADATA_ONLY,
>> >  };
>> >  #endif /* CONFIG_SELECT_FILTER */
>> > +
>>
>> This is still an uneeded newline.
>
>
> Thank you for your feedback on the Git patch I submitted for review.
> I have rectified the problem by adding the necessary changes .
> The updated patch file is attached for your review.
>>
>>
 I wanted to follow up on the patch titled
"v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I
submitted earlier and provide an update based on the feedback
received.

In response to your suggestion about the switch block, I have
integrated the changes into the existing switch block for
AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new
line that was added at the end of the file.

Despite these modifications, I have not received any further feedback
or comments on the patch. Therefore, I kindly request the community to
review the updated patch attached to this email.
>>
>> Regards,
>> Marton
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Marton Balint]

On Fri, 29 Mar 2024, Poorva wrote:

>>
>
> On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoorva@gmail.com> wrote:
>>>
>>>
>>
>>
>> Thank you for your feedback on the Git patch I submitted for review.
>> I have rectified the problem by adding the necessary changes .
>> The updated patch file is attached for your review.
>>>
>>>
> I wanted to follow up on the patch titled
> "v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I
> submitted earlier and provide an update based on the feedback
> received.
>
> In response to your suggestion about the switch block, I have
> integrated the changes into the existing switch block for
> AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new
> line that was added at the end of the file.
>
> Despite these modifications, I have not received any further feedback
> or comments on the patch. Therefore, I kindly request the community to
> review the updated patch attached to this email.

[..]

> @@ -371,6 +383,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
>          break;
>      }
> 
> +
>      select->select = res = av_expr_eval(select->expr, select->var_values, NULL);
>      av_log(inlink->dst, AV_LOG_DEBUG,
>             "n:%f pts:%f t:%f key:%d",
> @@ -545,4 +558,4 @@ const AVFilter ff_vf_select = {
>      FILTER_QUERY_FUNC(query_formats),
>      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS | AVFILTER_FLAG_METADATA_ONLY,
>  };
> -#endif /* CONFIG_SELECT_FILTER */
> +#endif /* CONFIG_SELECT_FILTER */
> \ No newline at end of file
> -- 
> 2.43.0.windows.1
>

These two whitespace changes are still unnecessary. Please check your 
patch before sending.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Poorva]

[-- Attachment #1: Type: text/plain, Size: 2311 bytes --]

>
>
>
On Sun, Mar 31, 2024 at 8:35 PM Marton Balint <cus@passwd.hu> wrote:

>
>
> On Fri, 29 Mar 2024, Poorva wrote:
>
> >>
> >
> > On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoorva@gmail.com>
> wrote:
> >>>
> >>>
> >>
> >>
> >> Thank you for your feedback on the Git patch I submitted for review.
> >> I have rectified the problem by adding the necessary changes .
> >> The updated patch file is attached for your review.
> >>>
> >>>
> > I wanted to follow up on the patch titled
> > "v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I
> > submitted earlier and provide an update based on the feedback
> > received.
> >
> > In response to your suggestion about the switch block, I have
> > integrated the changes into the existing switch block for
> > AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new
> > line that was added at the end of the file.
> >
> > Despite these modifications, I have not received any further feedback
> > or comments on the patch. Therefore, I kindly request the community to
> > review the updated patch attached to this email.
>
> [..]
>
> > @@ -371,6 +383,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
> >          break;
> >      }
> >
> > +
> >      select->select = res = av_expr_eval(select->expr,
> select->var_values, NULL);
> >      av_log(inlink->dst, AV_LOG_DEBUG,
> >             "n:%f pts:%f t:%f key:%d",
> > @@ -545,4 +558,4 @@ const AVFilter ff_vf_select = {
> >      FILTER_QUERY_FUNC(query_formats),
> >      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS |
> AVFILTER_FLAG_METADATA_ONLY,
> >  };
> > -#endif /* CONFIG_SELECT_FILTER */
> > +#endif /* CONFIG_SELECT_FILTER */
> > \ No newline at end of file
> > --
> > 2.43.0.windows.1
> >
>
> These two whitespace changes are still unnecessary. Please check your
> patch before sending.
>
> I did remove all the unnecessary whitespaces ,rest which are present are
to keep the code style .
Patch is attached to this email.

Thanks,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>

[-- Attachment #2: v3-0001-avfilter-f_select.c-add-support-for-iw-and-ih-con.patch --]
[-- Type: application/octet-stream, Size: 2597 bytes --]

[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Marton Balint]

On Mon, 1 Apr 2024, Poorva wrote:

>>
>>
>>
> On Sun, Mar 31, 2024 at 8:35 PM Marton Balint <cus@passwd.hu> wrote:
>
>>
>>
>> On Fri, 29 Mar 2024, Poorva wrote:
>>
>>>>
>>>
>>> On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoorva@gmail.com>
>> wrote:
>>>>>
>>>>>
>>>>
>>>>
>>>> Thank you for your feedback on the Git patch I submitted for review.
>>>> I have rectified the problem by adding the necessary changes .
>>>> The updated patch file is attached for your review.
>>>>>
>>>>>
>>> I wanted to follow up on the patch titled
>>> "v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I
>>> submitted earlier and provide an update based on the feedback
>>> received.
>>>
>>> In response to your suggestion about the switch block, I have
>>> integrated the changes into the existing switch block for
>>> AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new
>>> line that was added at the end of the file.
>>>
>>> Despite these modifications, I have not received any further feedback
>>> or comments on the patch. Therefore, I kindly request the community to
>>> review the updated patch attached to this email.
>>
>> [..]
>>
>>> @@ -371,6 +383,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
>>>          break;
>>>      }
>>>
>>> +
>>>      select->select = res = av_expr_eval(select->expr,
>> select->var_values, NULL);
>>>      av_log(inlink->dst, AV_LOG_DEBUG,
>>>             "n:%f pts:%f t:%f key:%d",
>>> @@ -545,4 +558,4 @@ const AVFilter ff_vf_select = {
>>>      FILTER_QUERY_FUNC(query_formats),
>>>      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS |
>> AVFILTER_FLAG_METADATA_ONLY,
>>>  };
>>> -#endif /* CONFIG_SELECT_FILTER */
>>> +#endif /* CONFIG_SELECT_FILTER */
>>> \ No newline at end of file
>>> --
>>> 2.43.0.windows.1
>>>
>>
>> These two whitespace changes are still unnecessary. Please check your
>> patch before sending.
>>
>> I did remove all the unnecessary whitespaces ,rest which are present are
> to keep the code style .
> Patch is attached to this email.

No, the last hunk still removes a newline.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Poorva]

On Fri, Apr 5, 2024 at 2:08 AM Marton Balint <cus@passwd.hu> wrote:
>
>
>
> On Mon, 1 Apr 2024, Poorva wrote:
>
> >>
> >>
> >>
> > On Sun, Mar 31, 2024 at 8:35 PM Marton Balint <cus@passwd.hu> wrote:
> >
> >>
> >>
> >> On Fri, 29 Mar 2024, Poorva wrote:
> >>
> >>>>
> >>>
> >>> On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoorva@gmail.com>
> >> wrote:
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>> Thank you for your feedback on the Git patch I submitted for review.
> >>>> I have rectified the problem by adding the necessary changes .
> >>>> The updated patch file is attached for your review.
> >>>>>
> >>>>>
> >>> I wanted to follow up on the patch titled
> >>> "v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I
> >>> submitted earlier and provide an update based on the feedback
> >>> received.
> >>>
> >>> In response to your suggestion about the switch block, I have
> >>> integrated the changes into the existing switch block for
> >>> AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new
> >>> line that was added at the end of the file.
> >>>
> >>> Despite these modifications, I have not received any further feedback
> >>> or comments on the patch. Therefore, I kindly request the community to
> >>> review the updated patch attached to this email.
> >>
> >> [..]
> >>
> >>> @@ -371,6 +383,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
> >>>          break;
> >>>      }
> >>>
> >>> +
> >>>      select->select = res = av_expr_eval(select->expr,
> >> select->var_values, NULL);
> >>>      av_log(inlink->dst, AV_LOG_DEBUG,
> >>>             "n:%f pts:%f t:%f key:%d",
> >>> @@ -545,4 +558,4 @@ const AVFilter ff_vf_select = {
> >>>      FILTER_QUERY_FUNC(query_formats),
> >>>      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS |
> >> AVFILTER_FLAG_METADATA_ONLY,
> >>>  };
> >>> -#endif /* CONFIG_SELECT_FILTER */
> >>> +#endif /* CONFIG_SELECT_FILTER */
> >>> \ No newline at end of file
> >>> --
> >>> 2.43.0.windows.1
> >>>
> >>
> >> These two whitespace changes are still unnecessary. Please check your
> >> patch before sending.
> >>
> >> I did remove all the unnecessary whitespaces ,rest which are present are
> > to keep the code style .
> > Patch is attached to this email.
>
> No, the last hunk still removes a newline.
Sir, as far as I know git does that automatically.
>
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Fixes #10509

[Marton Balint]

On Wed, 1 May 2024, Poorva wrote:

> On Fri, Apr 5, 2024 at 2:08 AM Marton Balint <cus@passwd.hu> wrote:
>>
>>
>>
>> On Mon, 1 Apr 2024, Poorva wrote:
>>
>> >>
>> >>
>> >>
>> > On Sun, Mar 31, 2024 at 8:35 PM Marton Balint <cus@passwd.hu> wrote:
>> >
>> >>
>> >>
>> >> On Fri, 29 Mar 2024, Poorva wrote:
>> >>
>> >>>>
>> >>>
>> >>> On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoorva@gmail.com>
>> >> wrote:
>> >>>>>
>> >>>>>
>> >>>>
>> >>>>
>> >>>> Thank you for your feedback on the Git patch I submitted for review.
>> >>>> I have rectified the problem by adding the necessary changes .
>> >>>> The updated patch file is attached for your review.
>> >>>>>
>> >>>>>
>> >>> I wanted to follow up on the patch titled
>> >>> "v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I
>> >>> submitted earlier and provide an update based on the feedback
>> >>> received.
>> >>>
>> >>> In response to your suggestion about the switch block, I have
>> >>> integrated the changes into the existing switch block for
>> >>> AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new
>> >>> line that was added at the end of the file.
>> >>>
>> >>> Despite these modifications, I have not received any further feedback
>> >>> or comments on the patch. Therefore, I kindly request the community to
>> >>> review the updated patch attached to this email.
>> >>
>> >> [..]
>> >>
>> >>> @@ -371,6 +383,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
>> >>>          break;
>> >>>      }
>> >>>
>> >>> +
>> >>>      select->select = res = av_expr_eval(select->expr,
>> >> select->var_values, NULL);
>> >>>      av_log(inlink->dst, AV_LOG_DEBUG,
>> >>>             "n:%f pts:%f t:%f key:%d",
>> >>> @@ -545,4 +558,4 @@ const AVFilter ff_vf_select = {
>> >>>      FILTER_QUERY_FUNC(query_formats),
>> >>>      .flags         = AVFILTER_FLAG_DYNAMIC_OUTPUTS |
>> >> AVFILTER_FLAG_METADATA_ONLY,
>> >>>  };
>> >>> -#endif /* CONFIG_SELECT_FILTER */
>> >>> +#endif /* CONFIG_SELECT_FILTER */
>> >>> \ No newline at end of file
>> >>> --
>> >>> 2.43.0.windows.1
>> >>>
>> >>
>> >> These two whitespace changes are still unnecessary. Please check your
>> >> patch before sending.
>> >>
>> >> I did remove all the unnecessary whitespaces ,rest which are present are
>> > to keep the code style .
>> > Patch is attached to this email.
>>
>> No, the last hunk still removes a newline.
> Sir, as far as I know git does that automatically.

I don't think git does this, maybe your editor?

In any case, I have amended the patch locally, will apply soon.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".