Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Roman Arzumanyan <r.arzumanyan@visionlabs.ai>
To: Timo Rothenpieler <timo@rothenpieler.org>,
	 FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option to use current CUDA context
Date: Tue, 19 Sep 2023 11:18:25 +0300
Message-ID: <CAJZRZVk7koru20zDdu+juqHApUSC56-wTAqdyLwhNwBFLfD-xA@mail.gmail.com> (raw)
In-Reply-To: <CAJZRZVmj-oPYMQ0Ko1BSXj8J5kdCv8J8Mvqix8TsqwY+XTQOhQ@mail.gmail.com>

Hello,
Any updates on this patch?

чт, 14 сент. 2023 г. в 19:52, Roman Arzumanyan <r.arzumanyan@visionlabs.ai>:

> Got it, thanks.
> Please find the patches in attachment.
>
> Just for my own understanding - could you please explain how this magic
> works in the configure script? I mean this section:
>
> if ! disabled ffnvcodec; then
>
>     ffnv_hdr_list="ffnvcodec/nvEncodeAPI.h ffnvcodec/dynlink_cuda.h
> ffnvcodec/dynlink_cuviddec.h ffnvcodec/dynlink_nvcuvid.h"
>
>     check_pkg_config ffnvcodec "ffnvcodec >= 12.1.14.0" "$ffnv_hdr_list"
> "" || \
>
>       check_pkg_config ffnvcodec "ffnvcodec >= 12.0.16.0  ffnvcodec <
> 12.1" "$ffnv_hdr_list" "" || \
>
>       check_pkg_config ffnvcodec "ffnvcodec >= 11.1.5.2 ffnvcodec < 12.0"
> "$ffnv_hdr_list" "" || \
>
>       check_pkg_config ffnvcodec "ffnvcodec >= 11.0.10.2 ffnvcodec <
> 11.1" "$ffnv_hdr_list" "" || \
>
>       check_pkg_config ffnvcodec "ffnvcodec >= 8.1.24.14 ffnvcodec < 8.2"
> "$ffnv_hdr_list" ""
>
> fi
>
>
> To me it looks like any ffnvcodec package of version in range between
> 8.1.24.14 and 12.1.14.0 will pass this check.
>
> чт, 14 сент. 2023 г. в 18:04, Timo Rothenpieler <timo@rothenpieler.org>:
>
>> On 14/09/2023 17:02, Roman Arzumanyan wrote:
>> > Hi Timo,
>> >
>> >  > The usual approach is to rely on the ffnvcodec version.
>> >  > Whenever you need a function from a specific version, bump the
>> > versions in configure to the current version from git master and all
>> the
>> > respective old branches, since that will be the version of the next
>> release.
>> >
>> > Sorry, but I don't understand what to do. Could you please give me a
>> hand?
>> > There's ffnvcodec.pc.in <http://ffnvcodec.pc.in> file where I can bump
>> > the version from 12.1.14.0 to 12.1.14.1
>>
>> Don't bump it. It gets bumped after every release.
>> Just set the versions in configure to the current version from the
>> various branches.
>>
>> > Then I see this check in ffmpeg/configure:
>> >
>> > if ! disabled ffnvcodec; then
>> >
>> > ffnv_hdr_list="ffnvcodec/nvEncodeAPI.h ffnvcodec/dynlink_cuda.h
>> > ffnvcodec/dynlink_cuviddec.h ffnvcodec/dynlink_nvcuvid.h"
>> >
>> > check_pkg_config ffnvcodec "ffnvcodec >= 12.0.16.0" "$ffnv_hdr_list" ""
>> || \
>> >
>> > check_pkg_config ffnvcodec "ffnvcodec >= 11.1.5.2 ffnvcodec < 12.0"
>> > "$ffnv_hdr_list" "" || \
>> >
>> > check_pkg_config ffnvcodec "ffnvcodec >= 11.0.10.2 ffnvcodec < 11.1"
>> > "$ffnv_hdr_list" "" || \
>> >
>> > check_pkg_config ffnvcodec "ffnvcodec >= 8.1.24.14 ffnvcodec < 8.2"
>> > "$ffnv_hdr_list" ""
>> >
>> > fi
>> >
>> >
>> > Under the hood it adds cflags detected by pkg-config via
>> > check_pkg_config function. But in the ffnvcodec.pc we don't export any
>> > extra cflags.
>> >
>> > Do I have to add extra flags to ffnvcodec.pc.in
>> > <http://ffnvcodec.pc.in>to define symbols containing the full
>> > ffnvcodecpackage version?
>> >
>> > Like NVENC_API_MAJOR_VERSIONand NVENC_API_MINORversion but for the
>> whole
>> > ffnvcodec package?
>>
>> If configure depends on the latest versions, there is no need for
>> further checks.
>>
>
>
> --
> --
> С уважением, Роман Арзуманян.
> Главный разработчик по направлению видео аналитики.
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-09-19  8:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  7:26 Roman Arzumanyan
2023-09-14 10:00 ` Timo Rothenpieler
2023-09-14 13:29   ` Roman Arzumanyan
2023-09-14 13:32     ` Timo Rothenpieler
2023-09-14 14:03 ` Anton Khirnov
     [not found]   ` <CAJZRZVm1yM0n5ri-X7FZq1A+X2E1GmpsdDu6hQN5t3wpjbY6=A@mail.gmail.com>
     [not found]     ` <7984201b-83b4-4d51-9d5b-d70e958bf399@rothenpieler.org>
2023-09-14 16:52       ` Roman Arzumanyan
2023-09-14 16:54         ` Timo Rothenpieler
2023-09-19  8:18         ` Roman Arzumanyan [this message]
2023-09-19 12:25           ` Timo Rothenpieler
2023-09-28 17:27         ` Timo Rothenpieler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZRZVk7koru20zDdu+juqHApUSC56-wTAqdyLwhNwBFLfD-xA@mail.gmail.com \
    --to=r.arzumanyan@visionlabs.ai \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=timo@rothenpieler.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git