From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id AB1FB4C194 for ; Fri, 7 Nov 2025 21:20:21 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'Z85LaA7VPkgF/Z1H1WYBefkAT8lqG9xhvgQkfskN3p8=', expected b's/3JDCWKUlTnbrOTPzXBdzRcU2A8ywdCL5UhVlhNGIE=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762550413; h=mime-version : references : in-reply-to : date : message-id : to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=2IoYwQ01VXEQzotrbDBJMT0FGvPKTVipMX7PWepWRkM=; b=y+vXheD753BlbiW1/TODYNCo8d63VQ4WHkjuNkFHdhAZBl1LG+OnPCUwV0vbvR2T8CEcD SaJdArQWQDwhNUuzDThtUzjeMFNSkSuSkV7y4cDY/bCiZlA5BtnVQAItPBX6tXEFN/lq+wB Rhcpsl4+eR+MjutFLOPZZNRtIALtpsZErifCQK1jILY2azJoW38lGNXZYNsllfPK+bkOMs5 aafVsYR8y10+yhtW6VvIs5ZpEY0jYdb7mzXakWpLf4XkTBEeA0hCz1BDZw0zbRMpvUcZck6 KKZTnZqq39/rRrhGWNzEkINoYnberrhZzTdid5YAiTX0ICaHghhl5cNqK2/g== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 35FCB68FB83; Fri, 7 Nov 2025 23:20:13 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762550395; b=DSmA/tWfYIliN6Za6dwirBRDoxDLgtoIrrLQEmhljZhXF5iAkni3nxWMmAV3bXMksvr3H j6RSiBTI+ZHuqjqicAUykr/fEw95nwJjpZ/tg+seM2CBVHn40PkxyaRY3BiUx4ZGU+8p9p7 QMV2Myyes6PnalNFXxX4lKhIFOeVpQIPusxtX3lmLAywdQn+1GaDuklUfFdsO/Ky8V0Ke5O 3+Oz3YXZSW0BMS86eHbpUnzZL8Ok5zVDa+OO1mku0VSscmRXEcbSz0rAcqqqghjZOQzuV+9 jKAxYqeyuLHO5ssRNkigYcdY+nP+1EKXeAA3sjU5kt8pEuWwmy7tULQRAXfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762550395; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Z85LaA7VPkgF/Z1H1WYBefkAT8lqG9xhvgQkfskN3p8=; b=iyvFqfvfSsBhPOFbblIHojKi2I8bI13vc9z7VH2x78uexN3g+DbkH9csgDzF40jpWCYc2 MEuS6DoP2FZHVjisQUfEssuQR5Sx0e2Za7TZggeyzK5QvStRfI8gq9WXLpuct4PHaSEaoEc PROQ11bg5aoogPzLKLJyjFgX+fEqITpJhOYvpX68/I9ao/ke0+XE5aM4nrb7cmzkINNzMro 8GRJ9k+TiBupBdYcX9tvG+0gps5GYfVXOaTHPOLjr2/wwhf+rbfznvCAIdPnXqDFcVFUmOs F7PE0+TUf0i11r+mglXha6TdJ5HiRPRL2WjWyoDt87uIG7smUWKb2UrzA5Hw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id C5A7D68B606 for ; Fri, 7 Nov 2025 23:19:40 +0200 (EET) Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-65698036968so626324eaf.2 for ; Fri, 07 Nov 2025 13:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762550379; x=1763155179; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s/3JDCWKUlTnbrOTPzXBdzRcU2A8ywdCL5UhVlhNGIE=; b=D0Sg+hmAmTy9hDD0ZA73q0lp6lB3c81ja6aHQeOJZt/qvvKuRDtp1tK8nA9Xi6jzt4 Exv5D+uX1j0vvRlnVlltIyLEONmWpAJ+MBeXiC45Xzux6j1DYaF19P5s5lqzdpKst1DY zTPszil+Jlx/1JVLBeh5WR3jg7OZy+iyghK/uf8y19XsT8QzQKhkvJLUbAlx2a+3EvtV jmPhFvN7rQK+uv8uSNEG8uuiY468VtzETL9SqZJE+5ScDr04wEWQZo2Awa8tW7vBPVrE oW8Cz1wM3i+YFwyuZxKSC8SAZMlPBmv9XkmPsdMFqtPjJ5I0fQj/NcAF5HVpjE2pzddr 8iGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762550379; x=1763155179; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s/3JDCWKUlTnbrOTPzXBdzRcU2A8ywdCL5UhVlhNGIE=; b=snU2j/41JuOVkirwIb4+1NGflmWq9WykkdMncXicYswHjYBGBedrHoMFh+20dBWKYF EtizxDbTP0qib47Q/uNV0VrOIKnBrsAaPmWhghgWBQFY4Y8gaPCOycQREwuTM/k8R26R Sei+5sqscBBC3ubU6IyHZNRpNJKb3LFGH1S93TdyMO5bFX186N7Qr+Kty7lw/ZOxEkUi /xFM1SQMjl30a2wpF/X75r63Yx23la7P3TP2NvfXq2hjruEZJqYDO+mPsE9ggqqzXOsn PscThZc9yiuuKtq1uQiA40MYDd18CTHpvBpTcJEdx+UBltxzJZA5tC+kquxRsb6IWfhI OUrA== X-Gm-Message-State: AOJu0YyNvFq5DYEik+UomXPnnzPMhxr6dORbyjuJnx/hULys0bvFoP0D p2sojL4kjv2MGr2ihcu6z6Fi6x+mhtPBVMvABm/9YaAd5jgOcs0voyMdXdpsskiPFkbj2KFnwfl O2TkP+uvEg1IqRU1xW8jljaV/YCAt3nK9 X-Gm-Gg: ASbGncsF6PNeOxqLdqH5T3aMP0ZYm2Ze93SfaVEutdtG0teAAinde32GesI8sOGtVNe /djGK8BHba8tnmnfonC/u3G62doajTl+tAOl/Z2T/5DkWrNixEWVLxhyrY+nnZ977c6FGj7vBiK 3CghJ5Q7b1CkO6tNx5GN9FakEaqbzCJpRVb5bLLjMJn/6z9GGhkPsiOX8aVI5nDN6FnWHs3t5FB wKAia3j6cEbBiPsTgwu2eAWHzs79s8dRzC8MoySZ5YYp/9qUac9quZcfqufefTMTsNGFVRMIBY5 WMtvaLtlkG4EyKw= X-Google-Smtp-Source: AGHT+IFhyAql8y+buVShy3CagAqruW4d7h6lWehxmwtQ27549gdgDxuK8pqzx95cBiZ8tbhp8R+7vjc9NOr+0cmFsAU= X-Received: by 2002:a05:6820:20d:b0:63d:bc20:a61a with SMTP id 006d021491bc7-656d946c12bmr510605eaf.7.1762550378600; Fri, 07 Nov 2025 13:19:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 7 Nov 2025 22:19:27 +0100 X-Gm-Features: AWmQ_bm5WK4SZceoldi28gmQrnRNK77WBVdIkY-0om9YiCH3GTKdMyTSQc0NYSE Message-ID: To: FFmpeg development discussions and patches Message-ID-Hash: N44BWYSSRHQ2BCS65L6ZUWO4ITPJ6ECB X-Message-ID-Hash: N44BWYSSRHQ2BCS65L6ZUWO4ITPJ6ECB X-MailFrom: SRS0=Px9m=5P=gmail.com=cookieandcream560@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avcodec/rv60dec: add upper bound check for qp List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Reaxx via ffmpeg-devel Cc: Michael Niedermayer , Reaxx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Thanks for reviewing and applying the patch. Apologies for the incorrect commit message , I appreciate you correcting it. Thanks again On Fri, 7 Nov 2025 at 22:14, Michael Niedermayer via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > Hi Reaxx > > On Fri, Nov 07, 2025 at 06:20:38PM +0100, Reaxx via ffmpeg-devel wrote: > > This patch fixes an out-of-bounds read in the RV60 decoder where qp can > > reach 65, exceeding the rv60_qp_to_idx[64] array bounds. The previous fix > > (61cbcaf93f) only covered intra frames. This adds validation at the > source > > for all frame types. > > > rv60dec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > 57b6f4d726a8d8959a14807b0fa1fb162ce7bd74 > /var0001-avcodec-rv60dec-add-upper-bound-check-for-qp.patch > > From c7a4ef1c2d235e73be849028c145949eac6ae9ef Mon Sep 17 00:00:00 2001 > > From: oblivionsage > > Date: Fri, 7 Nov 2025 18:08:14 +0100 > > Subject: [PATCH] avcodec/rv60dec: add upper bound check for qp > > > > The quantization parameter (qp) can exceed 63 when the base value > > from frame header (0-63) is combined with the offset from slice data > > (up to +2), resulting in qp=65. This causes out-of-bounds access to > > the rv60_qp_to_idx[64] array in decode_cbp8(), decode_cbp16(), and > > get_c4x4_set(). > > > > > Previous fix in commit 61cbcaf93f3b2e10124f4c63ce7cd8dad6505fb2 added > validation only for intra > > frames at a later stage. This patch adds validation at the source > > in decode_slice() to prevent invalid qp values for all frame types. > > This is not correct, the current code is not just checking qp in the > intra case > > > > > > Fixes: Out-of-bounds read reported by OSS-Fuzz > (clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5160167345291264) > > This is incorrect, this testcase does not trigger the issue fixed in this > patch > > There is in fact no testcase for the issue this fixes to the best of > my knowledge. > > i will apply this with a corrected commit message > > thx > > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > I have often repented speaking, but never of holding my tongue. > -- Xenocrates > _______________________________________________ > ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org > To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org > _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org