From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 852B84C1A4 for ; Fri, 7 Nov 2025 21:49:56 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'3KPV55mw5CmbQ9xCvG6qyLdFQSQZZ8LcV61nr2Q/qEE=', expected b'qtR7tJJySgs+I9WRnX+9pHjydHeDOOD2mlwB8wLba+c=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762552188; h=mime-version : references : in-reply-to : date : message-id : to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=bvgdqZcg1SRBGSUferxg3Bqjg5zXDGcIghdqlcJbPFo=; b=E6ouBWvOQ5zI0GXAKG+FE6w9GmVGziJetkA+1hn5wmFFjqm98tJH/66tEKgJZwD8GWci6 lFW3F5PlCQ6Zmb+I3vujzKpcyrtlsyhgSPWWyaRSGnv5HHLICxwAG0wY10ZzgZFSS5SXoMq Lz1T4ANjtk1zuf40SWrSR5vk0iegoo67xsUmEqW5T/nr914vZjczwloDm0ZDLQxuMM48SZ+ SxaSwc+1JgG7T9zLsJTFa7x+hc16/P43bQqdRemJjxisJAVZONQz9ZJNwmNc8A698wCykl3 rrZ6sGa5PEdCMPlBDXI2ce9axINomNwOUyqupLjAr9vdAxOkvPWUzWI5qYiA== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id A971468FA7D; Fri, 7 Nov 2025 23:49:48 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762552173; b=BB5Ym9+Qo4DQWNnqSNLol2skYI9efrl9XqorTNuOJzJ5cD6aireXuXlXNPv4bRwyegY+c FvROe74SD89L/VOIglKxp2dM9+SYRbleSTFhNHBoKNq2QYlg+FgxjkCtYViJ2Ijc5P43G5Z H4aZ/aE9dl/kRauVOUXKT/RYhKTF1F6gpYAwN7EuxbASU1/IxcrVaTq5Gkkk6AtUH7L4Num miG5A6FKJOTZuEvM8/LI482HFuKyZ5wPzv5bjBKTkkhp96FmLK6TAonRg7PQ42Zao0rtXtU eMytDpjJVLJsH811gYN3daHUjO6om35Wb7AShj7jaEMkWy7Zbyo6d26AIaAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762552173; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=3KPV55mw5CmbQ9xCvG6qyLdFQSQZZ8LcV61nr2Q/qEE=; b=OiQcbGhfwuHSoCQ/qeBlbYLa7nnW2WTIuHBQxnSuQ5RxWSnqP6HDIkRluMASgvjSGkDH/ 9Lf5J8fdwUxxzAHxF2nEwLUb1ayPnaGoCWF7u0Sdprzu24ScR7+8xORuO3UJCObgSN3SR+f BWsU6HLNDrZatu9BLmgmCK1pRhA+f0ddZOGj8T3FuWBEhflU1l0WvqYo3sGCPrTE22GA0x1 h238/q/kkQVtR3o62NBkcUgp1COy8pePN2e3fdRHsiIs4D5XFbwF5svF+l7MMV78OywMe1G lcKSfA95jJhSV83S9EPAbUcfqp6crGgxf3BveT1V1MJF+C79O9BhJRfJZV8Q== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id F121768E6E1 for ; Fri, 7 Nov 2025 23:49:18 +0200 (EET) Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-656b4881f55so516513eaf.2 for ; Fri, 07 Nov 2025 13:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762552157; x=1763156957; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qtR7tJJySgs+I9WRnX+9pHjydHeDOOD2mlwB8wLba+c=; b=HxDxcT7bh6QuIl8/FG3odpZXeNZYeCl7/ZHFMAQALaDX38KojazuFs7UDBjqeuE4XT UebcuF5MP0g1VLP4CuID0BWtd6CNTAtu1f3YiyESi2SRBYIkqiLFmElXNMJfviFNNXOd KOWcZ5fo5BpUUJW3DIPd2AB1AsSYTAugwaLRvq+l02YED34a6BsN72GNs58Xb+DOyGoR +Te8gmBgnrs5xIv/sSntkDeKN9J0sMF5Qmd7DUaIHNn/8SODjcRwNUXtIfkS2IGMfEGE aDs5ZwFU2KeytkULnBglaMUhZAIRu+kUcnuzj7H3aDoa9YuTOQHxwrlq/OBX4RGVZI/c K0ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762552157; x=1763156957; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qtR7tJJySgs+I9WRnX+9pHjydHeDOOD2mlwB8wLba+c=; b=l/pFru9t8pferRoifFz0i6VLnx2lMEiVnFF1r5nKQFoo53NpEapF4Nldek8OZ7VlM/ TLiYzNjfI8NDF9JIcRaNQv8LFpLoLV6sQJMUWWqO49pBCXMp9TSz+hHcr6WQEtAGIbCy JD0y5Q8VwY0gsxnN5F+Yp8/vk2unqjrGW6EXk4VPhV6dGtNTyMwbHsvBl2EKUJNhwf8E yIi47gct+dpnljCZJgjeammI0kib/oh306B7apUw5bm6LKdGfzAhRUqtLVPLb+umNOfa qvDmSjjCHULlGXhMQ4EInklX6GoHyf+wngio0xR02Jc8M2GSV9fLB+Cs9cMdyYxbK3Ok 604g== X-Gm-Message-State: AOJu0YzBUPVivVuQ32wjT1mpmVaslMWRNsYD0+LOnb4eV2O8svp+i8LS Jkg2hR/mckxfRsFz/QEscXrfg6a3diG8olPopv2jO8mUiWHurlOGHxEXqPnkcL066ZnQZJvJKhg tRNJkBcNbBEmDO3QvrOevJPWa6pDO2r22 X-Gm-Gg: ASbGncttZYfmbc/IHfnQ8jk8rrfLsFCMaUFOwV0gISGsF4W/9QPMqyndEIGiFOzB+Yg bHLSGjE1m0mJMxzFigH8WrZxC6+zN1thjyNo0MT75L49EnWE34NNt7Mi/7r+QN0UtcLHKvFyXzn /3G+ZdJ9h/+waL9Fq3quI+boeGJ99+dqyb9JUrVTogCCGvEFmhC2mdUJj7CUoD7ElmQE4XfAPSw HrovZEk9Ox3sXq8Vae5v8fcpjl6N0g34zzvAO1tkFUYMvF5p9nCmbxyfhiGvwVM8xsZuoHTASgs ZxbRIATWQziq9/Y= X-Google-Smtp-Source: AGHT+IFWoZ4zfk3eGn5cCGgAp/hmXNXIqt0JZ9Aby4RTHc+oHrDi/xez1HalcDNLU/IvFbnwL5P9CKjy34b2SzLqj+Q= X-Received: by 2002:a05:6820:2905:b0:63e:effa:86f5 with SMTP id 006d021491bc7-656d8eb8572mr537734eaf.7.1762552157278; Fri, 07 Nov 2025 13:49:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 7 Nov 2025 22:49:05 +0100 X-Gm-Features: AWmQ_blwkBn9YxnlAv-eravj3iYxsrC0QucxOYrH5K7nCu6loShL00yMalBGKXE Message-ID: To: FFmpeg development discussions and patches Message-ID-Hash: RTH2KMHXR2BV4DCCOJFYVZFDPIDG73QV X-Message-ID-Hash: RTH2KMHXR2BV4DCCOJFYVZFDPIDG73QV X-MailFrom: SRS0=Px9m=5P=gmail.com=cookieandcream560@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avcodec/rv60dec: add upper bound check for qp List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Reaxx via ffmpeg-devel Cc: Michael Niedermayer , Reaxx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Hi Michael, Yes, the commit message LGTM , Thank you for the detailed explanation and for taking the time to review this thoroughly. I appreciate your patience. On Fri, 7 Nov 2025 at 22:39, Michael Niedermayer via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > Hi > > On Fri, Nov 07, 2025 at 10:19:27PM +0100, Reaxx via ffmpeg-devel wrote: > > Thanks for reviewing and applying the patch. Apologies for the incorrect > > commit message , I appreciate you correcting it. Thanks again > > actually, can you check if my commit message is correct before i apply it ? > > commit 3adc44bce403bf0841d7c1a933f2635037a762f8 (HEAD -> master) > Author: oblivionsage > Date: Fri Nov 7 18:08:14 2025 +0100 > > avcodec/rv60dec: add upper bound check for qp > > The quantization parameter (qp) can exceed 63 when the base value > from frame header (0-63) is combined with the offset from slice data > (up to +2), resulting in qp=65. This causes out-of-bounds access to > the rv60_qp_to_idx[64] array in decode_cbp8(), decode_cbp16(), and > get_c4x4_set(). > > Fixes: Out-of-bounds read > Signed-off-by: oblivionsage > > No testsample is available > > This is related to 61cbcaf93f3b2e10124f4c63ce7cd8dad6505fb2 and > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5160167345291264 > which fixed rv60_qp_to_idx[qp + 32] out of array access > These 2 checks are not redundant and neither covers the cases of the > other > > Signed-off-by: Michael Niedermayer > > diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c > index 33728e33a06..b7b4f46512e 100644 > --- a/libavcodec/rv60dec.c > +++ b/libavcodec/rv60dec.c > @@ -2265,7 +2265,7 @@ static int decode_slice(AVCodecContext *avctx, void > *tdata, int cu_y, int thread > ff_thread_progress_await(&s->progress[cu_y - 1], cu_x + 2); > > qp = s->qp + read_qp_offset(&gb, s->qp_off_type); > - if (qp < 0) { > + if (qp < 0 || qp >= 64) { > ret = AVERROR_INVALIDDATA; > break; > > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Complexity theory is the science of finding the exact solution to an > approximation. Benchmarking OTOH is finding an approximation of the exact > _______________________________________________ > ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org > To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org > _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org