From: Viraaj Raulgaonkar <viraajraulgkar@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] avformat/riffdec: change declaration of ff_get_wav_header()
Date: Mon, 3 Feb 2025 07:55:15 +0530
Message-ID: <CAJ--NN6GduQN-6uwCsYgY3WQsDLVwrvN-0gne2MvPiufhF+z8w@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB074465974FA542047AB8B7F38FEA2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On Mon, Feb 3, 2025 at 12:56 AM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Viraaj Raulgaonkar:
> > Change the type of logctx from void* to AVFormatContext*, since all
> > calls to ff_get_wav_header() pass an AVFormatContext* anyway.
>
> This change makes it appear as if it were better to always pass an
> AVFormatContext* in such cases. But it is not so. Better commit message
> would be "This is in preparation for the following commit."
Ok, I'll change the commit message.
Thanks,
Viraaj
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-03 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 10:40 Viraaj Raulgaonkar
2025-02-01 10:40 ` [FFmpeg-devel] [PATCH v4 2/2] avformat/riffdec: warn on invalid sample rate Viraaj Raulgaonkar
2025-02-02 19:26 ` [FFmpeg-devel] [PATCH v4 1/2] avformat/riffdec: change declaration of ff_get_wav_header() Andreas Rheinhardt
2025-02-03 2:25 ` Viraaj Raulgaonkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ--NN6GduQN-6uwCsYgY3WQsDLVwrvN-0gne2MvPiufhF+z8w@mail.gmail.com \
--to=viraajraulgkar@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git