From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1229549744 for ; Sun, 18 Feb 2024 19:45:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A9B668D366; Sun, 18 Feb 2024 21:45:08 +0200 (EET) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B0A4168D26A for ; Sun, 18 Feb 2024 21:45:01 +0200 (EET) Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-68f6cb80004so3030266d6.3 for ; Sun, 18 Feb 2024 11:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708285500; x=1708890300; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=XXhCE5KtTJuo7p3siS8Da9fimo7WmsayRnAHf5q8bCE=; b=H93o0L+W53OComzF2r3nRXYgi6zvU0rHmk7e2TNOWZkv9i3iC680X2XV5+pvfvtCX4 050Q17hSJ+SAfSGiCnOM8sdWTxtnIEFByXF8FYMBzW5cz5PN4/ij328aaVBfbQCq3cAU EImktf4pU3G1LPhY36yfdH7Hl+XWYAkO4How8p7RuW3m4FBaPhLyBqEf8A4eMoQt97Rz 2mhtjHlZo2dbDvE2J0MQlUWaz75mUjmRcDPkU8PViIdVZOIoZqR0n5ZTk7m/EyPey0Wi We/IstDEOYPuMvnbBRV9HFh/EozEYq+WdhHIH3G4/A6QlCvE1LYCKl63VHabnV7pxY4P FOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708285500; x=1708890300; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XXhCE5KtTJuo7p3siS8Da9fimo7WmsayRnAHf5q8bCE=; b=ev+5EE7M0TbDlqM2N+pMFPCiRwVB/42sMZCIENxjhUY4aFefq2ieJ2vhd4zVSaZXsw 28idTzM95E+5rOOM/CigoYBdw8rk25+NiLHg5P0NRYRovmCt1bLs49hgpRrHWcEMpWqk nMZvhUdxo+dxWL5nP3KtjP7uboyn+Rk8DmEb2D1m63j7ScW+moSNng1JjctMD4oZATqb G6mB8zToTYhDmhugJvqeaM8zHSxYwnJJlZL+fS3vGVH7VNdES9+DWM9W1w1h/OwKhd2r C+GEXNxbAulugCmwDVPyWwJQ7hb+046VEuFSkwlyhIIhHFGi5xd+T4jXFRm8oi9BEuPt bQpg== X-Gm-Message-State: AOJu0YzxVYDNkjM34anWd+0iwpq2DJgfO/Pn6SgDTEH361Q9MSU/op93 nfKbxLd4r+lgK7yCSJY4gye2bBlyNBLT2iwyHyPVGDS6NrUJGXuBrTqEQ3cYIDUgHkxM4rZpmqn Rdhw24b7MUKXLY6pJyHVJwybf3ooNVsLbkh0= X-Google-Smtp-Source: AGHT+IFsQUhTFKg9g+8dH6PPujfwX7MkK423c8QQjypbT06VUEk1D+S7sWRXpMoabDR6A8cFmVhISwplbGcPaZ53/Pg= X-Received: by 2002:a05:6214:19c5:b0:68f:37a6:d50f with SMTP id j5-20020a05621419c500b0068f37a6d50fmr10375065qvc.36.1708285500224; Sun, 18 Feb 2024 11:45:00 -0800 (PST) MIME-Version: 1.0 References: <20240218192054.665995-1-chen.stonechen@gmail.com> In-Reply-To: <20240218192054.665995-1-chen.stonechen@gmail.com> From: Stone Chen Date: Sun, 18 Feb 2024 14:44:49 -0500 Message-ID: To: ffmpeg-devel@ffmpeg.org Content-Type: multipart/mixed; boundary="0000000000006ab4cb0611ad368d" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --0000000000006ab4cb0611ad368d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry I think I didn't correctly attach the patch the first time. On Sun, Feb 18, 2024 at 2:21=E2=80=AFPM Stone Chen wrote: > In commit 6c45d34, a line was added that always sets rdiv to 0, overridin= g > any user input. This removes that line allowing user set values for 0rdiv= , > 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294. > > Signed-off-by: Stone Chen > --- > libavfilter/vf_convolution.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c > index bf67f392f6..a00bb2b3c4 100644 > --- a/libavfilter/vf_convolution.c > +++ b/libavfilter/vf_convolution.c > @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) > p =3D orig =3D av_strdup(s->matrix_str[i]); > if (p) { > s->matrix_length[i] =3D 0; > - s->rdiv[i] =3D 0.f; > sum =3D 0.f; > > while (s->matrix_length[i] < 49) { > -- > 2.43.2 > > --0000000000006ab4cb0611ad368d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-rdiv-always-being-set-to-0-in-vf_convolution.c.patch" Content-Disposition: attachment; filename="0001-Fix-rdiv-always-being-set-to-0-in-vf_convolution.c.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lsrx20v40 RnJvbSAzODczNDUwNmMxZjY1MTA2MmUzOGM0ZTEyODFkODA3MGI2ZTRiZGFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdG9uZSBDaGVuIDxjaGVuLnN0b25lY2hlbkBnbWFpbC5jb20+ CkRhdGU6IFN1biwgMTggRmViIDIwMjQgMTM6NDc6MDUgLTA1MDAKU3ViamVjdDogW1BBVENIXSBG aXggcmRpdiBhbHdheXMgYmVpbmcgc2V0IHRvIDAgaW4gdmZfY29udm9sdXRpb24uYwoKSW4gY29t bWl0IDZjNDVkMzQsIGEgbGluZSB3YXMgYWRkZWQgdGhhdCBhbHdheXMgc2V0cyByZGl2IHRvIDAs IG92ZXJyaWRpbmcgYW55IHVzZXIgaW5wdXQuIFRoaXMgcmVtb3ZlcyB0aGF0IGxpbmUgYWxsb3dp bmcgdXNlciBzZXQgdmFsdWVzIGZvciAwcmRpdiwgMXJkaXYsIDJyZGl2LCAzcmRpdiB0byBhcHBs eSBhcyBleHBlY3RlZC4gVGhpcyBmaXhlcyB0aWNrZXQgIzEwMjk0LgotLS0KIGxpYmF2ZmlsdGVy L3ZmX2NvbnZvbHV0aW9uLmMgfCAxIC0KIDEgZmlsZSBjaGFuZ2VkLCAxIGRlbGV0aW9uKC0pCgpk aWZmIC0tZ2l0IGEvbGliYXZmaWx0ZXIvdmZfY29udm9sdXRpb24uYyBiL2xpYmF2ZmlsdGVyL3Zm X2NvbnZvbHV0aW9uLmMKaW5kZXggYmY2N2YzOTJmNi4uYTAwYmIyYjNjNCAxMDA2NDQKLS0tIGEv bGliYXZmaWx0ZXIvdmZfY29udm9sdXRpb24uYworKysgYi9saWJhdmZpbHRlci92Zl9jb252b2x1 dGlvbi5jCkBAIC02NzQsNyArNjc0LDYgQEAgc3RhdGljIGludCBwYXJhbV9pbml0KEFWRmlsdGVy Q29udGV4dCAqY3R4KQogICAgICAgICAgICAgcCA9IG9yaWcgPSBhdl9zdHJkdXAocy0+bWF0cml4 X3N0cltpXSk7CiAgICAgICAgICAgICBpZiAocCkgewogICAgICAgICAgICAgICAgIHMtPm1hdHJp eF9sZW5ndGhbaV0gPSAwOwotICAgICAgICAgICAgICAgIHMtPnJkaXZbaV0gPSAwLmY7CiAgICAg ICAgICAgICAgICAgc3VtID0gMC5mOwogCiAgICAgICAgICAgICAgICAgd2hpbGUgKHMtPm1hdHJp eF9sZW5ndGhbaV0gPCA0OSkgewotLSAKMi40My4yCgo= --0000000000006ab4cb0611ad368d Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --0000000000006ab4cb0611ad368d--