Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c

[Stone Chen <chen.stonechen@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

Sorry I think I didn't correctly attach the patch the first time.

On Sun, Feb 18, 2024 at 2:21 PM Stone Chen <chen.stonechen@gmail.com> wrote:

> In commit 6c45d34, a line was added that always sets rdiv to 0, overriding
> any user input. This removes that line allowing user set values for 0rdiv,
> 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294.
>
> Signed-off-by: Stone Chen <chen.stonechen@gmail.com>
> ---
>  libavfilter/vf_convolution.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c
> index bf67f392f6..a00bb2b3c4 100644
> --- a/libavfilter/vf_convolution.c
> +++ b/libavfilter/vf_convolution.c
> @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx)
>              p = orig = av_strdup(s->matrix_str[i]);
>              if (p) {
>                  s->matrix_length[i] = 0;
> -                s->rdiv[i] = 0.f;
>                  sum = 0.f;
>
>                  while (s->matrix_length[i] < 49) {
> --
> 2.43.2
>
>

[-- Attachment #2: 0001-Fix-rdiv-always-being-set-to-0-in-vf_convolution.c.patch --]
[-- Type: text/x-patch, Size: 1001 bytes --]

From 38734506c1f651062e38c4e1281d8070b6e4bdaf Mon Sep 17 00:00:00 2001
From: Stone Chen <chen.stonechen@gmail.com>
Date: Sun, 18 Feb 2024 13:47:05 -0500
Subject: [PATCH] Fix rdiv always being set to 0 in vf_convolution.c

In commit 6c45d34, a line was added that always sets rdiv to 0, overriding any user input. This removes that line allowing user set values for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294.
---
 libavfilter/vf_convolution.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c
index bf67f392f6..a00bb2b3c4 100644
--- a/libavfilter/vf_convolution.c
+++ b/libavfilter/vf_convolution.c
@@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx)
             p = orig = av_strdup(s->matrix_str[i]);
             if (p) {
                 s->matrix_length[i] = 0;
-                s->rdiv[i] = 0.f;
                 sum = 0.f;
 
                 while (s->matrix_length[i] < 49) {
-- 
2.43.2


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".