From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 138F449972 for ; Sun, 25 Feb 2024 00:02:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6A42968C6D3; Sun, 25 Feb 2024 02:02:40 +0200 (EET) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0FBE368C678 for ; Sun, 25 Feb 2024 02:02:34 +0200 (EET) Received: by mail-ua1-f50.google.com with SMTP id a1e0cc1a2514c-7ce3c7566e0so691666241.1 for ; Sat, 24 Feb 2024 16:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708819352; x=1709424152; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=sqngk/c+K2pQyJ+QTroL/16B8jCV9ujw5d2qoSoVuKo=; b=Cs67d5UL3nrnnJNIXjffLiOLJbQkmb0ry/MhOfne+2oTkQujAxmvm37cHuoZ5bIVgM UCMA/7odEdL/NKJHy/1pa8U1faqvBnBWQBO6/7WZjZDbPmjU85XpVtLQ76Jnj2ed2Ima +RnyR3z8NZ+PO8O1q9t/GiApcH3ZCXOfMyvSLnqIsm/BaDYuAGKpgpWahgNmEEQXFH/i jKDUlf0fUXc4qDs7k7f+j3Q14jbrPhU+5SyAkbEsNfYSq+c13Sve3HO5sXkjb+PIgNRp TMVFaotb+IDhYCquG+7GGv3yC6xio4EbRdaoAWlIeT7XaeLipmyVbFxHv/NASx+3A3Zs RWhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708819352; x=1709424152; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sqngk/c+K2pQyJ+QTroL/16B8jCV9ujw5d2qoSoVuKo=; b=LyL2b5rlECxiaUntl1ugo8Kn3LcKV92nedezhG594jpV4h2iTNkr1EY7G7uXZ5iq75 oQKwl9fipiP2H7cYZUQn2hiP3EQS/zkvWpU+Q8NdoxAb+l6/ALKpIdzZvn3fAWDc/IOW nEVg7s4KPgpvC2pfZtKPlcZqr2NFoCKZR9jhg1/F7TmdG44ku24EPX7xt93IOCcZLj2m IFCNLidx1h730y9jp/ImRcWZoXeOJO2sninG2Wz8JOCIYlR1+2HKRlOYe+ckw6UcCXaZ EI8vl1yhFH9YLE2cQyB60LIaryFohPHQz4vjBDDeeMoB84+rZwrgYCj94dwXcF7ftgDI 9Dww== X-Gm-Message-State: AOJu0Yy743djET3/WyeMEa+rmUJU8iRmHsn/LRSQ5D+JlHujafTZLvL/ pzY1ikOS1xClgFOJnEuZo+uRjqAdhnlh/WiRElhv7j8l3d85+LFrM5zKIVg/aeV1KVl0Im/djOs BWVmqNIRGt4T5SGalhhZHNPvombj5bFs9g9k= X-Google-Smtp-Source: AGHT+IHDVX3UXaaiJ/IvGZE9DJJHdHxMtBswrORxiY2uy7P2yYbH4iUqv9xdKxeLKqUfPvoLJ9eKzj4ZV2yhAjSbmEY= X-Received: by 2002:a1f:ecc2:0:b0:4d1:3fbc:db65 with SMTP id k185-20020a1fecc2000000b004d13fbcdb65mr1549062vkh.11.1708819351908; Sat, 24 Feb 2024 16:02:31 -0800 (PST) MIME-Version: 1.0 References: <3601973235488930945@unknownmsgid> <20240224154928.218662-1-chen.stonechen@gmail.com> <04eb5fce-989f-d06e-cb8e-4efa070520f0@passwd.hu> In-Reply-To: From: Stone Chen Date: Sat, 24 Feb 2024 19:02:20 -0500 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="000000000000767a9006122982c7" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Add float user_rdiv[4] to allow user options to apply correctly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --000000000000767a9006122982c7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 24, 2024 at 6:34=E2=80=AFPM Marton Balint wrote= : > > > On Sat, 24 Feb 2024, Stone Chen wrote: > > > On Sat, Feb 24, 2024 at 3:56=E2=80=AFPM Marton Balint w= rote: > > > >> > >> > >> On Sat, 24 Feb 2024, Stone Chen wrote: > >> > >> > Previously to support dynamic reconfigurations of the matrix string > >> (e.g. 0m), the rdiv values would always be cleared to 0.f, causing the > rdiv > >> to be recalculated based on the new filter. This however had the side > >> effect of always ignoring user specified rdiv values. > >> > > >> > Instead float user_rdiv[0] is added to ConvolutionContext which will > >> store the user specified rdiv values. Then the original rdiv array wil= l > >> store either the user_rdiv or the automatically calculated 1/sum. > >> > > >> > This fixes trac #10294, #10867 > >> > >> Have you tested? > >> > >> Thanks, > >> Marton > >> > > > > > > Hi Marton, > > > > Yes I've tested that > > > > - the original behavior works (automatically calculate rdiv if > user_rdiv > > =3D 0) > > - setting the rdiv value works > > It does not work for me even after applying your patch. > > Regards, > Marton > Hi Marton, Sorry about that, was it with the attached patch in the second email? I had botched my initial patch, I've re-attached the second to this email. If it was, I'll need to investigate further then, would you be able to send me what you did to test? Regards, Stone --000000000000767a9006122982c7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-float-user_rdiv-4-to-allow-user-options-to-apply.patch" Content-Disposition: attachment; filename="0001-Add-float-user_rdiv-4-to-allow-user-options-to-apply.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lt0qqymj0 RnJvbSBkNDg5ZTY2YzdmMWVhOTRlZjMwMjc1OTU2NmVlMmIyMmI3ODk1Yjg2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdG9uZSBDaGVuIDxjaGVuLnN0b25lY2hlbkBnbWFpbC5jb20+ CkRhdGU6IFNhdCwgMjQgRmViIDIwMjQgMTE6MDg6MDIgLTA1MDAKU3ViamVjdDogW1BBVENIXSBB ZGQgZmxvYXQgdXNlcl9yZGl2WzRdIHRvIGFsbG93IHVzZXIgb3B0aW9ucyB0byBhcHBseQogY29y cmVjdGx5CgpQcmV2aW91c2x5IHRvIHN1cHBvcnQgZHluYW1pYyByZWNvbmZpZ3VyYXRpb25zIG9m IHRoZSBtYXRyaXggc3RyaW5nIChlLmcuIDBtKSwgdGhlIHJkaXYgdmFsdWVzIHdvdWxkIGFsd2F5 cyBiZSBjbGVhcmVkIHRvIDAuZiwgY2F1c2luZyB0aGUgcmRpdiB0byBiZSByZWNhbGN1bGF0ZWQg YmFzZWQgb24gdGhlIG5ldyBmaWx0ZXIuIFRoaXMgaG93ZXZlciBoYWQgdGhlIHNpZGUgZWZmZWN0 IG9mIGFsd2F5cyBpZ25vcmluZyB1c2VyIHNwZWNpZmllZCByZGl2IHZhbHVlcy4KCkluc3RlYWQg ZmxvYXQgdXNlcl9yZGl2WzBdIGlzIGFkZGVkIHRvIENvbnZvbHV0aW9uQ29udGV4dCB3aGljaCB3 aWxsIHN0b3JlIHRoZSB1c2VyIHNwZWNpZmllZCByZGl2IHZhbHVlcy4gVGhlbiB0aGUgb3JpZ2lu YWwgcmRpdiBhcnJheSB3aWxsIHN0b3JlIGVpdGhlciB0aGUgdXNlcl9yZGl2IG9yIHRoZSBhdXRv bWF0aWNhbGx5IGNhbGN1bGF0ZWQgMS9zdW0uCgpUaGlzIGZpeGVzIHRyYWMgIzEwMjk0LCAjMTA4 NjcKClNpZ25lZC1vZmYtYnk6IFN0b25lIENoZW4gPGNoZW4uc3RvbmVjaGVuQGdtYWlsLmNvbT4K LS0tCiBsaWJhdmZpbHRlci9jb252b2x1dGlvbi5oICAgIHwgIDMgKystCiBsaWJhdmZpbHRlci92 Zl9jb252b2x1dGlvbi5jIHwgMTAgKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2Vy dGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGliYXZmaWx0ZXIvY29udm9s dXRpb24uaCBiL2xpYmF2ZmlsdGVyL2NvbnZvbHV0aW9uLmgKaW5kZXggZTQ0YmZiNWRhOC4uZWU3 NDc3ZWY4OSAxMDA2NDQKLS0tIGEvbGliYXZmaWx0ZXIvY29udm9sdXRpb24uaAorKysgYi9saWJh dmZpbHRlci9jb252b2x1dGlvbi5oCkBAIC0zNCwxMyArMzQsMTQgQEAgdHlwZWRlZiBzdHJ1Y3Qg Q29udm9sdXRpb25Db250ZXh0IHsKICAgICBjb25zdCBBVkNsYXNzICpjbGFzczsKIAogICAgIGNo YXIgKm1hdHJpeF9zdHJbNF07Ci0gICAgZmxvYXQgcmRpdls0XTsKKyAgICBmbG9hdCB1c2VyX3Jk aXZbNF07CiAgICAgZmxvYXQgYmlhc1s0XTsKICAgICBpbnQgbW9kZVs0XTsKICAgICBmbG9hdCBz Y2FsZTsKICAgICBmbG9hdCBkZWx0YTsKICAgICBpbnQgcGxhbmVzOwogCisgICAgZmxvYXQgcmRp dls0XTsKICAgICBpbnQgc2l6ZVs0XTsKICAgICBpbnQgZGVwdGg7CiAgICAgaW50IG1heDsKZGlm ZiAtLWdpdCBhL2xpYmF2ZmlsdGVyL3ZmX2NvbnZvbHV0aW9uLmMgYi9saWJhdmZpbHRlci92Zl9j b252b2x1dGlvbi5jCmluZGV4IGJmNjdmMzkyZjYuLjg4Yjg5Mjg5YTkgMTAwNjQ0Ci0tLSBhL2xp YmF2ZmlsdGVyL3ZmX2NvbnZvbHV0aW9uLmMKKysrIGIvbGliYXZmaWx0ZXIvdmZfY29udm9sdXRp b24uYwpAQCAtNDAsMTAgKzQwLDEwIEBAIHN0YXRpYyBjb25zdCBBVk9wdGlvbiBjb252b2x1dGlv bl9vcHRpb25zW10gPSB7CiAgICAgeyAiMW0iLCAic2V0IG1hdHJpeCBmb3IgMm5kIHBsYW5lIiwg T0ZGU0VUKG1hdHJpeF9zdHJbMV0pLCBBVl9PUFRfVFlQRV9TVFJJTkcsIHsuc3RyPSIwIDAgMCAw IDEgMCAwIDAgMCJ9LCAwLCAwLCBGTEFHUyB9LAogICAgIHsgIjJtIiwgInNldCBtYXRyaXggZm9y IDNyZCBwbGFuZSIsIE9GRlNFVChtYXRyaXhfc3RyWzJdKSwgQVZfT1BUX1RZUEVfU1RSSU5HLCB7 LnN0cj0iMCAwIDAgMCAxIDAgMCAwIDAifSwgMCwgMCwgRkxBR1MgfSwKICAgICB7ICIzbSIsICJz ZXQgbWF0cml4IGZvciA0dGggcGxhbmUiLCBPRkZTRVQobWF0cml4X3N0clszXSksIEFWX09QVF9U WVBFX1NUUklORywgey5zdHI9IjAgMCAwIDAgMSAwIDAgMCAwIn0sIDAsIDAsIEZMQUdTIH0sCi0g ICAgeyAiMHJkaXYiLCAic2V0IHJkaXYgZm9yIDFzdCBwbGFuZSIsIE9GRlNFVChyZGl2WzBdKSwg QVZfT1BUX1RZUEVfRkxPQVQsIHsuZGJsPTAuMH0sIDAuMCwgSU5UX01BWCwgRkxBR1N9LAotICAg IHsgIjFyZGl2IiwgInNldCByZGl2IGZvciAybmQgcGxhbmUiLCBPRkZTRVQocmRpdlsxXSksIEFW X09QVF9UWVBFX0ZMT0FULCB7LmRibD0wLjB9LCAwLjAsIElOVF9NQVgsIEZMQUdTfSwKLSAgICB7 ICIycmRpdiIsICJzZXQgcmRpdiBmb3IgM3JkIHBsYW5lIiwgT0ZGU0VUKHJkaXZbMl0pLCBBVl9P UFRfVFlQRV9GTE9BVCwgey5kYmw9MC4wfSwgMC4wLCBJTlRfTUFYLCBGTEFHU30sCi0gICAgeyAi M3JkaXYiLCAic2V0IHJkaXYgZm9yIDR0aCBwbGFuZSIsIE9GRlNFVChyZGl2WzNdKSwgQVZfT1BU X1RZUEVfRkxPQVQsIHsuZGJsPTAuMH0sIDAuMCwgSU5UX01BWCwgRkxBR1N9LAorICAgIHsgIjBy ZGl2IiwgInNldCByZGl2IGZvciAxc3QgcGxhbmUiLCBPRkZTRVQodXNlcl9yZGl2WzBdKSwgQVZf T1BUX1RZUEVfRkxPQVQsIHsuZGJsPTAuMH0sIDAuMCwgSU5UX01BWCwgRkxBR1N9LAorICAgIHsg IjFyZGl2IiwgInNldCByZGl2IGZvciAybmQgcGxhbmUiLCBPRkZTRVQodXNlcl9yZGl2WzFdKSwg QVZfT1BUX1RZUEVfRkxPQVQsIHsuZGJsPTAuMH0sIDAuMCwgSU5UX01BWCwgRkxBR1N9LAorICAg IHsgIjJyZGl2IiwgInNldCByZGl2IGZvciAzcmQgcGxhbmUiLCBPRkZTRVQodXNlcl9yZGl2WzJd KSwgQVZfT1BUX1RZUEVfRkxPQVQsIHsuZGJsPTAuMH0sIDAuMCwgSU5UX01BWCwgRkxBR1N9LAor ICAgIHsgIjNyZGl2IiwgInNldCByZGl2IGZvciA0dGggcGxhbmUiLCBPRkZTRVQodXNlcl9yZGl2 WzNdKSwgQVZfT1BUX1RZUEVfRkxPQVQsIHsuZGJsPTAuMH0sIDAuMCwgSU5UX01BWCwgRkxBR1N9 LAogICAgIHsgIjBiaWFzIiwgInNldCBiaWFzIGZvciAxc3QgcGxhbmUiLCBPRkZTRVQoYmlhc1sw XSksIEFWX09QVF9UWVBFX0ZMT0FULCB7LmRibD0wLjB9LCAwLjAsIElOVF9NQVgsIEZMQUdTfSwK ICAgICB7ICIxYmlhcyIsICJzZXQgYmlhcyBmb3IgMm5kIHBsYW5lIiwgT0ZGU0VUKGJpYXNbMV0p LCBBVl9PUFRfVFlQRV9GTE9BVCwgey5kYmw9MC4wfSwgMC4wLCBJTlRfTUFYLCBGTEFHU30sCiAg ICAgeyAiMmJpYXMiLCAic2V0IGJpYXMgZm9yIDNyZCBwbGFuZSIsIE9GRlNFVChiaWFzWzJdKSwg QVZfT1BUX1RZUEVfRkxPQVQsIHsuZGJsPTAuMH0sIDAuMCwgSU5UX01BWCwgRkxBR1N9LApAQCAt Njc0LDcgKzY3NCw3IEBAIHN0YXRpYyBpbnQgcGFyYW1faW5pdChBVkZpbHRlckNvbnRleHQgKmN0 eCkKICAgICAgICAgICAgIHAgPSBvcmlnID0gYXZfc3RyZHVwKHMtPm1hdHJpeF9zdHJbaV0pOwog ICAgICAgICAgICAgaWYgKHApIHsKICAgICAgICAgICAgICAgICBzLT5tYXRyaXhfbGVuZ3RoW2ld ID0gMDsKLSAgICAgICAgICAgICAgICBzLT5yZGl2W2ldID0gMC5mOworICAgICAgICAgICAgICAg IHMtPnJkaXZbaV0gPSBzLT51c2VyX3JkaXZbaV07CiAgICAgICAgICAgICAgICAgc3VtID0gMC5m OwogCiAgICAgICAgICAgICAgICAgd2hpbGUgKHMtPm1hdHJpeF9sZW5ndGhbaV0gPCA0OSkgewot LSAKMi40My4yCgo= --000000000000767a9006122982c7 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --000000000000767a9006122982c7--