From: Kalev Lember <klember@redhat.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Cosmin Stejerean <cosmin@cosmin.at>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks
Date: Fri, 8 Dec 2023 21:03:39 +0100
Message-ID: <CAHjaNbrHQHr3yKZHyd++5xfmy9OLwoPidHcaHYOq7FK1Dd4m-g@mail.gmail.com> (raw)
In-Reply-To: <0101018c4ad86500-fef4d340-bd76-4ac2-8115-2f6203fd89ff-000000@us-west-2.amazonses.com>
On Fri, Dec 8, 2023 at 8:12 PM Cosmin Stejerean via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:
> As of what version of openh264 though is it safe to assume that ABI won't
> change without soname changes? Since years ago ABI changes without soname
> changes were present there's likely to be some minimum version above which
> runtime version checks are not needed.
>
I don't have a very good answer here, sorry. It was more of a general
observation that upstream is trying to keep the soname updated whenever
there is an ABI change.
However, if I had to pick a version, I did some digging and maybe version
1.3.0 because before that there was just an unversioned libopenh264.so, and
1.3.0 added an actual versioned libopenh264.so.0, which has been updated
since then whenever there have been ABI changes.
Do you guys want me to add a minimum 1.3.0 check?
Martin mentioned earlier that he once envisioned something like passing
-openh264_lib /path/to/my/libopenh264.so to ffmpeg and that must have been
before the versioned soname was introduced.
--
Kalev
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-08 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 8:15 Kalev Lember
2023-12-08 8:39 ` Martin Storsjö
2023-12-08 11:49 ` Kalev Lember
2023-12-08 12:00 ` Martin Storsjö
2023-12-08 12:11 ` Kalev Lember
2023-12-08 12:17 ` Martin Storsjö
2023-12-08 15:48 ` Neal Gompa
2023-12-08 15:58 ` James Almer
2023-12-08 19:07 ` Kalev Lember
2023-12-08 19:12 ` James Almer
[not found] ` <66731BE2-B56B-4F28-80D6-D5599C76CD04@cosmin.at>
2023-12-08 19:12 ` Cosmin Stejerean via ffmpeg-devel
2023-12-08 20:03 ` Kalev Lember [this message]
2023-12-08 20:34 ` Martin Storsjö
2023-12-09 21:03 ` Kalev Lember
2023-12-09 21:07 Kalev Lember
2023-12-18 22:15 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHjaNbrHQHr3yKZHyd++5xfmy9OLwoPidHcaHYOq7FK1Dd4m-g@mail.gmail.com \
--to=klember@redhat.com \
--cc=cosmin@cosmin.at \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git