From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 689B04FBC7 for ; Sat, 28 Jun 2025 03:14:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3309168E285; Sat, 28 Jun 2025 06:14:33 +0300 (EEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1C8C768E14B for ; Sat, 28 Jun 2025 06:14:27 +0300 (EEST) Received: by mail-pj1-f68.google.com with SMTP id 98e67ed59e1d1-3122368d7cfso1797531a91.1 for ; Fri, 27 Jun 2025 20:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751080465; x=1751685265; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=CW8bpOwFwna99KXlVklnyCcKDHmmsLBHjfu6ogZgHcs=; b=az8A+5mLLLHK5t32W96sYxVCHDRC4r3A7gyLwHaDTlyD62r03KFoecIav+NMqNJJoc VENR5XTUlqHQrdGhQbAM6W9ZqqabhVPMfEBMfwy+MHHYQ8vm4heCUUWokZwaS89npbCD fmOxlyKsXsEM4Cx0h9TR7rJTE/HEI9MyNMlhG+3GZ8xX5gVaXsdI6xAB2KPGp4QSsSJd +ipYQII/LwP1BRdHFLgrTJr/ZrB8pv4GV95jylTgxlwYuoSRDGRzWjHwUbE1mRS2GAMF uTVUX1AQwP7H8a/Pbu0EMZw+AieiOXMCgr/NuTaD1FwJLgtoNLlXvtYmH+c/0/KCa0LZ bfIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751080465; x=1751685265; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CW8bpOwFwna99KXlVklnyCcKDHmmsLBHjfu6ogZgHcs=; b=ntzwmOIzss9DPItVDXKGd7VhkrSuz+1OvjiEyPhuWUvasV4dC5GFARdC+sR6ZTh6n1 ekyMp6byoQJZNWWosCAR9rsuB7wSZg9fkjE4dQKPkTF+0R0dTeCvEzjx/0XfW9hY38oT w9oBgiL21gV7Vh084x/TR9QFEkG6JmzHWIekBuRAjjBuGf8TcuGTbD0rj4bXaqencNSt lgeQfKAYEt7+Evb5UcH2l4AYZ0HzCIp8vP3EtxnLNPgxKpq2t9fs1pUqvTy+4Pad15N5 z4xxKgYwdvnh3KQbOgbl0XGMZENOh65gGAGO8SH0N+SEf1harZGPX3ks5q7zVlYK2zPD Q2bA== X-Gm-Message-State: AOJu0YwB9imJou8kTlAnvy44FSHLQ3WfnFG3JsysZP4vvGji8VFKWsxw gVQKbyYLDNzSSOQ4V2nF/DOTEwjBZdclhRcJi9oDgyLzDLSW03V9151RGzC4/URfIJyWKsK6DS9 FmG5+CMEFkEjISHr9+wN3zp7w3DjDLh1mTLVvkK/l9Q== X-Gm-Gg: ASbGnctlDbmLRe50MsuJpO99QaDGiDRkbPPY9DXuqQG3+a6FDMZocvv2frMuwYog0Ep +t7P7TgfstmktbE/sG1oq3x02iB3LulUIgDWEC560M6DpgsMhzdSkQJTjT+G/NAglRqKGDSXgRa bVJ1clI7s/5Okh1ezDl9wk8wI/H2Hcv0tXAGqCI1yXgWIB X-Google-Smtp-Source: AGHT+IHlIojrLbnOROWcZc4SpwALoQ65g1db2QOariKEVyl0v6K4DsnH9Bg4ecjCtU0yS6XGRBQ5N0lfqlxyeHlEjdk= X-Received: by 2002:a17:90b:5348:b0:313:283e:e87c with SMTP id 98e67ed59e1d1-318c9107b3bmr7777617a91.3.1751080464655; Fri, 27 Jun 2025 20:14:24 -0700 (PDT) MIME-Version: 1.0 References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> <20250617141416.950239-3-502024330056@smail.nju.edu.cn> <20250623115530.GD29660@pb2> <20250624210721.GV29660@pb2> <20250627230428.GL29660@pb2> In-Reply-To: <20250627230428.GL29660@pb2> From: Lidong Yan Date: Sat, 28 Jun 2025 11:14:13 +0800 X-Gm-Features: Ac12FXzEovgd41ucYYAtfB5d-XTMT6xHyjtwXsEsQuPy_Kp1h_M3zHLi3NyLKcM Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer wrote: > failure of av_tx_init() with your patch results in a leak: > > ==3653806== 1,260 bytes in 1 blocks are definitely lost in loss record 6 > of 14 > ==3653806== at 0x483E0F0: memalign (in > /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > ==3653806== by 0x483E212: posix_memalign (in > /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > ==3653806== by 0x148AE90: av_malloc (mem.c:107) > ==3653806== by 0x148B2A4: av_mallocz (mem.c:258) > ==3653806== by 0x148B31B: av_calloc (mem.c:269) > ==3653806== by 0x2AD864: make_lpf (asrc_sinc.c:101) > ==3653806== by 0x2AE052: lpf (asrc_sinc.c:183) > ==3653806== by 0x2AEFD4: config_output (asrc_sinc.c:344) > ==3653806== by 0x2DD0C6: ff_filter_config_links (avfilter.c:384) > ==3653806== by 0x2E0FBD: graph_config_links (avfiltergraph.c:255) > ==3653806== by 0x2E4DFA: avfilter_graph_config (avfiltergraph.c:1303) > ==3653806== by 0x297A39: lavfi_read_header (lavfi.c:282) > ==3653806== by 0x667DF2: avformat_open_input (demux.c:309) > ==3653806== by 0x2512DD: ifile_open (ffmpeg_demux.c:1773) > ==3653806== by 0x272B02: open_files (ffmpeg_opt.c:1366) > ==3653806== by 0x272D72: ffmpeg_parse_options (ffmpeg_opt.c:1415) > ==3653806== by 0x292489: main (ffmpeg.c:991) > Sorry about that, I just being stupid. failure of fir_to_phase() would leave the origin memory allocated by lpf() in h[longer] unchanged thus cause a leak. I will replace return ret with goto fail. Thanks, Lidong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".