From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1E3314FA99 for ; Wed, 25 Jun 2025 01:43:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id DD85B68CF06; Wed, 25 Jun 2025 04:43:36 +0300 (EEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3B10968C3EA for ; Wed, 25 Jun 2025 04:43:30 +0300 (EEST) Received: by mail-pg1-f195.google.com with SMTP id 41be03b00d2f7-b1fd59851baso4236466a12.0 for ; Tue, 24 Jun 2025 18:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750815808; x=1751420608; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=g2fDcZjml2xD2SEdevnMNa2fIFUAfE9v48o+tUsuVcw=; b=LYAbumVDW6xrt3wh+0kYVNGl9zjg9RDHAipIFxTIauOpMGOUlD0j6HahbMZkf5sWSs V0leRnEPacN/qw1+c1Xqwronxpu8/u+2AVM+4hB7kA1mEKQONSJBJk2/knElDk7a/bvp k5v3XTHakrV5fZqFM3r7FWz1XLEsKC/vMDi7k7m/u7XxeP7OttHFZ2HmBwneFvDhTufZ PPNdR9u8gpHyM94ry2WQjqV0RdEYMBDlUruYHCVt4ADbropv+5A9ORWvAvwNgHXG+28w InZSvqhNLtaYT2a7RLvFQ9IYIrvYx7vTTWAoo2MeMhEHJTGNNTZ9slkStoGlB9U1awZa In5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750815808; x=1751420608; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g2fDcZjml2xD2SEdevnMNa2fIFUAfE9v48o+tUsuVcw=; b=uzpfToaabpUrcq7qRacJts4Hh7Ez5z7FLQCp6IFti1shtf3sgMaSAyvC43b6gTdi9F MyHpYFK82Xf/2Ooqa3HaezX6QauBv+sILpp60gt4lpcYRyl7wExi4JfgSY+B5y9m98DX XcmBsGu/9yOwv4bal2qS+e5goUs1h86is4lb3jykMDBJyTE0eEFo1G2ojzu1IRbnk75q pntpe9NxSk6cn/0VYXRgnLbsIIAmhOpb1DnZgeHCM24BkHmlNIaAzMIODvZT6PoJArez TVBxIeHvg0dPuIEQM9Ag/EqWtAYcCLEqUE6lIQmjBDHU+xYstrXcbL9YiWbqSZMituKS X67w== X-Gm-Message-State: AOJu0YxbZhm6VfECGcbWdHA8y8XU0jyitrjPpmWxrtGOLNfu8VStK4ZX kRG9War4gDrNqKbxpO2lkAzdu7VXiQHeYVriLu4fv1YdILCRujMbcxfg/wExqUYUHtBLUKVZvxt ZAvR3HzESYEbtMRP0fPuajDODexYtHUO4mA+QNOY= X-Gm-Gg: ASbGncv2dwd/5ZjgL6Jh5cQKDfyqjwfo8vxS/JsOa7RTzPvW4VbReQ2PQZZkGJcAfAZ E5kj5PSElJy1FJQczn90U/MNWRH3IvFrS6r0htk8wl32PZQS6KXgohV+FBVidimva/zBuuuzl+O 38wQmPsA4SLpdepBcj5CqGUD7DqkpZlekqUSPL1wdzL8NKF+wCS2FU X-Google-Smtp-Source: AGHT+IFNywST/A5Q2Rfq/F9YdKtofYEQC4OuUkudeO8CRTiWCkxzVQxpP76IvDWM9rEK4S437+I/azkAryM0KZQWeRU= X-Received: by 2002:a17:903:fad:b0:234:d7b2:2ac5 with SMTP id d9443c01a7336-23823fd1941mr19454695ad.21.1750815808001; Tue, 24 Jun 2025 18:43:28 -0700 (PDT) MIME-Version: 1.0 References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn> <20250617141416.950239-3-502024330056@smail.nju.edu.cn> <20250623115530.GD29660@pb2> <20250624210721.GV29660@pb2> In-Reply-To: <20250624210721.GV29660@pb2> From: ld y Date: Wed, 25 Jun 2025 09:43:14 +0800 X-Gm-Features: AX0GCFv03Ir-PBIhtUmEF11qB9Nh8loig3JefwPOaA21ZRRQPmcJ6gAI9cfs1JI Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer writes: > doesnt the failure path here need the free too ? > int ret = fir_to_phase(s, &h[longer], &n, &post_peak, s->phase); > if (ret < 0) > return ret; > I checked fir_to_phase() and found that the only place it allocates memory in h[longer] is vis *h = av_realloc_f(); If fir_to_phase() failed after this allocations, then *h must be NULL, which implies that av_realloc_f() failed. In that case, we don't need to av_free(h[longer]). However, I still need to double check other allocation site in case we need to free more memory. Thanks, Lidong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".