Re: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input()

From: ld y <yldhome2d2-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/4] avfilter/asrc_sinc: fix leak in config_input()
Date: Wed, 25 Jun 2025 09:43:14 +0800
Message-ID: <CAHiyziOWmT5id458pQMVkLyPLuWFqNa7M-=49wx0HVBPQeHs=g@mail.gmail.com> (raw)
In-Reply-To: <20250624210721.GV29660@pb2>

Michael Niedermayer <michael@niedermayer.cc> writes:

> doesnt the failure path here need the free too ?
>         int ret = fir_to_phase(s, &h[longer], &n, &post_peak, s->phase);
>         if (ret < 0)
>             return ret;
>

I checked fir_to_phase() and found that the only place it allocates memory
in
h[longer] is vis
    *h = av_realloc_f();

If fir_to_phase() failed after this allocations, then *h must be NULL,
which implies that av_realloc_f() failed. In that case, we don't need to
av_free(h[longer]). However, I still need to double check other allocation
site
in case we need to free more memory.

Thanks,
Lidong
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".