Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lidong Yan <yldhome2d2-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/utvideodec: fix leaks in decode_plane() and decode_plane10()
Date: Mon, 30 Jun 2025 09:23:38 +0800
Message-ID: <CAHiyziNdQwxYPzrf02B4UdkMFoBUzwiY+hmv-HSmSx-aW97-VA@mail.gmail.com> (raw)
In-Reply-To: <20250630012036.GB29660@pb2>

Michael Niedermayer <michael@niedermayer.cc> writes:

> This is not correct
>
> build_huff() does not set these when fsym >= 0
>
> your patch runs free() on random uninitialized variables
>
> before submitting memleak fixes, please verify that
> 1. there is actually a leak
> 2. your patch does not introduce a new anomaly
>

Got it, I will be more careful.

Thanks for your review,
Lidong
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-06-30  1:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-29  6:45 [FFmpeg-devel] [PATCH 0/5] fix multiple memory leaks Lidong Yan
2025-06-29  6:45 ` [FFmpeg-devel] [PATCH 1/5] avcodec/utvideodec: fix leaks in decode_plane() and decode_plane10() Lidong Yan
2025-06-30  1:20   ` Michael Niedermayer
2025-06-30  1:23     ` Lidong Yan [this message]
2025-06-29  6:45 ` [FFmpeg-devel] [PATCH 2/5] avformat/rtpdec_latm: fix leak in parse_fmtp_config() Lidong Yan
2025-06-30  1:04   ` Michael Niedermayer
2025-06-29  6:45 ` [FFmpeg-devel] [PATCH 3/5] swscale/graph: fix leak in adapt_colors() Lidong Yan
2025-06-29  6:45 ` [FFmpeg-devel] [PATCH 4/5] avcodec/sunrast: fix leak in sunrast_decode_frame() Lidong Yan
2025-06-30  1:07   ` Michael Niedermayer
2025-06-29  6:45 ` [FFmpeg-devel] [PATCH 5/5] avformat/rtpdec_asf: fix leak in ff_wms_parse_sdp_a_line() Lidong Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHiyziNdQwxYPzrf02B4UdkMFoBUzwiY+hmv-HSmSx-aW97-VA@mail.gmail.com \
    --to=yldhome2d2-at-gmail.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git