From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id B9DA84F7EF
	for <ffmpegdev@gitmailbox.com>; Mon, 23 Jun 2025 12:54:50 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id A9B2F68E1FE;
	Mon, 23 Jun 2025 15:54:44 +0300 (EEST)
Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com
 [209.85.216.68])
 by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BE75A68DE7B
 for <ffmpeg-devel@ffmpeg.org>; Mon, 23 Jun 2025 15:54:37 +0300 (EEST)
Received: by mail-pj1-f68.google.com with SMTP id
 98e67ed59e1d1-3137c2021a0so3080123a91.3
 for <ffmpeg-devel@ffmpeg.org>; Mon, 23 Jun 2025 05:54:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1750683276; x=1751288076; darn=ffmpeg.org;
 h=to:subject:message-id:date:from:in-reply-to:references:mime-version
 :from:to:cc:subject:date:message-id:reply-to;
 bh=6QgIJxMjw0f0d87IqKN/8X1BPUeZmB3XIA1VhIOJyUQ=;
 b=llPm8wcNWAQMd7ZyIb+PzGA+iTSvdpiYpp1NugxjC7dCoNDME79oYnBQ8t7YNxMFj4
 Na/gNKwavoNK3mnbDotH7KXkwAqwAdCVa/Z9flHhWLnxdeGHfRVD9HAA8nmoUvhliOBq
 tkM7swFW7xTqOKupP9JtycwS+GohJvRo6u4Q+OQ0xBI+c0YK4r0LQzI3sWgqtuiaXkcf
 nL2ub8jh+/5ONjldbXd9AEF+CScmucqvdDqxwBm7JVfSydCZdPatn5TJPzBxTJBgImHf
 xFdGveCq9Hu5qyHum3mxhJxHVRpwfBL1JEzaLiy0R+MW9wwJNj3z60PzAKJuvUAg/cQ6
 avpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1750683276; x=1751288076;
 h=to:subject:message-id:date:from:in-reply-to:references:mime-version
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=6QgIJxMjw0f0d87IqKN/8X1BPUeZmB3XIA1VhIOJyUQ=;
 b=p3nLWeCgQsMuJ4m6e4yiJFRiooNlh5LVrVBxqWzq3R61GfzotjWIWEm181sxGj7OBs
 EVBaKoRoJClrVCA2fsczc+T9k/aCrQXTBqVSFOKDKUc3w5itT/aFBBtaB26jXEq3na/B
 6pRLN/icD6YOaehcnFL/172GFYhxgzxvfXCFRC4d0t134x+kSECeiOaDI38yxxFSZNJG
 Yk/Taddrfc5CbcJrR8Z3qIre1rIcYGpjyVzBPMRCcf9QmsHTqOhY4MEn2jkGBjgqdTNy
 03VH0cQMKgeduKPdyd5OJy9i1mN1YgtQnMhcVBoinxpz5TAQmQXqcVqWlE51UmRFuEUC
 EdYg==
X-Gm-Message-State: AOJu0Yz8FTawe1Qa2Um8oCdB40KQt/ADlHAn25CFQRXpGVItX8oH+Enc
 cTGJ4ra1QrNtNkWCDS4UKmllY54iv6a/GN3tdWVG75Uwz3SrOFoSZrNs0rsu0NcRPLxq0njREdV
 zH1p1oYKjM+0Mrm5QqRJyRaueM1qQNkxeOF9gKk7olXMH
X-Gm-Gg: ASbGncvDMx0Amz6mwSs8suzawD581j17XrnvdSfp+RrDVAmraY98uAhOvC3hZsGXx91
 7WfD8N+sFHYjjx3Tkg3FZHtJEJwsvwFQN3OdzEgDdXRkQ+XTghWcXAhwUz/XvKXYzT7AsnYxqw6
 j2/YvTDHQUMhHhzwdjp/S/PVGAEuJ5gpYbmCUA8tDuFQ==
X-Google-Smtp-Source: AGHT+IHQ5EgsBndDCe7PmB13BFFJTajb9p2c+1Itf4AQaTqL9QlhRf+cyuRjholFuNGjIoOlq2jXXrAIUZ55axkIegM=
X-Received: by 2002:a17:90b:3c4f:b0:311:b0d3:865 with SMTP id
 98e67ed59e1d1-3159d8fd0f2mr17693007a91.32.1750683275700; Mon, 23 Jun 2025
 05:54:35 -0700 (PDT)
MIME-Version: 1.0
References: <20250617141416.950239-1-502024330056@smail.nju.edu.cn>
 <20250617141416.950239-5-502024330056@smail.nju.edu.cn>
 <20250623120924.GE29660@pb2>
In-Reply-To: <20250623120924.GE29660@pb2>
From: ld y <yldhome2d2-at-gmail.com@ffmpeg.org>
Date: Mon, 23 Jun 2025 20:54:24 +0800
X-Gm-Features: AX0GCFtOlU1dBdx-hzOlZvPVOcKv39b_7b_ERNU6JBfjM-rJPRjpP0_ZGzMUiow
Message-ID: <CAHiyziM5g=aC4qpk0xSD3EvY-LPZwy-7Gv1simUms+Ock1e7GA@mail.gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH 4/4] avformat/sapenc: fix leak in
 sap_write_header()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/CAHiyziM5g=aC4qpk0xSD3EvY-LPZwy-7Gv1simUms+Ock1e7GA@mail.gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Michael Niedermayer <michael@niedermayer.cc> writes:

> this can be factored like:
>
> like
> +    ret = 0;
>      fail:
> +    for (i = 0; i < s->nb_streams; i++)
> +        if (contexts[i])
> +            av_free(contexts[i]->url);
>     av_free(contexts);
> +   if (ret < 0)
>         sap_write_close(s);
>

Yeah this looks much better. I will use it in my v2 patch.

One more question, would it be ok to rename fail label to end label.
I'm not sure if it's worth the change, though.

Thanks,
Lidong
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".