From: Matt Oliver <protogonoi@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations
Date: Fri, 28 Jul 2023 23:21:56 +1000
Message-ID: <CAHVN4mjHAZco3JSZ5jr-Vqh6bn1MJS9TTvixHkeUkZDDdNBacg@mail.gmail.com> (raw)
In-Reply-To: <ZMOeo2+0yIebe5N7@phare.normalesup.org>
On Fri, 28 Jul 2023 at 20:55, Nicolas George <george@nsup.org> wrote:
> Reimar Döffinger (12023-07-28):
> > I assume the issue is missing symbols during linking?
> > If you really want this, why not create a file that provides dummy
> > symbols for all that are missing, concentrating the #if mess in
> > a single place and avoiding affecting any of the regular code, and thus
> > having no impact at all when compiling with optimizations.
> > Yes, it's likely to be a good bit of maintenance effort for those who
> > want to use it, but at least anyone not caring about this feature can
> > ignore it, so at least I would not have a reason to be against it.
>
> This is an interesting idea. It would even be possible to include a tool
> that generate these stubs directly from the linker's errors, reducing
> the maintenance.
>
> Maybe even make the stubs static inline functions rather than actual
> linking symbols.
>
The issue with dead code elimination and msvc has been raised many times
over the years and the general response has been to not support it. The
last discussion was back in 2016 (
https://ffmpeg.org/pipermail/ffmpeg-devel/2016-December/204530.html) which
apparently was by me.
There was an attempt previously by someone to try and semi-manually add all
the missing symbols using dummy functions but it obviously didnt go
anywhere as if I remember correctly it was difficult to track them all down
for all possible configuration options and maintaining it was just too hard
and it never got completed. I dont have the link but if you crawl through
old mailing list posts it is in there somewhere.
About a decade ago I went the auto generation route and created a tool that
generated Visual Studio projects by scanning ffmpegs make/configure files
and as part of that the tool creates dummy files with all the missing
symbols for the requested configuration options (
https://github.com/ShiftMediaProject/FFVS-Project-Generator). Its not the
most readable code but it does work. Whats potentially more interesting is
over all the years that project has been used the number of dummy dce stubs
has decreased from what used to be there when some of those early attempts
I mentioned were made. However just checking it now shows that there are
still a good 1000 dummy functions created for avcodec alone, although
admittedly theres only about a dozen for all the other libs. So a
pre-processing tool can work nicely, the trick is to be able to get it to
work with different compilers as the command line options and output format
is slightly different and that only gives you the function name you still
need to then scan the code to work out the correct types for the functions
parameters and return types in order to make a dummy stub.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-28 13:22 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 21:59 [FFmpeg-devel] [PATCH 0/4] Fix FFmpeg compilation without DCE L. E. Segovia
2022-11-01 21:59 ` [FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 L. E. Segovia
2022-11-01 22:28 ` Andreas Rheinhardt
2022-11-03 12:55 ` L. E. Segovia
2022-11-03 14:19 ` Andreas Rheinhardt
2022-11-03 21:59 ` Carl Eugen Hoyos
2022-11-01 21:59 ` [FFmpeg-devel] [PATCH 2/4] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO L. E. Segovia
2022-11-02 0:38 ` Andreas Rheinhardt
2022-11-01 21:59 ` [FFmpeg-devel] [PATCH 3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM L. E. Segovia
2022-11-02 0:42 ` Andreas Rheinhardt
2022-11-01 21:59 ` [FFmpeg-devel] [PATCH 4/4] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM L. E. Segovia
2022-11-02 0:26 ` Andreas Rheinhardt
2022-11-02 1:08 ` [FFmpeg-devel] [PATCH 0/4] Fix FFmpeg compilation without DCE Andreas Rheinhardt
2022-11-03 15:30 ` [FFmpeg-devel] [PATCH v2 0/5] " L. E. Segovia
2022-11-03 15:30 ` [FFmpeg-devel] [PATCH v2 1/5] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 L. E. Segovia
2022-11-03 15:30 ` [FFmpeg-devel] [PATCH v2 2/5] avcodec/x86/hevcdsp_init: Fix indentation after the ARCH_FOO changes L. E. Segovia
2022-11-03 15:30 ` [FFmpeg-devel] [PATCH v2 3/5] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO L. E. Segovia
2022-11-03 15:30 ` [FFmpeg-devel] [PATCH v2 4/5] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM L. E. Segovia
2022-11-03 15:30 ` [FFmpeg-devel] [PATCH v2 5/5] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM L. E. Segovia
2022-11-03 15:55 ` Lynne
2022-11-14 9:01 ` L. E. Segovia
2022-11-03 16:36 ` [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE L. E. Segovia
2022-11-03 16:36 ` [FFmpeg-devel] [PATCH v3 1/5] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 L. E. Segovia
2022-11-03 16:36 ` [FFmpeg-devel] [PATCH v3 2/5] avcodec/x86/hevcdsp_init: Fix indentation after the ARCH_FOO changes L. E. Segovia
2022-11-03 16:36 ` [FFmpeg-devel] [PATCH v3 3/5] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO L. E. Segovia
2022-11-03 16:36 ` [FFmpeg-devel] [PATCH v3 4/5] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM L. E. Segovia
2022-11-03 16:36 ` [FFmpeg-devel] [PATCH v3 5/5] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM L. E. Segovia
2022-11-07 14:48 ` [FFmpeg-devel] [PATCH v3 0/5] Fix FFmpeg compilation without DCE L. E. Segovia
2022-11-17 22:45 ` L. E. Segovia
2022-11-26 19:17 ` L. E. Segovia
2022-11-27 15:51 ` Carl Eugen Hoyos
2022-11-27 16:29 ` Soft Works
2022-11-27 16:46 ` Carl Eugen Hoyos
2022-11-27 17:16 ` Soft Works
2022-11-27 17:45 ` Carl Eugen Hoyos
2022-11-27 19:23 ` Soft Works
2022-11-27 17:50 ` Hendrik Leppkes
2022-11-27 18:28 ` Soft Works
2023-07-28 1:37 ` [FFmpeg-devel] [PATCH v4 0/4] Fix MSVC build without optimizations L. E. Segovia
2023-07-28 10:40 ` Reimar Döffinger
2023-07-28 10:48 ` Reimar Döffinger
2023-07-28 10:55 ` Nicolas George
2023-07-28 13:21 ` Matt Oliver [this message]
2023-07-29 18:57 ` L. E. Segovia
2023-07-29 19:07 ` [FFmpeg-devel] [PATCH v5 " L. E. Segovia
[not found] ` <cover.1690657578.git.amy@amyspark.me>
2023-07-29 19:07 ` [FFmpeg-devel] [PATCH v5 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 L. E. Segovia
2023-07-31 18:28 ` Michael Niedermayer
2023-07-29 19:07 ` [FFmpeg-devel] [PATCH v5 2/4] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO L. E. Segovia
2023-07-29 19:07 ` [FFmpeg-devel] [PATCH v5 3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM L. E. Segovia
2023-07-29 19:08 ` [FFmpeg-devel] [PATCH v5 4/4] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM L. E. Segovia
[not found] ` <cover.1690508131.git.amy@amyspark.me>
2023-07-28 1:37 ` [FFmpeg-devel] [PATCH v4 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2 L. E. Segovia
2023-07-28 1:38 ` [FFmpeg-devel] [PATCH v4 2/4] all: Replace if (CONFIG_FOO) checks by #if CONFIG_FOO L. E. Segovia
2023-07-28 1:38 ` [FFmpeg-devel] [PATCH v4 3/4] all: Guard if (INLINE*) checks with #if HAVE_INLINE_ASM L. E. Segovia
2023-07-28 1:38 ` [FFmpeg-devel] [PATCH v4 4/4] all: Guard if (EXTERNAL*) checks with #if HAVE_X86ASM L. E. Segovia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHVN4mjHAZco3JSZ5jr-Vqh6bn1MJS9TTvixHkeUkZDDdNBacg@mail.gmail.com \
--to=protogonoi@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git