From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 00F7240CA2 for ; Thu, 30 Dec 2021 01:45:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 25B6368A7DE; Thu, 30 Dec 2021 03:45:22 +0200 (EET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6177C68A412 for ; Thu, 30 Dec 2021 03:45:15 +0200 (EET) Received: by mail-ed1-f53.google.com with SMTP id q14so84687014edi.3 for ; Wed, 29 Dec 2021 17:45:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=1jXZZ+fn8/Q1ejIQfIM0RAvoLqmKhh9gh9PDX6FgCIw=; b=fVUZq351WjJVtN0d2SP8cKEfhWK4/9OovtiI8W9QLYrb+fbDZhhLCoIaQnXYBRbc6t otnZgt0y88i7RQVmeFdDeCT0WcLsJXCt59/v8c3R1RgZpn4VzM+IbyE0hjIlcn3W1jtL rsvb66dHFE/mzLhVHIMr64PSiAYZwtuohgGSn7exKldGfajYUbJzp1dov9fFW6gOIenB M2fruTuaRGIAZ+5sbb3sCqt7bEfvYWAq2KqxVLC23LT5+61S25F/47fawXxo2g1yImmr qq6+Gu9Em0lA4qoPo1NwPv3q3gNjDrBa8SnEg6ccXejFDT9WqO5hltZAcqZo2TwpbFca +8jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=1jXZZ+fn8/Q1ejIQfIM0RAvoLqmKhh9gh9PDX6FgCIw=; b=0mhzBYfsoD4BRCuTr53pV0MJugof0TdiDzsKEdefdegpYROLZVhHBHnTSYdlDUMGBT /RThgAH+P55Q1pMQw1qI1sUiPQLRgFTXjb4xx0uWaG9KN6yFEz/Nq9G3CbucMSJYAtjG B1PfLmXUOmO3o288/8P4t2+GxQuo6nivtPKIt/qfmyQC/i2I0mKg4QMx2j/JPzLlMxDW ZpCB4BfIHu+rN3pvytTD9DNHzNc0fN51lKqULPrFxgvzYj1PZjlKuGadqOln/ckIXKR4 86FpwdOPinVkjJm6QSXFgcK3JTWouSArSp6yc+FGCK6q+PuCHaY0XJjrzbNpXbh32aAa qmQg== X-Gm-Message-State: AOAM530XFHlvcyqS3HoJ4zeKmFANtrfoYJiB3zYi60iXTFTqKjfLHWNn 6rh7XZ8x+DuzawvASvVy9YviA5zc1jz4knc8PnVcFEHgcC0= X-Google-Smtp-Source: ABdhPJxbfJy/MWFYvuxUUr0tbj0Y6cK1zYCmwUO0RucSHK5vxBL4iEp6t3/D9XdMOcVHhv/FacSGaFv24/74jqwbz/o= X-Received: by 2002:a17:907:3ea8:: with SMTP id hs40mr22977638ejc.353.1640828714145; Wed, 29 Dec 2021 17:45:14 -0800 (PST) MIME-Version: 1.0 References: <20211229123735.GA2829255@pb2> In-Reply-To: <20211229123735.GA2829255@pb2> From: Matt Oliver Date: Thu, 30 Dec 2021 12:45:03 +1100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libx264: Set min build version to 158 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 29 Dec 2021 at 23:37, Michael Niedermayer wrote: > On Wed, Dec 29, 2021 at 05:16:25PM +1100, Matt Oliver wrote: > > Was "[PATCH] libx264: Do not explicitly set X264_API_IMPORTS" > > > > Setting X264_API_IMPORTS only affects msvc builds and it breaks linking > to > > static builds (although is required for shared builds). This flag is set > by > > x264 in its pkgconfig as required since build 158 > > (a615f027ed172e2dd5380e736d487aa858a0c4ff) from July 2019. So this patch > > updates configure to require a newer x264 build that correctly sets the > > imports flag. > > > > Alternatively we can detect the x264 build version in configure and keep > > the fallback of manually setting the flag on older x264 builds that arent > > using pkgconfig (to keep the old behaviour) but that requires some > complex > > configure changes. > > > > Signed-off-by: Matt Oliver > > --- > > configure | 8 +++----- > > libavcodec/libx264.c | 4 ---- > > 2 files changed, 3 insertions(+), 9 deletions(-) > > I think this would effectivly drop ubuntu LTS support which seem to > ship older versions > > thx > As I mentioned in the patch comments, if dropping pre 158 is not suitable then some changes to configure could be made to fallback to old behaviour but I'm not familiar enough with configure to do it. The configure check would then need to be updated to do a pkg_config check if build 158 or newer and if not then fallback to setting X264_API_IMPORTS on the command line. This fallback still wouldnt allow static linking with msvc but that is the current behaviour so it's not changing anything there. So some help on what the correct configure changes should be would be appreciated. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".