From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7A671451FE for ; Sat, 11 Feb 2023 18:10:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4513968BCEC; Sat, 11 Feb 2023 20:10:05 +0200 (EET) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9CBCC68B080 for ; Sat, 11 Feb 2023 20:09:58 +0200 (EET) Received: by mail-ej1-f43.google.com with SMTP id gr7so22996447ejb.5 for ; Sat, 11 Feb 2023 10:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=AnBxT5Ea4ztncKCw47/EQ78P/UdtLZOAHxwdS+8dGHA=; b=OGgUZtzj+60nv/1wOxDZs0OOYdM2HZ+OKeFCbK038LDh+0qoEURZyncyt8XoS9q3SD vUn9VnDBYb2zd2afWLzXWw0kYnormCMOcFS0sRLODvAW0tfCwVSoN3kGrpeHQJjIcx4L LLy+b5oLrP+QAzUozYCjuqzrX4H93VQVPmZ96KpKQa6CHuh1jg9okhMM8qk9qaVARg9a NwcM1bQMe064+kxLQv+GAUtTvbIC1PRVdppWaZcrUm3DJCXbXjUbmHZTKACbKGQP/JsU 3l7exU6A8pFKGobJe3pQYfyoinECPFRYK6CM0Kr8VXzG1LZo71FFxjxh/sPAA0utepdo ycNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AnBxT5Ea4ztncKCw47/EQ78P/UdtLZOAHxwdS+8dGHA=; b=K0b7c/zLtsixT9mxqKcbDTvsMhHt4ARt43ZVbDKZN7I5KEmH7o3+VJjCiFkVUiIbLD MjQ5woaks5ico52FqarBQV/VTrOoTiifwJD0uQLW4gHHdFjos3qxgGc5M6mi45YX3NUj 6+LrV15pgjwGhnU90rUeZRmkVu/1SrZG39/ShNaMQYJABqEaI6v53sP+PHyma/MUOa7u 6Gl1ctnKlgcXdkku5H2XBFKmedIG9YhMk8J6z/Kmoxu4V3fGoAvR765otDPeNrCZwfe5 bYIJKqMVqk7i9NfykNQqzsZGIei6FZ3cDnOMJn8ibkWjF67oUSmtNUoyNSaAGXTRBu50 1zBw== X-Gm-Message-State: AO0yUKV0LTF2ZPGv+3w6/3ynpTEsTsEcwXUnzk4gb2fcWfhGmtvo3itj kBixUa42B7+tCMD5GSS2lGlgvmi5tUYkQawaCyyZwTV3dUo= X-Google-Smtp-Source: AK7set+3SOE9t5p0adapVt8888KRULPhopFuBwMaTUEcB07c+Bd4rbiiRbV445kFNbI80I+WtHnmjXgzAzyTpJfCP7Q= X-Received: by 2002:a17:906:393:b0:8ae:1078:722f with SMTP id b19-20020a170906039300b008ae1078722fmr2663832eja.9.1676138997919; Sat, 11 Feb 2023 10:09:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Matt Oliver Date: Sun, 12 Feb 2023 05:09:44 +1100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 12 Feb 2023 at 04:00, Nicolas George wrote: > Hi. > > Matt Oliver (12023-01-15): > > vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont > > build them. > > Hi > > This sentence seems to be missing a few words. > > Missed a space in there " vf_nlmeans and vf_atadenoise dont contain any code on 32bit x86 so dont build them." > > > > > --- > > libavfilter/x86/Makefile | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile > > index e87481bd7a..9a68b9204b 100644 > > --- a/libavfilter/x86/Makefile > > +++ b/libavfilter/x86/Makefile > > @@ -44,7 +44,9 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD) += > > x86/scene_sad.o > > > > X86ASM-OBJS-$(CONFIG_AFIR_FILTER) += x86/af_afir.o > > X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER) += x86/af_anlmdn.o > > > +ifdef ARCH_X86_64 > > X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER) += x86/vf_atadenoise.o > > +endif > > Do you mean the file is useless yet configure set > CONFIG_ATADENOISE_FILTER? That looks suspicious. > These are the assembly files, so yes the file is completely useless if not compiling for 64bit x86, but CONFIG_ATADENOISE_FILTER is correctly set as we still want to pull in the standard c files. Basically inside these files is a chunk of code inside a ARCH_X86_64 idef so when compiling for a different arch the files end up containing nothing. So apart from just saving some compilation effort not compiling files that dont contain any usable code, this also showed up as an issue under certain circumstances as nasm in win64 would generate output for essentially empty files like these that breaks the msvc linker. This patch also fixes that. > > The same goes for the other place and the other patch. > > > X86ASM-OBJS-$(CONFIG_BLEND_FILTER) += x86/vf_blend.o > > X86ASM-OBJS-$(CONFIG_BWDIF_FILTER) += x86/vf_bwdif.o > > X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER) += x86/colorspacedsp.o > > @@ -62,7 +64,9 @@ X86ASM-OBJS-$(CONFIG_LIMITER_FILTER) += > > x86/vf_limiter.o > > X86ASM-OBJS-$(CONFIG_LUT3D_FILTER) += x86/vf_lut3d.o > > X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER) += x86/vf_maskedclamp.o > > X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER) += x86/vf_maskedmerge.o > > +ifdef ARCH_X86_64 > > X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER) += x86/vf_nlmeans.o > > +endif > > X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER) += x86/vf_overlay.o > > X86ASM-OBJS-$(CONFIG_PP7_FILTER) += x86/vf_pp7.o > > X86ASM-OBJS-$(CONFIG_PSNR_FILTER) += x86/vf_psnr.o > > Regards, > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".