* [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.
@ 2023-01-15 8:08 Matt Oliver
2023-02-11 6:56 ` Matt Oliver
2023-02-11 17:00 ` Nicolas George
0 siblings, 2 replies; 4+ messages in thread
From: Matt Oliver @ 2023-01-15 8:08 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]
vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont
build them.
---
libavfilter/x86/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile
index e87481bd7a..9a68b9204b 100644
--- a/libavfilter/x86/Makefile
+++ b/libavfilter/x86/Makefile
@@ -44,7 +44,9 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD) +=
x86/scene_sad.o
X86ASM-OBJS-$(CONFIG_AFIR_FILTER) += x86/af_afir.o
X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER) += x86/af_anlmdn.o
+ifdef ARCH_X86_64
X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER) += x86/vf_atadenoise.o
+endif
X86ASM-OBJS-$(CONFIG_BLEND_FILTER) += x86/vf_blend.o
X86ASM-OBJS-$(CONFIG_BWDIF_FILTER) += x86/vf_bwdif.o
X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER) += x86/colorspacedsp.o
@@ -62,7 +64,9 @@ X86ASM-OBJS-$(CONFIG_LIMITER_FILTER) +=
x86/vf_limiter.o
X86ASM-OBJS-$(CONFIG_LUT3D_FILTER) += x86/vf_lut3d.o
X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER) += x86/vf_maskedclamp.o
X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER) += x86/vf_maskedmerge.o
+ifdef ARCH_X86_64
X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER) += x86/vf_nlmeans.o
+endif
X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER) += x86/vf_overlay.o
X86ASM-OBJS-$(CONFIG_PP7_FILTER) += x86/vf_pp7.o
X86ASM-OBJS-$(CONFIG_PSNR_FILTER) += x86/vf_psnr.o
--
2.39.0.windows.2
[-- Attachment #2: 0001-lavfi-Makefile-Dont-compile-unused-file.patch --]
[-- Type: application/octet-stream, Size: 1546 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.
2023-01-15 8:08 [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files Matt Oliver
@ 2023-02-11 6:56 ` Matt Oliver
2023-02-11 17:00 ` Nicolas George
1 sibling, 0 replies; 4+ messages in thread
From: Matt Oliver @ 2023-02-11 6:56 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sun, 15 Jan 2023 at 19:08, Matt Oliver <protogonoi@gmail.com> wrote:
> vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont
> build them.
>
> ---
> libavfilter/x86/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile
> index e87481bd7a..9a68b9204b 100644
> --- a/libavfilter/x86/Makefile
> +++ b/libavfilter/x86/Makefile
> @@ -44,7 +44,9 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD) +=
> x86/scene_sad.o
>
> X86ASM-OBJS-$(CONFIG_AFIR_FILTER) += x86/af_afir.o
> X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER) += x86/af_anlmdn.o
> +ifdef ARCH_X86_64
> X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER) += x86/vf_atadenoise.o
> +endif
> X86ASM-OBJS-$(CONFIG_BLEND_FILTER) += x86/vf_blend.o
> X86ASM-OBJS-$(CONFIG_BWDIF_FILTER) += x86/vf_bwdif.o
> X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER) += x86/colorspacedsp.o
> @@ -62,7 +64,9 @@ X86ASM-OBJS-$(CONFIG_LIMITER_FILTER) +=
> x86/vf_limiter.o
> X86ASM-OBJS-$(CONFIG_LUT3D_FILTER) += x86/vf_lut3d.o
> X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER) += x86/vf_maskedclamp.o
> X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER) += x86/vf_maskedmerge.o
> +ifdef ARCH_X86_64
> X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER) += x86/vf_nlmeans.o
> +endif
> X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER) += x86/vf_overlay.o
> X86ASM-OBJS-$(CONFIG_PP7_FILTER) += x86/vf_pp7.o
> X86ASM-OBJS-$(CONFIG_PSNR_FILTER) += x86/vf_psnr.o
> --
> 2.39.0.windows.2
>
bump
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.
2023-01-15 8:08 [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files Matt Oliver
2023-02-11 6:56 ` Matt Oliver
@ 2023-02-11 17:00 ` Nicolas George
2023-02-11 18:09 ` Matt Oliver
1 sibling, 1 reply; 4+ messages in thread
From: Nicolas George @ 2023-02-11 17:00 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1790 bytes --]
Hi.
Matt Oliver (12023-01-15):
> vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont
> build them.
Hi
This sentence seems to be missing a few words.
>
> ---
> libavfilter/x86/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile
> index e87481bd7a..9a68b9204b 100644
> --- a/libavfilter/x86/Makefile
> +++ b/libavfilter/x86/Makefile
> @@ -44,7 +44,9 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD) +=
> x86/scene_sad.o
>
> X86ASM-OBJS-$(CONFIG_AFIR_FILTER) += x86/af_afir.o
> X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER) += x86/af_anlmdn.o
> +ifdef ARCH_X86_64
> X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER) += x86/vf_atadenoise.o
> +endif
Do you mean the file is useless yet configure set
CONFIG_ATADENOISE_FILTER? That looks suspicious.
The same goes for the other place and the other patch.
> X86ASM-OBJS-$(CONFIG_BLEND_FILTER) += x86/vf_blend.o
> X86ASM-OBJS-$(CONFIG_BWDIF_FILTER) += x86/vf_bwdif.o
> X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER) += x86/colorspacedsp.o
> @@ -62,7 +64,9 @@ X86ASM-OBJS-$(CONFIG_LIMITER_FILTER) +=
> x86/vf_limiter.o
> X86ASM-OBJS-$(CONFIG_LUT3D_FILTER) += x86/vf_lut3d.o
> X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER) += x86/vf_maskedclamp.o
> X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER) += x86/vf_maskedmerge.o
> +ifdef ARCH_X86_64
> X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER) += x86/vf_nlmeans.o
> +endif
> X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER) += x86/vf_overlay.o
> X86ASM-OBJS-$(CONFIG_PP7_FILTER) += x86/vf_pp7.o
> X86ASM-OBJS-$(CONFIG_PSNR_FILTER) += x86/vf_psnr.o
Regards,
--
Nicolas George
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files.
2023-02-11 17:00 ` Nicolas George
@ 2023-02-11 18:09 ` Matt Oliver
0 siblings, 0 replies; 4+ messages in thread
From: Matt Oliver @ 2023-02-11 18:09 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sun, 12 Feb 2023 at 04:00, Nicolas George <george@nsup.org> wrote:
> Hi.
>
> Matt Oliver (12023-01-15):
> > vf_nlmeans and vf_atadenoisedont contain any code on 32bit x86 so dont
> > build them.
>
> Hi
>
> This sentence seems to be missing a few words.
>
>
Missed a space in there
" vf_nlmeans and vf_atadenoise dont contain any code on 32bit x86 so dont
build them."
>
> >
> > ---
> > libavfilter/x86/Makefile | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile
> > index e87481bd7a..9a68b9204b 100644
> > --- a/libavfilter/x86/Makefile
> > +++ b/libavfilter/x86/Makefile
> > @@ -44,7 +44,9 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD) +=
> > x86/scene_sad.o
> >
> > X86ASM-OBJS-$(CONFIG_AFIR_FILTER) += x86/af_afir.o
> > X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER) += x86/af_anlmdn.o
>
> > +ifdef ARCH_X86_64
> > X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER) += x86/vf_atadenoise.o
> > +endif
>
> Do you mean the file is useless yet configure set
> CONFIG_ATADENOISE_FILTER? That looks suspicious.
>
These are the assembly files, so yes the file is completely useless if not
compiling for 64bit x86, but CONFIG_ATADENOISE_FILTER is correctly set as
we still want to pull in the standard c files.
Basically inside these files is a chunk of code inside a ARCH_X86_64 idef
so when compiling for a different arch the files end up containing nothing.
So apart from just saving some compilation effort not compiling files that
dont contain any usable code, this also showed up as an issue under certain
circumstances as nasm in win64 would generate output for essentially empty
files like these that breaks the msvc linker. This patch also fixes that.
>
> The same goes for the other place and the other patch.
>
> > X86ASM-OBJS-$(CONFIG_BLEND_FILTER) += x86/vf_blend.o
> > X86ASM-OBJS-$(CONFIG_BWDIF_FILTER) += x86/vf_bwdif.o
> > X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER) += x86/colorspacedsp.o
> > @@ -62,7 +64,9 @@ X86ASM-OBJS-$(CONFIG_LIMITER_FILTER) +=
> > x86/vf_limiter.o
> > X86ASM-OBJS-$(CONFIG_LUT3D_FILTER) += x86/vf_lut3d.o
> > X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER) += x86/vf_maskedclamp.o
> > X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER) += x86/vf_maskedmerge.o
> > +ifdef ARCH_X86_64
> > X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER) += x86/vf_nlmeans.o
> > +endif
> > X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER) += x86/vf_overlay.o
> > X86ASM-OBJS-$(CONFIG_PP7_FILTER) += x86/vf_pp7.o
> > X86ASM-OBJS-$(CONFIG_PSNR_FILTER) += x86/vf_psnr.o
>
> Regards,
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-11 18:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-15 8:08 [FFmpeg-devel] [PATCH 1/2] lavfi/Makefile: Dont compile unused files Matt Oliver
2023-02-11 6:56 ` Matt Oliver
2023-02-11 17:00 ` Nicolas George
2023-02-11 18:09 ` Matt Oliver
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git