From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>,
Devin Heitmueller <devin.heitmueller@ltnglobal.com>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion
Date: Tue, 13 Jun 2023 10:16:27 -0400
Message-ID: <CAHGibzHvDEM0kmMMGvaKUYq0up1h5sxdzTSvNLpafQsqMbT1zA@mail.gmail.com> (raw)
In-Reply-To: <168645575641.3843.17862902192070973710@lain.khirnov.net>
On Sat, Jun 10, 2023 at 11:55 PM Anton Khirnov <anton@khirnov.net> wrote:
> I don't think there's a fundamental reason -r handling could not be
> moved to lavfi, but it's a nontrivial task. E.g. the dup/drop counts are
> integrated with the CLI and would have to be exported from lavfi somehow
> if you wanted to keep that functionality.
I think the big question here in my mind is: does anyone actually
care about the dup/drop counts? I recognize it's a change in behavior
for the application to not show that in the status, but how useful is
it really to know that the app duplicated 50% of your frames because
you put "-r 60000/1001" on the command line?
I could go further in suggesting it's actually misleading, as people
might very well think there is a problem that resulted in frames being
dropped or duplicated, when in fact it's expected behavior if you
specify "-r" on the command-line. Adding to the confusion is the fact
that "-r" and "-vf fps" behave differently in terms of how the status
is shown to the user (even though from a user's standpoint they are
doing the same thing).
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-13 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 13:19 Artem Smorodin
2023-06-09 15:13 ` Devin Heitmueller
2023-06-09 16:33 ` [FFmpeg-devel] [External Sender] " Artem Smorodin
2023-06-13 14:11 ` Devin Heitmueller
2023-06-11 3:55 ` [FFmpeg-devel] " Anton Khirnov
2023-06-13 14:16 ` Devin Heitmueller [this message]
2023-06-13 14:41 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHGibzHvDEM0kmMMGvaKUYq0up1h5sxdzTSvNLpafQsqMbT1zA@mail.gmail.com \
--to=devin.heitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git