From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: Kieran Kunhya <kierank@obe.tv>
Cc: Devin Heitmueller <dheitmueller@ltnglobal.com>,
FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 6/7] v210enc: Pass through bar data
Date: Fri, 30 Jun 2023 20:44:18 -0400
Message-ID: <CAHGibzHR4VfkjuFWSorRGz4Lyw9HGOHF6_s6HEZwOobLD-QwRA@mail.gmail.com> (raw)
In-Reply-To: <CAK+ULv6OBtkSSrSKO+5w4ixF7Nx9znZBV9VGN7_ZfvofKZ356g@mail.gmail.com>
Hi Kieran,
On Fri, Jun 30, 2023 at 6:41 PM Kieran Kunhya <kierank@obe.tv> wrote:
>
> On Fri, 30 Jun 2023 at 21:42, Devin Heitmueller <devin.heitmueller@ltnglobal.com> wrote:
>>
>> When encoding to V210, make sure the bar side data makes it through
>> in the resulting AVPacket. This is needed so the decklink output
>> module can put out bar data as VANC when in 10-bit mode.
>
>
> ff_decode_frame_props_from_pkt surely does this better than the mess of ifs in v210enc?
The ff_decode_frame_props_from_pkt() function is used when going from
AVPackets to AVFrames. The v210enc codec goes in the other direction
- from AVFrames to AVPackets. In fact
ff_decode_frame_props_from_pkt() does get used by v210dec.
Now I wouldn't necessarily be against somebody introducing a new
function which goes in the opposite direction and could potentially be
shared by other encoders. But my intent was just to implement it the
same way as the other conversions were done, not to refactor the code
and design some new approach.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-01 0:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 21:38 [FFmpeg-devel] [PATCH v2 0/7] Misc AFD improvements and support for Bar Data Devin Heitmueller
2023-06-30 21:38 ` [FFmpeg-devel] [PATCH v2 1/7] libavcodec: Preserve AFD side data when going from AVPacket to AVFrame Devin Heitmueller
2023-07-02 17:38 ` Marton Balint
2023-06-30 21:38 ` [FFmpeg-devel] [PATCH v2 2/7] vf_drawtext: Add ability to show AFD value Devin Heitmueller
2023-06-30 21:38 ` [FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data Devin Heitmueller
2023-07-01 8:11 ` Anton Khirnov
2023-07-03 12:51 ` Devin Heitmueller
2023-06-30 21:38 ` [FFmpeg-devel] [PATCH v2 4/7] libavfilter: Add filter to insert AFD/bar data Devin Heitmueller
2023-06-30 21:38 ` [FFmpeg-devel] [PATCH v2 5/7] libavutil: Provide a side data description for newly introduced bar data Devin Heitmueller
2023-06-30 21:38 ` [FFmpeg-devel] [PATCH v2 6/7] v210enc: Pass through " Devin Heitmueller
2023-06-30 22:41 ` Kieran Kunhya
2023-07-01 0:44 ` Devin Heitmueller [this message]
2023-06-30 21:38 ` [FFmpeg-devel] [PATCH v2 7/7] avdevice/decklink_enc: Add support for output of bar data as VANC Devin Heitmueller
2023-07-01 8:14 ` [FFmpeg-devel] [PATCH v2 0/7] Misc AFD improvements and support for Bar Data Anton Khirnov
2023-07-03 13:44 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHGibzHR4VfkjuFWSorRGz4Lyw9HGOHF6_s6HEZwOobLD-QwRA@mail.gmail.com \
--to=devin.heitmueller@ltnglobal.com \
--cc=dheitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=kierank@obe.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git