From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance
Date: Sat, 6 May 2023 07:49:35 -0400
Message-ID: <CAHGibzHLx6fAObrXZH=s923bVk8_YBtyW6p203663JhpGU2p6Q@mail.gmail.com> (raw)
In-Reply-To: <CAM=jba8tfpDhEs+hp1sg35-Q3fGazf9GK=j1WYwJpC5kwEmFpg@mail.gmail.com>
Hi Lance,
On Sat, May 6, 2023 at 7:32 AM Lance Wang <lance.lmwang@gmail.com> wrote:
> FYI, on my development system, I run two time for the original and modified
> version and no obvious difference:
Simply running "time" against the binary isn't an accurate way to
measure a 60ms difference for a single frame being processed. For any
such execution of ffmpeg the bulk of the time is spent loading the
application and in this case loading the 20MB file from disk into
memory.
In my case I added instrumentation to the decoder to measure how much
time it took to perform the actual decode operation. I discarded the
patch already since it was like six lines of code and I did the work
several weeks ago, but if there is really a dispute about the
performance benefit I can obviously recreate it (as can anyone who
wants to benchmark it themselves). You would just have to insert a
couple of calls to gettimeofday() in libavcodec/bitpacked_dec.c before
and after the decoding operation.
This is one of those cases where you won't notice the performance
difference doing any operation once, but it becomes important when
you're processing a live RTP stream of 2160p59 video at 10.4 Gbps.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-06 11:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 21:54 Devin Heitmueller
2023-05-06 11:32 ` Lance Wang
2023-05-06 11:49 ` Devin Heitmueller [this message]
2023-05-06 11:52 ` Paul B Mahol
2023-05-06 12:13 ` Devin Heitmueller
2023-05-06 12:16 ` James Almer
2023-05-06 12:40 ` Devin Heitmueller
2023-05-10 11:16 ` Lance Wang
2023-05-11 22:20 ` Marton Balint
2023-05-12 15:26 ` Devin Heitmueller
2023-12-13 19:58 ` [FFmpeg-devel] [PATCH] avcodec/bitpacked_dec: optimize bitpacked_decode_yuv422p10 Marton Balint
2023-12-28 20:42 ` Marton Balint
2023-06-12 16:05 ` [FFmpeg-devel] [RFC/PATCH] bitpacked_dec: Optimization for bitpacked_dec decoder performance Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGibzHLx6fAObrXZH=s923bVk8_YBtyW6p203663JhpGU2p6Q@mail.gmail.com' \
--to=devin.heitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git