From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: Fix warnings with signed/unsigned compare in bitstream.h
Date: Mon, 27 Mar 2023 09:12:16 -0400
Message-ID: <CAHGibzH+zbMctKeDBgeOTmQXc3j8sMgrAONuxNxyV-i=nntwDw@mail.gmail.com> (raw)
In-Reply-To: <bdbca3a-1e18-de90-c082-259cf93a2467@passwd.hu>
On Sat, Mar 25, 2023 at 1:10 PM Marton Balint <cus@passwd.hu> wrote:
> I am not sure if overread/overwrote is a supported state for these
> functions. As far as I see bytestream2_get_buffer, bytestream2_put_buffer,
> bytestream2_copy_buffer and bytestream2_set_buffer just crashes if
> buffer_end < buffer because sooner or later memcpy/memset gets a negative
> value. There are no special checks to handle it.
This was the conclusion I came to as well. I couldn't imagine a case
where it would ever actually work, since prior to my patch in every
case it results in a call to memcpy() with a negative length argument.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-27 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 15:02 Devin Heitmueller
2023-03-17 15:02 ` [FFmpeg-devel] [PATCH v2 2/2] decklink: Add support for compressed AC-3 output over SDI Devin Heitmueller
2023-03-24 21:07 ` Marton Balint
2023-03-27 16:08 ` Devin Heitmueller
2023-03-25 4:47 ` [FFmpeg-devel] [PATCH v2 1/2] avcodec: Fix warnings with signed/unsigned compare in bitstream.h Andreas Rheinhardt
2023-03-25 17:09 ` Marton Balint
2023-03-27 13:12 ` Devin Heitmueller [this message]
2023-03-27 13:26 ` Andreas Rheinhardt
2023-03-28 19:05 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGibzH+zbMctKeDBgeOTmQXc3j8sMgrAONuxNxyV-i=nntwDw@mail.gmail.com' \
--to=devin.heitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git