From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 993E8460F4 for ; Thu, 2 Nov 2023 14:14:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AEC3368CC7C; Thu, 2 Nov 2023 16:14:47 +0200 (EET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1881F68CAD1 for ; Thu, 2 Nov 2023 16:14:40 +0200 (EET) Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-53b32dca0bfso2029343a12.0 for ; Thu, 02 Nov 2023 07:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ltnglobal-com.20230601.gappssmtp.com; s=20230601; t=1698934478; x=1699539278; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=vo5tO0FQvRqAsGVdqY8bxRVYjoYYmy1Rw5hGZpImOKY=; b=RxyZUVpOg4pEJekF0vWZChIgI8k5syqqlkIeNkJmVf0NrEsWRbejDc2iFRGSHHbZrL Cbsky6zfdcSOJwMVIdjQkrj1onvCanRAT5nFXGnSPN77x6GcvuUYZWoH3aDmUAg29Sap 6hSDZZRvIqTmwQh1om4UDJNUkK7YkuzjkZAJO0b1fNPvKhjnUB/smn/vsp7oeMjfEhzq uQyQ4rQ+JXiYfSDLIK8hnCESefzd6AoO0webeq3TVQyaK26J1T6M10hg7UsaAypUVcr4 WjWRsyRfkVcIU+nGlkflzyfe+XI/ihocHtY3VgY2TO5bZBTq2k9+yw53/kT6TR6III5e OPBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698934478; x=1699539278; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vo5tO0FQvRqAsGVdqY8bxRVYjoYYmy1Rw5hGZpImOKY=; b=QdDWdzBrDP5z1Hqo0sG0VrCH9iTh1g6ZI4Ht9xFqCt+sarn1f2Ke7eFPp9xkSW1D9q HxZXVZMKSbmRSt5Z+WDmQSO5vxKgshBiinDHqcNWrgywnort9nvlzC1lhoI/q+DGT2hi 4c4QWqYoJ/lANdt6jo5P7eZ4VqdHyHj4pOHXzJv50MjsHuYZeoKyFYNsbetB/ruldHRD L6zAOWESPT9n1xT2GAdscGOyMS9dxukBM1/ajKVOxUMhi0KyLRYDY65poO7o3/VTn6Bz SZrK3sG2X88HdqAVETjYTf4LQSD410+zALnviNdbW1qKv1/LMICYBK6i0YmrHlmUIThO 3jlg== X-Gm-Message-State: AOJu0YyEGlA1pg4rdf2UKstd9JwWa+M2oXIfcHAhD6s80gVP1UvL8LpM uz5RaPr32d/KWwSkb+nGZEj6Hi8AeSF2MlYhXP6xZUYdSoqkT0hgF54= X-Google-Smtp-Source: AGHT+IHP9j1tisZ5Lb4bClZuiueItdHvLUvDWHY65cIAPWf0HjyqArKIbAvlsFayVR60DNUP6FTyOjiHGcFmdDTwOhw= X-Received: by 2002:aa7:c711:0:b0:540:16be:6562 with SMTP id i17-20020aa7c711000000b0054016be6562mr5504647edq.15.1698934477930; Thu, 02 Nov 2023 07:14:37 -0700 (PDT) MIME-Version: 1.0 References: <2685f0cc-78f7-4ef7-833a-a56223fa6236@nativewaves.com> In-Reply-To: From: Devin Heitmueller Date: Thu, 2 Nov 2023 10:14:26 -0400 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Michael, I haven't tried your patch, but a quick review suggests that while you've declared the option as deprecated that it no longer works. Presumably somewhere in there should be a line of code that says something like "if (ctx->draw_bars == 0) then ctx->signal_loss_action = SIGNAL_LOSS_NONE" Even though the option is deprecated, it should still continue to work until it is completely removed. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".