From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5D40F459EA for ; Wed, 1 Mar 2023 14:18:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 656BB68A8D2; Wed, 1 Mar 2023 16:18:02 +0200 (EET) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8FB32688353 for ; Wed, 1 Mar 2023 16:17:56 +0200 (EET) Received: by mail-yb1-f182.google.com with SMTP id t4so450945ybg.11 for ; Wed, 01 Mar 2023 06:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ltnglobal-com.20210112.gappssmtp.com; s=20210112; t=1677680275; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=MNvTV4yZFNDAGsCl/Ouf1ZC5yrwThKuwAvv3gaE5Vmg=; b=61vqoOMrjTsY5/CzNc0yu0cf7RD/WJDs5W1qhZUSI0gM0KVmmvFigD7F8f3fEW5hdH zK9hWzlkPtTf5ezLEnM0ucGIUzEkhLLSqfew58ZZFwn40vr2WZWKhcT3iCOWFNXHCnzf fIFWyYZgLAqMsgCi6p9gE2XeY0Q77U8AEUJ+JGcQWlyUAKOH7ogowMRX8UJvd3OgFEUH yywDnxUjSBkkbHTegATBuoQi/c/RS5khPS/UNOs3dBMsiVwoNis4NeDc2Pik72EeebWx yn1WWvdbdYZUUqyT284PNC4R09Y/j6rIP66jmqLUVE5CJAPGf+WOoZoTbv/TrTzK3KwV 5vPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677680275; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MNvTV4yZFNDAGsCl/Ouf1ZC5yrwThKuwAvv3gaE5Vmg=; b=2GOTXf0bdKeRwO9V6Nz9X0PbmHE2clNxz0HuwfiD535ufLc2f7E9xFh7JjQBTTA8/Z NZbnsV8awFq1vPbbaNLnv7H0L9pS/WCbz5iHOSFq/egY/tXeubMqcWOxjSN9bdAIt1mg t+ARU9TMTlGtFHUfbqRRPHo9dAg5RwmDSzt7A4h2SbLfZ8ZN71R4tWGMI2y5xrwtgk3+ MIegjJOweiTRgrSyLtnRdfuZmtPnKjBaBkCN4QS5PpUXiFAqCQ0ZbLCm5LbS6yN85JhX tvkz8pgRnnqTnE41RuhAWPZuyfXattuNUJJ+7qDOJPcwQTdAgqO+LCECBzbnb/R+v75U sA3w== X-Gm-Message-State: AO0yUKUc/5ah9+4Cd9fvvmJLKx5pwxi0GhytsWuTxipqWEmvk7gjWxMA QZax1VylGAmnrM4RCBBlNul4AOro1+3nNb3zU33WNYyzXpaV8A== X-Google-Smtp-Source: AK7set+HL9iLVxFBrTI3An3Y6QkZ3iXB5px+k1BKDQ8LHGdqw2MYWdH90x06422athL5dmx9C57yUOEZqrY/NQDVJDc= X-Received: by 2002:a05:6902:185:b0:9fe:1493:8b9 with SMTP id t5-20020a056902018500b009fe149308b9mr1592517ybh.8.1677680274805; Wed, 01 Mar 2023 06:17:54 -0800 (PST) MIME-Version: 1.0 References: <20230223222513.3759-1-dheitmueller@ltnglobal.com> <20230223222513.3759-2-dheitmueller@ltnglobal.com> <106ca8ce-ea36-75f3-d6ce-fbaf65fa1bfe@passwd.hu> In-Reply-To: <106ca8ce-ea36-75f3-d6ce-fbaf65fa1bfe@passwd.hu> From: Devin Heitmueller Date: Wed, 1 Mar 2023 09:17:44 -0500 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/3] decklink: Don't take for granted that first frame to decklink output will be PTS 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Feb 28, 2023 at 3:46 PM Marton Balint wrote: > And what if first packet pts is 0? Then the second packet pts will be > assigned to first pts? Maybe you should use AV_NOPTS_VALUE for the default > first_pts value and check for that instead. That's a good point. I never noticed that, but noticing that the first frame got dropped is probably not something that would have been immediately obvious. In any case, I prefer your approach and will resubmit. Thanks for the feedback, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".