From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] decklink: Don't take for granted that first frame to decklink output will be PTS 0
Date: Wed, 1 Mar 2023 09:17:44 -0500
Message-ID: <CAHGibzFQKRmYL8MJohYxfnZ=1jsXCaDMNfLf0tevVthcuJsLQQ@mail.gmail.com> (raw)
In-Reply-To: <106ca8ce-ea36-75f3-d6ce-fbaf65fa1bfe@passwd.hu>
On Tue, Feb 28, 2023 at 3:46 PM Marton Balint <cus@passwd.hu> wrote:
> And what if first packet pts is 0? Then the second packet pts will be
> assigned to first pts? Maybe you should use AV_NOPTS_VALUE for the default
> first_pts value and check for that instead.
That's a good point. I never noticed that, but noticing that the
first frame got dropped is probably not something that would have been
immediately obvious.
In any case, I prefer your approach and will resubmit.
Thanks for the feedback,
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-01 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 22:25 [FFmpeg-devel] [PATCH 0/3] Minor decklink output fixes Devin Heitmueller
2023-02-23 22:25 ` [FFmpeg-devel] [PATCH 1/3] decklink: Don't take for granted that first frame to decklink output will be PTS 0 Devin Heitmueller
2023-02-28 20:45 ` Marton Balint
2023-03-01 14:17 ` Devin Heitmueller [this message]
2023-02-23 22:25 ` [FFmpeg-devel] [PATCH 2/3] decklink: Fix setting of last_pts to only be set for video Devin Heitmueller
2023-02-23 22:25 ` [FFmpeg-devel] [PATCH 3/3] decklink: Fix unused variable compiler warnings Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHGibzFQKRmYL8MJohYxfnZ=1jsXCaDMNfLf0tevVthcuJsLQQ@mail.gmail.com' \
--to=devin.heitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git