Re: [FFmpeg-devel] [PATCH v5 1/6] ccfifo: Properly handle CEA-708 captions through framerate conversion

From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v5 1/6] ccfifo: Properly handle CEA-708 captions through framerate conversion
Date: Fri, 5 May 2023 11:23:43 -0400
Message-ID: <CAHGibzFF=DydEKXSZMVojo09FT4RaVCmCmjU8WQfrP1FnfiQ2A@mail.gmail.com> (raw)
In-Reply-To: <CAM=jba9huSkyQRCyxvhsn5igj-UDpzD19BZXUDzfxL9vBaW=CA@mail.gmail.com>

On Fri, May 5, 2023 at 10:10 AM Lance Wang <lance.lmwang@gmail.com> wrote:
> > +int ff_ccfifo_inject(AVCCFifo *ccf, AVFrame *frame)
> > +{
> > +    AVFrameSideData *sd;
> > +    int ret;
> > +
> > +    if (ccf->passthrough == 1 || ccf->cc_detected == 0)
> > +        return 0;
> > +
> > +    sd = av_frame_new_side_data(frame, AV_FRAME_DATA_A53_CC,
> > +                                ff_ccfifo_getoutputsize(ccf));
> > +    if (sd) {
> > +        ret = ff_ccfifo_injectbytes(ccf, sd->data, sd->size);
> > +        if (ret < 0) {
> > +            av_frame_remove_side_data(frame, AV_FRAME_DATA_A53_CC);
> > +            return AVERROR(ENOMEM);
> >
>
> prefer to return ret from ff_ccfifo_injectbytes()

Ok.  I've got to regenerate patch #1 in the series anyway because of
the fate bug Michael reported, so it's easy enough to change this to
"return ret".

Thanks,

Devin

-- 
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com  e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".