Re: [FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data

From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>,
	Devin Heitmueller <dheitmueller@ltnglobal.com>
Subject: Re: [FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data
Date: Mon, 3 Jul 2023 08:51:20 -0400
Message-ID: <CAHGibzFD+apWfHnUK6HhVEdxJ_k_rW=YKUpcVDGWOJRXca-Nog@mail.gmail.com> (raw)
In-Reply-To: <168819911380.21886.2308739362539561164@lain.khirnov.net>

On Sat, Jul 1, 2023 at 4:11 AM Anton Khirnov <anton@khirnov.net> wrote:
> >  /**
> > + * Bar data - used by side data for avcodec and avframe.  Defines the location
> > + * of horizontal or vertical black bars (i.e. letterbox/pillar bars)
> > + */
> > +typedef struct AVBarData {
> > +    int top_bottom; /* 0=top/bottom 1=left/right */
> > +    int top;
> > +    int left;
> > +    int bottom;
> > +    int right;
>
> Am I understanding correctly that half of these are never used for a
> given AVBarData instance? Seems wasteful. Could make it a generic
> bound0, bound1 or a union instead.

It was only an extra eight bytes per video frame, so I wasn't
particularly worried about the size.  That said, perhaps a union would
make it more clear that you can't set both simultaneously.

Devin

-- 
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com  e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".