From: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting
Date: Thu, 13 Feb 2025 17:03:47 -0500
Message-ID: <CAHGibzEvbraCDSMpbc-exRT9Xm-POf9mLviL_xTzLUvvrWfK3A@mail.gmail.com> (raw)
In-Reply-To: <CAJgjuoyMJA6OQG4vsd6aL3FSiCaO3weQG4_dzS9L0udGth66Aw@mail.gmail.com>
On Thu, Feb 13, 2025 at 4:06 PM Pavel Koshevoy <pkoshevoy@gmail.com> wrote:
> I've submitted a 3rd version of the patch that doesn't do as much
> over-allocation, similar to
> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310456.html
> My v3 patch works correctly with the 2 sample files I can test with.
Your patch looks substantially more complicated than the one from two
years ago. Does it address some edge case(s) that Sebastian's patch
didn't handle?
If your patch is better in some way then so be it. But if it's
functionally equivalent I would suggest we merge Sebastian's patch as
it's simpler.
Devin
--
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-02-13 22:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 0:09 Pavel Koshevoy
2025-02-13 2:23 ` Pavel Koshevoy
2025-02-13 6:46 ` Andreas Rheinhardt
2025-02-13 17:56 ` Pavel Koshevoy
2025-02-13 19:01 ` Devin Heitmueller
2025-02-13 19:59 ` Pavel Koshevoy
2025-02-13 20:12 ` Devin Heitmueller
2025-02-13 21:05 ` Pavel Koshevoy
2025-02-13 22:03 ` Devin Heitmueller [this message]
2025-02-13 22:35 ` Pavel Koshevoy
2025-02-13 22:53 ` Pavel Koshevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHGibzEvbraCDSMpbc-exRT9Xm-POf9mLviL_xTzLUvvrWfK3A@mail.gmail.com \
--to=devin.heitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git