Re: [FFmpeg-devel] [PATCH 0/5] Provide neon implementation for me_cmp functions

From: Hubert Mazur <hum@semihalf.com>
To: "Martin Storsjö" <martin@martin.st>
Cc: Grzegorz Bernacki <gjb@semihalf.com>,
	upstream@semihalf.com, "Swinney, Jonathan" <jswinney@amazon.com>,
	ffmpeg-devel@ffmpeg.org, Marcin Wojtas <mw@semihalf.com>,
	"Pop, Sebastian" <spop@amazon.com>
Subject: Re: [FFmpeg-devel] [PATCH 0/5] Provide neon implementation for me_cmp functions
Date: Thu, 18 Aug 2022 11:24:55 +0200
Message-ID: <CAGEip37Hb6DQB3dsc7GfDERRxaH30qan--rrps1r_p8Kz=LQtw@mail.gmail.com> (raw)
In-Reply-To: <ee796c5-b734-c164-363-9f7ad670cde5@martin.st>

Thanks for the review and pointing out the issues. I will check out the
other patches for such things and fix them if needed.

Regards

On Thu, Aug 18, 2022 at 11:08 AM Martin Storsjö <martin@martin.st> wrote:

> On Tue, 16 Aug 2022, Hubert Mazur wrote:
>
> > Add arm64 neon implementation for functions from motion estimation
> > family. All of them were tested and benchmarked using checkasm tool.
> > The rare code paths, e.g. when filter_size % 4 != 0 were also tested.
>
>
> > Instructions were manualy deinterleaved to reach best performance.
>
> You probably mean "interleaved", as deinterleaved would be how it was
> initially, which is detrimental for performance.
>
> Overall I think this patchset is close enough now. There were a bunch of
> minor details left on the patches, but I'll fix that up locally and push
> them, instead of doing yet another round of these. I'll comment and point
> out the details I changed - please pay attention to them for future
> patches though!
>
> // Martin
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".