From: Hubert Mazur <hum@semihalf.com>
To: "Martin Storsjö" <martin@martin.st>
Cc: Grzegorz Bernacki <gjb@semihalf.com>,
Jonathan Swinney <jswinney@amazon.com>,
ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] aarch64: me_cmp: Avoid using the non-unrolled codepath for the minimum unroll size
Date: Wed, 28 Sep 2022 11:19:26 +0200
Message-ID: <CAGEip347FStZZzcEy3AQJfyP4nvHXBZ8mDqfLfDdJPHAf9hWOQ@mail.gmail.com> (raw)
In-Reply-To: <20220928091334.7838-2-martin@martin.st>
LGTM.
On Wed, Sep 28, 2022 at 11:13 AM Martin Storsjö <martin@martin.st> wrote:
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> libavcodec/aarch64/me_cmp_neon.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/aarch64/me_cmp_neon.S
> b/libavcodec/aarch64/me_cmp_neon.S
> index 832a7cb22d..c710358ab7 100644
> --- a/libavcodec/aarch64/me_cmp_neon.S
> +++ b/libavcodec/aarch64/me_cmp_neon.S
> @@ -471,7 +471,7 @@ function sse8_neon, export=1
> movi v21.4s, #0
> movi v20.4s, #0
> cmp w4, #4
> - b.le 2f
> + b.lt 2f
>
> // make 4 iterations at once
> 1:
> @@ -534,7 +534,7 @@ function sse4_neon, export=1
>
> movi v16.4s, #0 // clear the
> result accumulator
> cmp w4, #4
> - b.le 2f
> + b.lt 2f
>
> // make 4 iterations at once
> 1:
> @@ -663,7 +663,7 @@ function vsse16_neon, export=1
> cmp w4, #3 // check if we
> can make 3 iterations at once
> usubl v31.8h, v0.8b, v1.8b // Signed
> difference of pix1[0] - pix2[0], first iteration
> usubl2 v30.8h, v0.16b, v1.16b // Signed
> difference of pix1[0] - pix2[0], first iteration
> - b.le 2f
> + b.lt 2f
>
>
> 1:
> --
> 2.25.1
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-28 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:13 [FFmpeg-devel] [PATCH 1/2] aarch64: me_cmp: Avoid redundant loads in ff_pix_abs16_y2_neon Martin Storsjö
2022-09-28 9:13 ` [FFmpeg-devel] [PATCH 2/2] aarch64: me_cmp: Avoid using the non-unrolled codepath for the minimum unroll size Martin Storsjö
2022-09-28 9:19 ` Hubert Mazur [this message]
2022-09-28 9:18 ` [FFmpeg-devel] [PATCH 1/2] aarch64: me_cmp: Avoid redundant loads in ff_pix_abs16_y2_neon Hubert Mazur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGEip347FStZZzcEy3AQJfyP4nvHXBZ8mDqfLfDdJPHAf9hWOQ@mail.gmail.com \
--to=hum@semihalf.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=gjb@semihalf.com \
--cc=jswinney@amazon.com \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git