From: StreamNG Harold Camargo <haroldcamargo@stream-ng.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mjpegenc: take into account component count when writing the SOF header size
Date: Thu, 24 Nov 2022 18:31:25 -0500
Message-ID: <CAF_rk7_OKph4Q+S4eu99dhmU9HghD9945TPmpZ6w6uqcqneujw@mail.gmail.com> (raw)
In-Reply-To: <a2f70313-d07c-4c36-2e8c-ef42ea6f7c86@gmail.com>
please unsuscribe.
Harold F. Camargo R.
Stream NG
Cel. 318 3227862
Bogotá Colombia
www.stream-ng.com
El jue, 24 nov 2022 a las 18:24, James Almer (<jamrial@gmail.com>) escribió:
> On 11/24/2022 8:12 PM, Carl Eugen Hoyos wrote:
> > Am Fr., 25. Nov. 2022 um 00:00 Uhr schrieb James Almer <
> jamrial@gmail.com>:
> >>
> >> Fixes ticket #10069
> >>
> >> Signed-off-by: James Almer <jamrial@gmail.com>
> >> ---
> >> libavcodec/mjpegenc_common.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/libavcodec/mjpegenc_common.c b/libavcodec/mjpegenc_common.c
> >> index 6dfc4469a5..049ae3d929 100644
> >> --- a/libavcodec/mjpegenc_common.c
> >> +++ b/libavcodec/mjpegenc_common.c
> >> @@ -308,7 +308,7 @@ void ff_mjpeg_encode_picture_header(AVCodecContext
> *avctx, PutBitContext *pb,
> >> default: av_assert0(0);
> >> }
> >>
> >> - put_bits(pb, 16, 17);
> >> + put_bits(pb, 16, 8 + 3 * components);
> >
> > Could this also fix #2967?
> >
> > Carl Eugen
>
> Doesn't look like. The examples in that ticket have all three
> components, which was the hardcoded len value (17) before this patch.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-11-24 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 23:00 James Almer
2022-11-24 23:12 ` Carl Eugen Hoyos
2022-11-24 23:24 ` James Almer
2022-11-24 23:31 ` StreamNG Harold Camargo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF_rk7_OKph4Q+S4eu99dhmU9HghD9945TPmpZ6w6uqcqneujw@mail.gmail.com \
--to=haroldcamargo@stream-ng.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git