[FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[pal]

From: Pierre-Anthony Lemieux <pal@palemieux.com>

---
 libavformat/imfdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index 03de9ce151..a92686e93b 100644
--- a/libavformat/imfdec.c
+++ b/libavformat/imfdec.c
@@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
 const AVInputFormat ff_imf_demuxer = {
     .name           = "imf",
     .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable Master Format)"),
-    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
+    .flags          = AVFMT_NO_BYTE_SEEK,
     .flags_internal = FF_FMT_INIT_CLEANUP,
     .priv_class     = &imf_class,
     .priv_data_size = sizeof(IMFContext),
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 2/3] doc: improve IMF demuxer documentation

[pal]

From: Pierre-Anthony Lemieux <pal@palemieux.com>

---
 doc/demuxers.texi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index 2b6dd86c2a..75c142935e 100644
--- a/doc/demuxers.texi
+++ b/doc/demuxers.texi
@@ -289,7 +289,15 @@ This demuxer accepts the following option:
 
 Interoperable Master Format demuxer.
 
-This demuxer presents audio and video streams found in an IMF Composition.
+This demuxer presents audio and video streams found in an IMF Composition, as
+specified in @url{https://doi.org/10.5594/SMPTE.ST2067-2.2020, SMPTE ST 2067-2}.
+
+@example
+ffmpeg [-assetmaps <path of ASSETMAP1>,<path of ASSETMAP2>,...] -i <path of CPL> ...
+@end example
+
+If @code{-assetmaps} is not specified, the demuxer looks for a file called
+@file{ASSETMAP.xml} in the same directory as the CPL.
 
 @section flv, live_flv, kux
 
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 3/3] fate/imfdec: remove imf experimental flag

[pal]

From: Pierre-Anthony Lemieux <pal@palemieux.com>

---
 tests/fate/imf.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/fate/imf.mak b/tests/fate/imf.mak
index feb54d1361..d64882f89e 100644
--- a/tests/fate/imf.mak
+++ b/tests/fate/imf.mak
@@ -1,5 +1,5 @@
 FATE_IMF += fate-imf-cpl-with-repeat
-fate-imf-cpl-with-repeat: CMD = framecrc -f imf -i $(TARGET_SAMPLES)/imf/countdown/CPL_bb2ce11c-1bb6-4781-8e69-967183d02b9b.xml -c:v copy
+fate-imf-cpl-with-repeat: CMD = framecrc -i $(TARGET_SAMPLES)/imf/countdown/CPL_bb2ce11c-1bb6-4781-8e69-967183d02b9b.xml -c:v copy
 
 FATE_SAMPLES_FFMPEG-$(CONFIG_IMF_DEMUXER) += $(FATE_IMF)
 
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[Tomas Härdin]

tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> From: Pierre-Anthony Lemieux <pal@palemieux.com>
> 
> ---
>  libavformat/imfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> index 03de9ce151..a92686e93b 100644
> --- a/libavformat/imfdec.c
> +++ b/libavformat/imfdec.c
> @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
>  const AVInputFormat ff_imf_demuxer = {
>      .name           = "imf",
>      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> Master Format)"),
> -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> +    .flags          = AVFMT_NO_BYTE_SEEK,
>      .flags_internal = FF_FMT_INIT_CLEANUP,
>      .priv_class     = &imf_class,
>      .priv_data_size = sizeof(IMFContext),

This demuxer is really limited though, right?

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[Pierre-Anthony Lemieux]

On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin <git@haerdin.se> wrote:
>
> tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> >
> > ---
> >  libavformat/imfdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > index 03de9ce151..a92686e93b 100644
> > --- a/libavformat/imfdec.c
> > +++ b/libavformat/imfdec.c
> > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> >  const AVInputFormat ff_imf_demuxer = {
> >      .name           = "imf",
> >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> > Master Format)"),
> > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > +    .flags          = AVFMT_NO_BYTE_SEEK,
> >      .flags_internal = FF_FMT_INIT_CLEANUP,
> >      .priv_class     = &imf_class,
> >      .priv_data_size = sizeof(IMFContext),
>
> This demuxer is really limited though, right?

Can you clarify what you mean by "limited"?

The demuxer is intended to only process IMF packages (playlist + track files).

>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[Tomas Härdin]

fre 2023-01-06 klockan 07:50 -0800 skrev Pierre-Anthony Lemieux:
> On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin <git@haerdin.se> wrote:
> > 
> > tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> > > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> > > 
> > > ---
> > >  libavformat/imfdec.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > > index 03de9ce151..a92686e93b 100644
> > > --- a/libavformat/imfdec.c
> > > +++ b/libavformat/imfdec.c
> > > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> > >  const AVInputFormat ff_imf_demuxer = {
> > >      .name           = "imf",
> > >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> > > Master Format)"),
> > > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > > +    .flags          = AVFMT_NO_BYTE_SEEK,
> > >      .flags_internal = FF_FMT_INIT_CLEANUP,
> > >      .priv_class     = &imf_class,
> > >      .priv_data_size = sizeof(IMFContext),
> > 
> > This demuxer is really limited though, right?
> 
> Can you clarify what you mean by "limited"?
> 
> The demuxer is intended to only process IMF packages (playlist +
> track files).

Perhaps I was speaking ahead. Last time I looked lavf was not capable
of performing the kind of NLE functionality required for full IMF
support. Perhaps imfdec does that internally? It doesn't seem so..

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[Pierre-Anthony Lemieux]

On Fri, Jan 6, 2023 at 8:09 AM Tomas Härdin <git@haerdin.se> wrote:
>
> fre 2023-01-06 klockan 07:50 -0800 skrev Pierre-Anthony Lemieux:
> > On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin <git@haerdin.se> wrote:
> > >
> > > tor 2023-01-05 klockan 15:29 -0800 skrev pal@sandflow.com:
> > > > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> > > >
> > > > ---
> > > >  libavformat/imfdec.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > > > index 03de9ce151..a92686e93b 100644
> > > > --- a/libavformat/imfdec.c
> > > > +++ b/libavformat/imfdec.c
> > > > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> > > >  const AVInputFormat ff_imf_demuxer = {
> > > >      .name           = "imf",
> > > >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable
> > > > Master Format)"),
> > > > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > > > +    .flags          = AVFMT_NO_BYTE_SEEK,
> > > >      .flags_internal = FF_FMT_INIT_CLEANUP,
> > > >      .priv_class     = &imf_class,
> > > >      .priv_data_size = sizeof(IMFContext),
> > >
> > > This demuxer is really limited though, right?
> >
> > Can you clarify what you mean by "limited"?
> >
> > The demuxer is intended to only process IMF packages (playlist +
> > track files).
>
> Perhaps I was speaking ahead. Last time I looked lavf was not capable
> of performing the kind of NLE functionality required for full IMF
> support. Perhaps imfdec does that internally? It doesn't seem so..

The demuxer supports the full range of playlist (CPL) functionality,
including multiple non-coincident resources and resource repeats.

Only audio and image are supported for now.

See the current FATE test and the additional proposal sample at:

https://patchwork.ffmpeg.org/project/ffmpeg/patch/20221230071243.24762-1-pal@sandflow.com/


>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[Anton Khirnov]

Quoting pal@sandflow.com (2023-01-06 00:29:44)
> From: Pierre-Anthony Lemieux <pal@palemieux.com>
> 
> ---
>  libavformat/imfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> index 03de9ce151..a92686e93b 100644
> --- a/libavformat/imfdec.c
> +++ b/libavformat/imfdec.c
> @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
>  const AVInputFormat ff_imf_demuxer = {
>      .name           = "imf",
>      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable Master Format)"),
> -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> +    .flags          = AVFMT_NO_BYTE_SEEK,

The demuxer has been upstream for quite a while without too many issues,
so I'd say this is reasonable.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

[Pierre-Anthony Lemieux]

On Mon, Feb 20, 2023 at 9:55 AM Anton Khirnov <anton@khirnov.net> wrote:
>
> Quoting pal@sandflow.com (2023-01-06 00:29:44)
> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> >
> > ---
> >  libavformat/imfdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> > index 03de9ce151..a92686e93b 100644
> > --- a/libavformat/imfdec.c
> > +++ b/libavformat/imfdec.c
> > @@ -1018,7 +1018,7 @@ static const AVClass imf_class = {
> >  const AVInputFormat ff_imf_demuxer = {
> >      .name           = "imf",
> >      .long_name      = NULL_IF_CONFIG_SMALL("IMF (Interoperable Master Format)"),
> > -    .flags          = AVFMT_EXPERIMENTAL | AVFMT_NO_BYTE_SEEK,
> > +    .flags          = AVFMT_NO_BYTE_SEEK,
>
> The demuxer has been upstream for quite a while without too many issues,
> so I'd say this is reasonable.

Ok. Will apply tomorrow unless objections are raised.

>
> --
> Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".