From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5910144314 for ; Mon, 5 Sep 2022 20:11:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B9FBF68B6D3; Mon, 5 Sep 2022 23:10:59 +0300 (EEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C28BE68B6F0 for ; Mon, 5 Sep 2022 23:10:53 +0300 (EEST) Received: by mail-pj1-f52.google.com with SMTP id t11-20020a17090a510b00b001fac77e9d1fso12963208pjh.5 for ; Mon, 05 Sep 2022 13:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=WUksPM7yOMH8MxsTWKR9KKkPcKlLt7eHEVplWXzFJ3w=; b=X5hpeFUjXmJFp/DeqUA99+ujkyDG8WGpyT2IF+1uy+X0RKbzHsnf+PZxV/J3aP/cRR iiNiLZsZOumhz+QRWv7HPBq6vMz6Zp3uMZ9ELkEiyIBURSWO/kW+E640V3NV2LWUm4T8 ccCe0xIqHx4kptOuIp2EoAIxVDa1nOij/imWZ/Vvg+atXD/vdKzIDshvah0jJz1quic8 WzqB8jFl0XcpoT80MvxG9C9IHUXAAFnhKAG7rxcbOa6360ZUaojIb7q5Kojg2Q1Xsm+6 ay+ty2VtGwK/yv0a420ry3co8UgX/MxRUlmHYU+y3GW/qekZyQvYWFlMsUiEV3b2lJtf J1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=WUksPM7yOMH8MxsTWKR9KKkPcKlLt7eHEVplWXzFJ3w=; b=ejW/7fXuTAiZ2qbB1mEi8D6uMKRW21gT2t06F6+sNrfwfGAtbJlc3ZuWBRlZs4RstA bUVa4TnDPpRiTKC77PdqZ6435DWV6IB3SbA/MVFQOqjventD9smiCsX5orVsLykMOw// TGtYa2D074sqJxOqMxW0/GBmed0sd2h98EToLsJnIQSYKKKaUJTCkFPzKDDaVadLgxWy IkyMzUowtvZcggrGQ6f9ycWowKKT+EPUIse720im2C7eF3aX9sOC0l4kaehZI1atwEKG IoU6CdV8Fh9nU4864Htg4imPrgYJs9Mo9wbZGCfTTFbKm8O9lapeTDE4OqP4kU6Rt7zM 7mPA== X-Gm-Message-State: ACgBeo07rEzHBjsKER7fIQ54r8BVnzIXpDHobwJ9xoHI3w2LE/5i9T/S lY5YgpYh3O/nOxPb2V41ZTwBHqJ4khzE+Q== X-Google-Smtp-Source: AA6agR7eb7w7S61+YthzhUTO4j0duT7oMw4ng6Q4t+96GwoZ+Ed/pNUQtDNqWv1Tu8X+DATAUHSVeg== X-Received: by 2002:a17:902:e745:b0:174:dfce:bdcd with SMTP id p5-20020a170902e74500b00174dfcebdcdmr36738801plf.12.1662408651041; Mon, 05 Sep 2022 13:10:51 -0700 (PDT) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com. [209.85.216.44]) by smtp.gmail.com with ESMTPSA id j2-20020a170902758200b0016d773aae60sm7883215pll.19.2022.09.05.13.10.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 13:10:50 -0700 (PDT) Received: by mail-pj1-f44.google.com with SMTP id n65-20020a17090a5ac700b001fbb4fad865so9421724pji.1 for ; Mon, 05 Sep 2022 13:10:49 -0700 (PDT) X-Received: by 2002:a17:90a:c981:b0:1fe:55ef:b60f with SMTP id w1-20020a17090ac98100b001fe55efb60fmr21545638pjt.246.1662408649362; Mon, 05 Sep 2022 13:10:49 -0700 (PDT) MIME-Version: 1.0 References: <20220826032153.29482-1-pal@sandflow.com> In-Reply-To: <20220826032153.29482-1-pal@sandflow.com> From: Pierre-Anthony Lemieux Date: Mon, 5 Sep 2022 13:10:37 -0700 X-Gmail-Original-Message-ID: Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v1] avformat/imfdec: check if Asset/Id exists before trying to read it X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping. This fixes Coverity issue #1512406. On Thu, Aug 25, 2022 at 8:22 PM wrote: > > From: Pierre-Anthony Lemieux > > Fixes Coverity issue #1512406 > > --- > libavformat/imfdec.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > index 5bbe7a53f8..fde91a6419 100644 > --- a/libavformat/imfdec.c > +++ b/libavformat/imfdec.c > @@ -233,7 +233,12 @@ static int parse_imf_asset_map_from_xml_dom(AVFormatContext *s, > > asset = &(asset_map->assets[asset_map->asset_count]); > > - if (ff_imf_xml_read_uuid(ff_imf_xml_get_child_element_by_name(asset_element, "Id"), asset->uuid)) { > + if (!(node = ff_imf_xml_get_child_element_by_name(asset_element, "Id"))) { > + av_log(s, AV_LOG_ERROR, "Unable to parse asset map XML - missing Id node\n"); > + return AVERROR_INVALIDDATA; > + } > + > + if (ff_imf_xml_read_uuid(node, asset->uuid)) { > av_log(s, AV_LOG_ERROR, "Could not parse UUID from asset in asset map.\n"); > return AVERROR_INVALIDDATA; > } > -- > 2.25.1 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".