From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 73B26403E5 for ; Mon, 20 Dec 2021 19:49:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0594268AFE9; Mon, 20 Dec 2021 21:49:05 +0200 (EET) Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8682C68AFCF for ; Mon, 20 Dec 2021 21:48:58 +0200 (EET) Received: by mail-io1-f50.google.com with SMTP id m9so14871292iop.0 for ; Mon, 20 Dec 2021 11:48:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=IvFsy5SeyzifOXpsL3ky9qw7FLANQLV4DueYwvADMfk=; b=zYO7Xv+IGKyCza5bjceNvU0+0u8gAzdp/8p6WztNergdsLBoDdiSi8DNRslBfYNDAh 1jcVjvTvHBCu8HGi1Y3baK7QD85fNHDA1Iu2DMo7OV0MmKjdvtiUWydyN2ie0uOehD4i wIbWLCU30x4NZ8cMS4GRvJWIt+j3je+sCnOLJMjby+D4Dz9xwHz54mgMACJJACDQp8Qx P4v80LlWkE2Qn2WQUnslHTunx5gHJco6qHGGMuYLxqsoUN5TYgtk5BMzCC72vxLqFoFK pIZAFtXYj1RbNmoLs+Q3gIUY3YSkjwozM6CAjnY5Y4nn7GDO25aTI01oncat76GtrGnl H7uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=IvFsy5SeyzifOXpsL3ky9qw7FLANQLV4DueYwvADMfk=; b=EAceUDfF9+RNbiWCHxZtlNzf1R3UqbTq4foWK9iPlo7hbuKTiIBDA66lCY5PxAGWlq Lx62ycYDrr9KkOrfpF7/NT0+YQ4OSz0bKC6RU+DZaR+e4l6vYJkq1WiBQaqqc2EF1xOA hcgBBtVSjtVU5Ty2w/YWKRjItP4H+khHu+iGAIGR9eqkXlcKwmpAqVvYnivnuF/otOBG 6JQFrRwGmvp6B83JQ0ucZC2TIHxLuipOjB0Xz2DASIjalxtYXx0TFMJI9mhbsFMi2/39 iMI8kLCvLX4dkFeBR/9dOQGSyQdbybH8/DV5Mn88XrQPxnPcOXjssUpYRS+zVRfuKF9n hiSQ== X-Gm-Message-State: AOAM533Tvc7tTnq6N71E8ufM3OIV9tZLKTReFHbBct0BnzmvxmZ2Vi5x 3tlVasaP57ZrgRwFwNHSCTF13H7jSVLxjA== X-Google-Smtp-Source: ABdhPJweTkNyTc2lzbYDre1wIFZdSeOnLJ8mbPmViMRdCXySUA6pnEDmek602EhkTmfJvoLQdttRMQ== X-Received: by 2002:a05:6638:250a:: with SMTP id v10mr11198355jat.119.1640029736957; Mon, 20 Dec 2021 11:48:56 -0800 (PST) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com. [209.85.166.173]) by smtp.gmail.com with ESMTPSA id x11sm9612938iop.55.2021.12.20.11.48.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Dec 2021 11:48:56 -0800 (PST) Received: by mail-il1-f173.google.com with SMTP id w1so8452872ilh.9 for ; Mon, 20 Dec 2021 11:48:56 -0800 (PST) X-Received: by 2002:a05:6e02:20cb:: with SMTP id 11mr2542155ilq.163.1640029735749; Mon, 20 Dec 2021 11:48:55 -0800 (PST) MIME-Version: 1.0 References: <20211220185725.19519-1-pal@sandflow.com> In-Reply-To: From: Pierre-Anthony Lemieux Date: Mon, 20 Dec 2021 11:48:44 -0800 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] avformat/imf: Demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Dec 20, 2021 at 11:19 AM Lynne wrote: > > 20 Dec 2021, 19:57 by pal@sandflow.com: > > > From: Pierre-Anthony Lemieux > > > > Signed-off-by: Pierre-Anthony Lemieux > > --- > > > > Notes: > > The IMF demuxer accepts as input an IMF CPL. The assets referenced by the CPL can be > > contained in multiple deliveries, each defined by an ASSETMAP file: > > > > ffmpeg -assetmaps ,,... -i > > > > If -assetmaps is not specified, FFMPEG looks for a file called ASSETMAP.xml in the same directory as the CPL. > > > > EXAMPLE: > > ffmpeg -i http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml out.mp4 > > > > The Interoperable Master Format (IMF) is a file-based media format for the > > delivery and storage of professional audio-visual masters. > > An IMF Composition consists of an XML playlist (the Composition Playlist) > > and a collection of MXF files (the Track Files). The Composition Playlist (CPL) > > assembles the Track Files onto a timeline, which consists of multiple tracks. > > The location of the Track Files referenced by the Composition Playlist is stored > > in one or more XML documents called Asset Maps. More details at https://www.imfug.com/explainer. > > The IMF standard was first introduced in 2013 and is managed by the SMPTE. > > > > CHANGE NOTES: > > > > - added libavformat/tests/imf to FATE > > > > MAINTAINERS | 1 + > > configure | 3 +- > > doc/demuxers.texi | 6 + > > libavformat/Makefile | 1 + > > libavformat/allformats.c | 1 + > > libavformat/imf.h | 207 +++++++++ > > libavformat/imf_cpl.c | 800 +++++++++++++++++++++++++++++++++++ > > libavformat/imfdec.c | 891 +++++++++++++++++++++++++++++++++++++++ > > 8 files changed, 1909 insertions(+), 1 deletion(-) > > create mode 100644 libavformat/imf.h > > create mode 100644 libavformat/imf_cpl.c > > create mode 100644 libavformat/imfdec.c > > > > You've once again gone back and completely ignored all coding style > issues I pointed out. This was definitely not the intent, and I do not believe that *ignored all coding style* is accurate. For example, most of the suggestions you made at [1] on December 5 have been integrated, including: using ff_ for internal functions, using FF for structs, reducing line length, etc. It might be that some of the changes you suggested conflicted with changes that others suggested. Regarding the use of libuuid, I believe this should be done after the patch is merged since it affects other parts of the system and libuuid cannot be used as-is. I am happy to volunteer to lead such an effort, as suggested before. [1] http://ffmpeg.org/pipermail/ffmpeg-devel/2021-December/288853.html > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".