From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4A0AB445AB for ; Fri, 16 Sep 2022 19:51:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 541B768BC0F; Fri, 16 Sep 2022 22:51:24 +0300 (EEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D76A68BBE5 for ; Fri, 16 Sep 2022 22:51:18 +0300 (EEST) Received: by mail-pf1-f181.google.com with SMTP id y136so22225257pfb.3 for ; Fri, 16 Sep 2022 12:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=9hLH5iUOkeDuTC1mfUjWUIhM8Yzcxv7c+yeF5MUQhMQ=; b=8Fo77fX83Vd0wm4qCUUcRyue4RmAp43RKEqn7qQl1DUEHRepaC9kUKVM3C1WQwIo9c uUyRGW2CAFaHFAfXngxocfWso9eDNINMkmG4kAaXb+2Pe6uIISSeQccNpkXhhXdOkYRE jRh2B/vn71AU2p6Hgrimi1H2N02OeIuMcxBIXCHaBYV9xbgY+4wlQOYGqxPII+6Z4Xvk 2JPyz9KmhrRf3gkgD84F8NCILVzFJCAjv/L8rpNp1X82YSenwe22XzjIDruqBdoAp/HE gmfZ48bIidAmtgTwmicux1mKPqLYArUKgLWCvu4OxnBWUMy8YrsuUYiJYprB3YQJJvck snkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=9hLH5iUOkeDuTC1mfUjWUIhM8Yzcxv7c+yeF5MUQhMQ=; b=W+PsP+e7gZHCcN4Yj4V2vSwaBCFbygoP9qsHgKdbw7v82g6vspGbc12SYs5cbFspVS /CALLZiVYcZplX+CQfLxzbNZxUPwIH89Gk4JwX+0FasbE6kOaEWlqS8VhHxNsPZqbHp7 QE29PqR/TNP5SvHCiDfRe2IKY7TVZMVgsRLqxRX5+mj/2mGJuH68LTKXq/u/aHHsF2Ih N4v3Epya/NIIWX6cOuobe4dqubNaGUa174btwL5G7ItyWrl6RHDzgEfcXAVlPRROa8Jq i3NFCkoqGxyf1Veu6ycfXNzayoltbJkhachxa5fduYD+mT8Rc6wZAMjvZuwF3UVLMI2m 4Qyg== X-Gm-Message-State: ACrzQf2akZY5Q2dF2jSxS2EarIABiFdxY2MBv1NLFjR4Xk0wMzS0yIPx fKqh9WWZtbT01qkDJlha2S4IsR7x9P80/Q== X-Google-Smtp-Source: AMsMyM5HhdyIi7q7C8Y795AHN7CZhFNLUhtYrem9UOVuau6Ou+B1XwClLKUtKTzlr3un6fthWuTJAA== X-Received: by 2002:a62:ea04:0:b0:547:50c0:c5ef with SMTP id t4-20020a62ea04000000b0054750c0c5efmr6321757pfh.15.1663357875737; Fri, 16 Sep 2022 12:51:15 -0700 (PDT) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com. [209.85.215.182]) by smtp.gmail.com with ESMTPSA id n68-20020a622747000000b0053e599d7032sm14804965pfn.54.2022.09.16.12.51.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 12:51:15 -0700 (PDT) Received: by mail-pg1-f182.google.com with SMTP id s206so21301950pgs.3 for ; Fri, 16 Sep 2022 12:51:14 -0700 (PDT) X-Received: by 2002:aa7:8583:0:b0:53e:5344:2b7d with SMTP id w3-20020aa78583000000b0053e53442b7dmr6841112pfn.49.1663357873549; Fri, 16 Sep 2022 12:51:13 -0700 (PDT) MIME-Version: 1.0 References: <20220907200233.21255-1-pal@sandflow.com> <20220916172655.GV2088045@pb2> In-Reply-To: From: Pierre-Anthony Lemieux Date: Fri, 16 Sep 2022 12:51:01 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Sep 16, 2022 at 10:39 AM Pierre-Anthony Lemieux wrote: > > On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer > wrote: > > > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, pal@sandflow.com wrote: > > > From: Pierre-Anthony Lemieux > > > > > > Addresses coverity 1512414 > > > > > > --- > > > libavformat/imfdec.c | 15 ++++++++++++--- > > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > > > index 5bbe7a53f8..58b1455c9f 100644 > > > --- a/libavformat/imfdec.c > > > +++ b/libavformat/imfdec.c > > > @@ -681,8 +681,11 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma > > > { > > > IMFContext *c = s->priv_data; > > > IMFVirtualTrackPlaybackCtx *track; > > > > > + AVRational minimum_timestamp = av_make_q(INT_MAX, 1); > > > - AVRational minimum_timestamp = av_make_q(INT32_MAX, 1); > > > > iam not sure thats a good idea, it would change behavior on different platforms > > I was following the earlier observations that "The initialization of > minimum_timestamp presumes that int are 32bit which need not be true": > > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300587.html > > If I am not mistaken, the numerator and denominator of AVRational are > defined as `int`: > > https://www.ffmpeg.org/doxygen/trunk/structAVRational.html > > What would be the alternative? ... and see similar code at: https://github.com/FFmpeg/FFmpeg/blob/f05247f6a4698c14f1cd523daa90188f50dcf6ad/libavcodec/mpeg12framerate.c#L51 > > > > > thx > > > > [...] > > -- > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > > > it is not once nor twice but times without number that the same ideas make > > their appearance in the world. -- Aristotle > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".