From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F15E4078C for ; Sat, 30 Apr 2022 20:54:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D370968B252; Sat, 30 Apr 2022 23:54:09 +0300 (EEST) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 361726806E8 for ; Sat, 30 Apr 2022 23:54:04 +0300 (EEST) Received: by mail-ej1-f45.google.com with SMTP id kq17so21376482ejb.4 for ; Sat, 30 Apr 2022 13:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=FmS7Jh78Yd+4JYrxeuk05Oy65ePl648iB4CjNs55Fd8=; b=fTMe1TDf5k7hYoumvYmIE/QXmPomczK4JnBrX1mCGv5enTdYkDbxTriHgdhFd6mOZy lg3uP4OgaCPC4U4BuhpuTT02A9Q66v9PfkMydEu0aZjLadZysnWjKVtzuIU8vzl7GE+B h1CiT1axV47CfE7Y6V9jwTIcayIAB6tfRoFO5niOO7usujlPv/s/Oh4wvnYZQJ3H8ger SxMbpSxYPkCv2CJiiP6XF9nyep6lCWxK95CXuI6hSDJz9hPVRhPGbg3ea+C3+FefKyzO yvSycwLY49SixPPyjTa+NGoZ6uzzsL5xGEN+1gKwarmaS7ouKHnLrY4yv8obuWDhQli3 W4OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=FmS7Jh78Yd+4JYrxeuk05Oy65ePl648iB4CjNs55Fd8=; b=AidqMnnt5AcsiBca2MOPHSMWG/hURETRH7htKLTTIycQhd9NtUvSIXf3R0qXrK7H63 uBxzL1G5Qtwzq4HFKO7bJwdgtTmgL+qq6UGyn/9h3IRumJcejoUruxc/GvIVuY7R7RCR 2nW1LXbUc7AgKF7vZv2XXJEH/q3cvDOfS5xUHGq0jDPpDFt5QkurG0mPrUZW7RekR4Pk ArGuBMaLVfZMRvvUDnP9Tw8UJS9IV/3Z+WTgKeD7n7r9RiI3EYsqXJfmPMdZegPHtsgr VO5hZyohGJGko7lANh/17tugexGsDCAQB+Bo0xxAh5Ctpo1ktyi55IUmsLMhu78FZQaH 8xqA== X-Gm-Message-State: AOAM530G8o0x2+tWRqAKeX7K6eMUUCRjfcJxGbqnbVtpVR+hzCzceWi2 GbaWSHWs968l+Xgu0EUmrGxPuPmqYZrYZTw9 X-Google-Smtp-Source: ABdhPJzThsqQezu1hqqhqr8ldUjs9n1t8zr+wEW25H2wmnfSOWtGCFbfsPKHoDvRyo77CXSq44HXlw== X-Received: by 2002:a17:906:3ce9:b0:6ef:a8aa:ab46 with SMTP id d9-20020a1709063ce900b006efa8aaab46mr5085555ejh.579.1651352043151; Sat, 30 Apr 2022 13:54:03 -0700 (PDT) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com. [209.85.208.47]) by smtp.gmail.com with ESMTPSA id hz22-20020a1709072cf600b006f3ef214df2sm1947691ejc.88.2022.04.30.13.54.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Apr 2022 13:54:02 -0700 (PDT) Received: by mail-ed1-f47.google.com with SMTP id be20so12650276edb.12 for ; Sat, 30 Apr 2022 13:54:02 -0700 (PDT) X-Received: by 2002:a05:6402:190a:b0:425:e826:6c3f with SMTP id e10-20020a056402190a00b00425e8266c3fmr5882908edz.294.1651352042216; Sat, 30 Apr 2022 13:54:02 -0700 (PDT) MIME-Version: 1.0 References: <20220424101409.95486-1-zane@zanevaniperen.com> <20220424101409.95486-6-zane@zanevaniperen.com> <02a9b3be-e7a0-6283-188a-6033fde862b5@jkqxz.net> <111defba-5c26-ddf6-8c50-406bc18cccd2@jkqxz.net> In-Reply-To: <111defba-5c26-ddf6-8c50-406bc18cccd2@jkqxz.net> From: Pierre-Anthony Lemieux Date: Sat, 30 Apr 2022 13:53:49 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 5/7] avcodec/cbs_sei: refactor to use avutil/uuid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Apr 30, 2022 at 12:26 PM Mark Thompson wrote: > > On 30/04/2022 18:53, Pierre-Anthony Lemieux wrote: > > On Sat, Apr 30, 2022 at 10:31 AM Mark Thompson wrote: > >> > >> On 24/04/2022 11:14, Zane van Iperen wrote: > >>> From: Pierre-Anthony Lemieux > >>> > >>> --- > >>> libavcodec/cbs_sei.h | 3 ++- > >>> libavcodec/vaapi_encode_h264.c | 8 ++++---- > >>> 2 files changed, 6 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/libavcodec/cbs_sei.h b/libavcodec/cbs_sei.h > >>> index c7a7a95be0..67c6e6cbbd 100644 > >>> --- a/libavcodec/cbs_sei.h > >>> +++ b/libavcodec/cbs_sei.h > >>> @@ -23,6 +23,7 @@ > >>> #include > >>> > >>> #include "libavutil/buffer.h" > >>> +#include "libavutil/uuid.h" > >>> > >>> #include "cbs.h" > >>> #include "sei.h" > >>> @@ -41,7 +42,7 @@ typedef struct SEIRawUserDataRegistered { > >>> } SEIRawUserDataRegistered; > >>> > >>> typedef struct SEIRawUserDataUnregistered { > >>> - uint8_t uuid_iso_iec_11578[16]; > >>> + AVUUID uuid_iso_iec_11578; > >>> uint8_t *data; > >>> AVBufferRef *data_ref; > >>> size_t data_length; > >> > >> This feels like a step backwards? The syntax template files are explicitly relying on this being uint8_t[16], so giving it a different name is confusing. > > > > What/where are the syntax template files? > > > > (It's included twice by cbs_h2645.c for read/write with different macro setups.) Ok. Thanks. Are you concerned that the following line assumes that uuid_iso_iec_11578 is uint8_t[16] instead of being the opaque AVUUID? us(8, uuid_iso_iec_11578[i], 0x00, 0xff, 1, i); Did I get this right? If so, couple of options come to mind: (a) revert the change (b) define a macro to access individual bytes of AVUUID, thereby keeping AVUUID opaque (c) not handle AVUUID as opaque, but instead always as uint8_t[16] Maybe additional options exist. I do not have a definitive opinion. Some folks expressed strong interest in having a consistent scheme for manipulating UUIDs. > > - Mark > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".